Use NOTREACHED_IN_MIGRATION() in components/
This was generated by replacing " NOTREACHED()" with " NOTREACHED_IN_MIGRATION()" and running git cl format. This prepares for making NOTREACHED() [[noreturn]] alongside NotReachedIsFatal migration of existing inventory. Bug: 40580068 Change-Id: I92e83d0b564d44267f003147a1ce6ba3674621a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5539175 Owners-Override: Lei Zhang <thestig@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1300923}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
043e32e8ad
commit
aaf19db38d
components
account_id
account_manager_core
android_autofill
arc
intent_helper
assist_ranker
attribution_reporting
autofill
content
renderer
core
browser
address_data_manager.ccaddress_profile_save_manager.ccaddress_profile_save_manager_unittest.ccautofill_address_util.ccautofill_external_delegate.ccautofill_field.ccautofill_manager.ccautofill_profile_import_process.ccautofill_save_update_address_profile_delegate_ios.ccautofill_test_utils.ccbrowser_autofill_manager.ccbrowser_autofill_manager_unittest.cc
data_model
autofill_profile.ccautofill_profile_comparator.ccautofill_structured_address_regex_provider.cccredit_card.cciban.ccphone_number.cc
field_filling_payments_util_unittest.ccform_data_importer_unittest.ccform_filler.ccform_parsing
form_structure.ccform_structure_rationalizer.ccform_types.ccgeo
logging
metrics
autofill_metrics.ccfield_filling_stats_and_score_metrics.cclog_event.cc
payments
profile_import_metrics.ccquality_metrics_unittest.ccpayments
autofill_save_card_infobar_delegate_mobile.ccautofill_virtual_card_enrollment_infobar_delegate_mobile.cccredit_card_access_manager.cccredit_card_access_manager_unittest.cccredit_card_cvc_authenticator.cccredit_card_fido_authenticator.cccredit_card_otp_authenticator.cccredit_card_save_manager_unittest.ccfull_card_request.cclocal_card_migration_manager.ccpayments_network_interface_unittest.cc
payments_data_manager.ccrandomized_encoder.ccpayments_requests
get_card_upload_details_request.ccget_details_for_enrollment_request.ccget_details_for_enrollment_request_unittest.ccopt_change_request.ccunmask_card_request.ccupdate_virtual_card_enrollment_request.ccupdate_virtual_card_enrollment_request_unittest.cc
virtual_card_enroll_metrics_logger.ccvirtual_card_enrollment_manager_unittest.ccui
payments
webdata
addresses
autocomplete
payments
common
ios
browser
background_fetch
background_sync
blocked_content
bookmarks
browser
bookmark_client.ccbookmark_codec.ccbookmark_model.ccbookmark_model_unittest.ccbookmark_node_data_ios.ccbookmark_utils.cc
managed
browser_ui
site_settings
android
browsing_data
content
core
browsing_topics
captive_portal
cast
message_port
fuchsia
cast_streaming
browser
renderer
cbor
cdm
chromeos_camera
cloud_devices
common
commerce
component_updater
content_capture
content_settings
browser
core
browser
content_settings_default_provider.cccontent_settings_policy_provider.cccontent_settings_uma_util.cccontent_settings_utils.cchost_content_settings_map.ccprivate_network_settings.cc
common
renderer
crash
content
browser
core
cronet
native
desks_storage
device_event_log
device_signals
discardable_memory
dom_distiller
domain_reliability
download
content
internal
database
internal
background_service
controller_impl.ccentry_utils.ccin_memory_download_driver.cc
ios
logger_impl.ccmodel_stats.ccproto_conversions.ccscheduler
stats.cccommon
public
background_service
common
drive
embedder_support
enterprise
browser
controller
reporting
client_certificates
data_controls
error_page
exo
drag_drop_operation.ccextended_drag_source.cckeyboard.ccpointer.ccseat.ccshell_surface.ccsurface.cc
test
touch.ccwayland
favicon
favicon_base
feature_engagement
feed
core
find_in_page
flags_ui
gcm_driver
crypto
fake_gcm_profile_service.ccgcm_account_tracker.ccgcm_client_impl.ccgcm_desktop_utils.ccgcm_driver.ccgcm_driver_android.ccgcm_stats_recorder_impl.ccinstance_id
global_media_controls
public
guest_view
browser
headless
policy
heap_profiling
in_process
multi_process
history
content
browser
core
history_clusters
core
image_fetcher
invalidation
javascript_dialogs
keep_alive_registry
keyed_service
leveldb_proto
internal
public
live_caption
local_state
lookalikes
media_message_center
media_router
browser
common
memory_pressure
metrics
call_stacks
content
debug
delegating_provider.ccdemographics
field_trials_provider.ccfile_metrics_provider.ccmachine_id_provider_win.ccmetrics_log.ccmetrics_provider.ccmetrics_service_observer.ccnet
persistent_system_profile.ccstability_metrics_helper.ccstructured
unsent_log_store.ccversion_utils.ccminidump_uploader
mirroring
nacl
browser
loader
renderer
named_mojo_ipc_server
navigation_interception
net_log
network_time
no_state_prefetch
browser
ntp_tiles
offline_pages
content
background_loader
core
background
downloads
model
request_header
task
omnibox
browser
actions
autocomplete_controller.ccautocomplete_match.ccautocomplete_match_type.ccautocomplete_provider.ccautocomplete_result.ccautocomplete_result_android.ccautocomplete_scoring_model_executor.ccfavicon_cache.cchistory_fuzzy_provider.cchistory_fuzzy_provider_unittest.cclocation_bar_model_util.ccomnibox_edit_model.ccomnibox_popup_selection.ccomnibox_view.ccsearch_provider.cczero_suggest_provider.ccopen_from_clipboard
openscreen_platform
optimization_guide
content
browser
core
hint_cache.cchints_fetcher.cchints_manager.cchints_processing_util.cc
model_execution
model_execution_features.ccmodel_execution_manager_unittest.ccon_device_model_execution_proto_value_utils.ccoptimization_guide_model_execution_error.cc
model_info.ccmodel_quality
model_util.ccmodel_validator.ccoptimization_guide_util.ccstore_update_data.cctools
os_crypt
page_content_annotations
core
page_image_service
page_info
page_load_metrics
browser
metrics_web_contents_observer.cc
observers
page_load_metrics_forward_observer.ccpage_load_metrics_test_waiter.ccpage_load_tracker.ccrenderer
paint_preview
browser
paint_preview_base_service_unittest.ccpaint_preview_client.ccpaint_preview_client_unittest.ccpaint_preview_file_mixin.cc
common
player
renderer
password_manager
content
core
browser
browser_save_password_progress_logger.cccredential_manager_pending_prevent_silent_access_task.ccform_fetcher_impl.cc
generation
import
password_autofill_manager.ccpassword_form.ccpassword_form_metrics_recorder.ccpassword_generation_frame_helper_unittest.ccpassword_manager_metrics_recorder.ccpassword_manager_metrics_util.ccpassword_save_manager_impl.ccpassword_store
password_model_type_controller_delegate_android.ccpassword_store_backend_metrics_recorder.ccpassword_store_built_in_backend.cc
sharing
store_metrics_reporter.ccsync
votes_uploader.ccservices
csv_password
public
payments
content
android
android_payment_app.ccpayment_app.ccpayment_method_manifest_table.ccpayment_request.ccpayment_request_converter.ccpayment_request_spec.ccsecure_payment_confirmation_app.ccsecure_payment_confirmation_controller.ccsecure_payment_confirmation_no_creds.ccservice_worker_payment_app.ccssl_validity_checker.ccweb_app_manifest_section_table.cccore
pdf
browser
performance_manager
decorators
execution_context
graph
metrics
performance_manager_feature_observer_client.ccperformance_manager_impl.ccservice_worker_context_adapter.ccv8_memory
permissions
android
bluetooth_chooser_controller.ccchooser_controller.cccontexts
geolocation_permission_context_android.ccpayment_handler_permission_context.ccwake_lock_permission_context.cc
pepc_initiated_permission_request_unittest.ccpermission_hats_trigger_helper.ccpermission_request.ccpermission_request_manager.ccpermission_uma_util.ccpermission_util.ccprediction_service
prediction_common.ccprediction_model_executor.ccprediction_model_handler_provider.ccprediction_service.cc
request_type.cctest
plugins
renderer
plus_addresses
policy
core
browser
common
android
cloud
cloud_policy_client.cccloud_policy_client_registration_helper.cccloud_policy_refresh_scheduler.cccloud_policy_util.cccloud_policy_validator.ccdevice_management_service.ccdmserver_job_configurations.ccrealtime_reporting_job_configuration.ccresource_cache.ccuser_cloud_policy_store.cc
device_local_account_type.ccmock_configuration_policy_provider.ccpolicy_bundle.ccpolicy_loader_lacros.ccpolicy_loader_win_unittest.ccpolicy_map.ccpolicy_statistics_collector.ccpolicy_utils.ccremote_commands
schema.ccschema_registry.cctest_support
power_bookmarks
prefs
printing
privacy_sandbox
proxy_config
query_parser
query_tiles
internal
reading_list
remote_cocoa
renderer_context_menu
reporting
client
rlz
safe_browsing
android
content
browser
base_blocking_page.ccbase_ui_manager.ccbrowser_url_loader_throttle.ccclient_report_util.ccsafe_browsing_network_context.cc
triggers
ui_manager.ccui_manager_unittest.ccweb_ui
renderer
core
browser
db
database_manager.ccv4_database.ccv4_local_database_manager.ccv4_rice.ccv4_store.ccv4_update_protocol_manager.cc
hashprefix_realtime
password_protection
ping_manager.ccrealtime
safe_browsing_metrics_collector.ccsafe_browsing_url_checker_impl_unittest.ccverdict_cache_manager.cccommon
safe_search_api
saved_tab_groups
search_engines
search_provider_logos
security_interstitials
content
captive_portal_blocking_page.cchttps_only_mode_blocking_page.ccinsecure_form_blocking_page.cc
renderer
security_interstitial_controller_client.ccssl_error_handler.ccstateful_ssl_host_state_delegate.cccore
security_state
segmentation_platform
internal
database
dummy_ukm_data_manager.ccexecution
optimization_guide
processing
metadata
migration
post_processor
selection
signals
stats.ccservices
app_service
public
font
heap_profiling
paint_preview_compositor
storage
dom_storage
indexed_db
public
cpp
filesystem
service_worker
sessions
core
ios
shared_highlighting
core
signin
core
browser
internal
identity_manager
account_capabilities_fetcher_unittest.ccaccount_tracker_service.ccaccounts_mutator_impl.ccmutable_profile_oauth2_token_service_delegate.ccoauth_multilogin_token_fetcher.ccprofile_oauth2_token_service_builder.ccprofile_oauth2_token_service_delegate.ccprofile_oauth2_token_service_delegate_chromeos.ccprofile_oauth2_token_service_delegate_ios.cc
ios
public
site_engagement
site_isolation
speech
spellcheck
browser
common
renderer
ssl_errors
startup_metric_utils
browser
storage_monitor
subresource_filter
content
browser
shared
core
supervised_user
core
sync
base
engine
commit.cccommit_processor.cc
cycle
get_updates_processor.ccloopback_server
model_type_worker.ccnet
nigori
shutdown_reason.ccsync_manager_impl.ccsync_protocol_error.ccsync_scheduler_impl.ccsync_string_conversions.ccsyncer.ccsyncer_proto_util.ccinvalidations
model
nigori
protocol
service
data_type_manager_impl.ccdata_type_status_table.ccmodel_type_controller.ccnon_ui_syncable_service_based_model_type_controller.ccpassphrase_type_metrics_provider.ccsync_auth_manager.ccsync_internals_util.ccsync_prefs.ccsync_service.ccsync_service_crypto.ccsync_service_impl.ccsync_service_utils.ccsync_session_durations_metrics_recorder.cc
test
sync_bookmarks
sync_device_info
sync_preferences
sync_sessions
sync_user_events
system_media_controls
tab_groups
translate
content
core
browser
translate_internals
trusted_vault
ui_devtools
update_client
url_formatter
tools
url_matcher
url_pattern_index
url_rewrite
common
user_education
common
feature_promo_controller.ccfeature_promo_lifecycle.ccfeature_promo_lifecycle_unittest.cchelp_bubble.cc
views
webui
user_manager
value_store
variations
visitedlink
viz
common
host
service
compositor_frame_fuzzer
display
dc_layer_overlay.ccdirect_renderer.ccdisplay_resource_provider_skia_unittest.ccdisplay_scheduler.ccexternal_use_client.ccnull_renderer.ccoutput_surface.ccoverlay_processor_ozone.ccoverlay_processor_using_strategy.ccrenderer_pixeltest.ccskia_renderer.ccsoftware_renderer.ccsurface_aggregator_unittest.cc
display_embedder
output_presenter_fuchsia.ccoutput_surface_provider_impl.ccoutput_surface_unified.ccskia_output_device.ccskia_output_device_buffer_queue_unittest.ccskia_output_device_vulkan.ccskia_output_surface_impl_on_gpu.cc
frame_sinks
compositor_frame_sink_support.ccexternal_begin_frame_source_ios.mmroot_compositor_frame_sink_impl.cc
video_capture
gl
performance_hint
transitions
test
web_package
webapps
browser
webauthn
webcrypto
webrtc
webxr
android
wifi
@ -203,7 +203,7 @@ PersistedWindowShowState ShowStateToPersistedShowState(
|
||||
case ui::SHOW_STATE_END:
|
||||
break;
|
||||
}
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return PERSISTED_SHOW_STATE_NORMAL;
|
||||
}
|
||||
|
||||
@ -222,7 +222,7 @@ ui::WindowShowState PersistedShowStateToShowState(int state) {
|
||||
case PERSISTED_SHOW_STATE_DOCKED_DEPRECATED:
|
||||
return ui::SHOW_STATE_NORMAL;
|
||||
}
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return ui::SHOW_STATE_NORMAL;
|
||||
}
|
||||
|
||||
|
@ -883,7 +883,7 @@ bool TabRestoreServiceHelper::ValidateEntry(const Entry& entry) {
|
||||
case tab_restore::Type::GROUP:
|
||||
return ValidateGroup(static_cast<const Group&>(entry));
|
||||
}
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
|
||||
@ -1064,7 +1064,7 @@ bool TabRestoreServiceHelper::FilterEntry(const Entry& entry) {
|
||||
case tab_restore::Type::GROUP:
|
||||
return IsGroupInteresting(static_cast<const Group&>(entry));
|
||||
}
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return false;
|
||||
}
|
||||
|
||||
|
@ -206,7 +206,7 @@ int SerializeWindowShowState(ui::WindowShowState show_state) {
|
||||
return kSerializedShowStateFullscreen;
|
||||
case ui::SHOW_STATE_END:
|
||||
// This should never happen.
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
return kSerializedShowStateInvalid;
|
||||
}
|
||||
@ -376,7 +376,7 @@ std::unique_ptr<sessions::tab_restore::Window> CreateWindowEntryFromCommand(
|
||||
} else {
|
||||
// This should never be called with anything other than a known window
|
||||
// command ID.
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
}
|
||||
|
||||
// Create the Window entry.
|
||||
@ -1183,7 +1183,7 @@ void TabRestoreServiceImpl::PersistenceDelegate::CreateEntriesFromCommands(
|
||||
DCHECK_EQ(current_group.has_value(), false);
|
||||
if (!current_window->first) {
|
||||
// We should have created a window already.
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
current_window->first->tabs.push_back(
|
||||
@ -1195,7 +1195,7 @@ void TabRestoreServiceImpl::PersistenceDelegate::CreateEntriesFromCommands(
|
||||
} else if (current_group.has_value()) {
|
||||
if (!current_group->first) {
|
||||
// We should have created a group already.
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
current_group->first->tabs.push_back(
|
||||
@ -1278,7 +1278,7 @@ void TabRestoreServiceImpl::PersistenceDelegate::CreateEntriesFromCommands(
|
||||
case kCommandSetWindowAppName: {
|
||||
if (!current_window->first) {
|
||||
// We should have created a window already.
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
|
||||
@ -1347,7 +1347,7 @@ void TabRestoreServiceImpl::PersistenceDelegate::CreateEntriesFromCommands(
|
||||
case kCommandSetWindowUserTitle: {
|
||||
if (!current_window->first) {
|
||||
// We should have created a window already.
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
return;
|
||||
}
|
||||
|
||||
|
@ -52,7 +52,7 @@ void IOSSerializedNavigationDriver::Sanitize(
|
||||
referrer.url = GURL();
|
||||
} else {
|
||||
if (referrer.policy < 0 || referrer.policy > web::ReferrerPolicyLast) {
|
||||
NOTREACHED();
|
||||
NOTREACHED_IN_MIGRATION();
|
||||
referrer.policy = web::ReferrerPolicyNever;
|
||||
}
|
||||
referrer.url = GURL(
|
||||
|
Reference in New Issue
Block a user