0

Fix CheckAssertAshOnlyCode presubmit

Follow up for https://crrev.com/c/3325066 that adds a test to check
deleted files are ignored and sets include_deletes to true in
the mock AffectedFiles function to match the real function.

Bug: 1278154
Change-Id: I713f462b4741f8c9d5d13e4ed576788e0de57b95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3325628
Commit-Queue: Giovanni Ortuno Urquidi <ortuno@chromium.org>
Auto-Submit: Giovanni Ortuno Urquidi <ortuno@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/main@{#950362}
This commit is contained in:
Giovanni Ortuño Urquidi
2021-12-10 00:53:21 +00:00
committed by Chromium LUCI CQ
parent 51fda090ed
commit ab84da6d01
2 changed files with 10 additions and 2 deletions

@ -4006,6 +4006,15 @@ class AssertAshOnlyCodeTest(unittest.TestCase):
errors = PRESUBMIT.CheckAssertAshOnlyCode(input_api, MockOutputApi())
self.assertEqual(0, len(errors))
def testDeletedFile(self):
input_api = MockInputApi()
input_api.files = [
MockFile('ash/BUILD.gn', []),
MockFile('ash/foo/BUILD.gn', [], action='D'),
]
errors = PRESUBMIT.CheckAssertAshOnlyCode(input_api, MockOutputApi())
self.assertEqual(1, len(errors))
def testDoesNotErrorWithAssertion(self):
input_api = MockInputApi()
input_api.files = [

@ -81,7 +81,7 @@ class MockInputApi(object):
def CreateMockFileInPath(self, f_list):
self.os_path.exists = lambda x: x in f_list
def AffectedFiles(self, file_filter=None, include_deletes=False):
def AffectedFiles(self, file_filter=None, include_deletes=True):
for file in self.files:
if file_filter and not file_filter(file):
continue
@ -265,4 +265,3 @@ class MockChange(object):
def GitFootersFromDescription(self):
return self.footers