[gn check] Enable unit_tests

This entails a wide variety of minor fixes. The only subtle one is the
change in //components/location/android/BUILD.gn: unit_tests includes a
header for an enum that is correctly listed only in a java_cpp_enum
target. If depending on that target "gn check" complains that a variety
of Java-specific generated targets are needed and not found. Hence, we
make that header available via a test_support target.

One complexity is that the unit_tests target is visible on Chromecast,
even though it is not used or built there. Fixing that is nontrivial
and outside of the scope of this CL (see crbug.com/1215474). However, it
results in "gn check" failing on Chromecast in ways that are not
feasible to resolve via adding dependencies (e.g., the failures are due
to dependencies that don't exist in the Chromecast build). This CL
removes the offending files from the sources of unit_tests on Chromecast
pending the long-term solution of fixing crbug.com/1215474.

This CL is a reland: the original CL inadvertently made
//chrome/browser/ui/colors/BUILD.gn reachable on Android, which cause
a compile failure on main waterfall-only Android bots that build all
reachable targets. Specifically, //chrome/browser/ui/colors:dump_colors
is not buildable on Android. The diff between PS1 and PS2 contains the
fix.

Bug: 1158929
Change-Id: I82eac5e11615b836457e3d955e2475e230a6ef1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2949093
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Colin Blundell <blundell@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#890822}

.gn

@@ -63,8 +63,6 @@ default_args = {
 # their includes checked for proper dependencies when you run either
 # "gn check" or "gn gen --check".
 no_check_targets = [
-  "//chrome/test:unit_tests",
-  "//chrome/test:unit_tests__library",
   "//extensions/browser:*",  # 20 errors
   "//extensions:*",  # 75 errors
   "//headless:*",  # 167 errors

ash/BUILD.gn

@@ -26,6 +26,7 @@ component("ash") {
     ":*",
     "//ash/app_list:*",
     "//chrome/test:browser_tests",
+    "//chrome/test:unit_tests",
     "//components/exo:*",
     "//components/exo/wayland:*",
   ]
@@ -2651,6 +2652,7 @@ static_library("test_support") {
     "//chrome/test:test_support",
     "//chrome/test:test_support_ui",
     "//chrome/test:test_support_unit",
+    "//chrome/test:unit_tests",
     "//components/exo:*",
     "//components/exo/wayland:*",
     "//ash/public/cpp/external_arc:*",

chrome/browser/extensions/activity_log/activity_log_unittest.cc

@@ -19,7 +19,6 @@
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/test_extension_system.h"
 #include "chrome/browser/prefetch/no_state_prefetch/no_state_prefetch_manager_factory.h"
-#include "chrome/browser/prefetch/no_state_prefetch/prerender_test_utils.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"

chrome/browser/importer/profile_writer_unittest.cc

@@ -16,7 +16,6 @@
 #include "base/test/bind.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "chrome/browser/history/history_service_factory.h"
-#include "chrome/browser/importer/importer_unittest_utils.h"
 #include "chrome/browser/password_manager/password_manager_test_util.h"
 #include "chrome/browser/search_engines/template_url_service_factory.h"
 #include "chrome/common/importer/imported_bookmark_entry.h"

chrome/browser/platform_util_linux.cc

@@ -13,7 +13,11 @@
 #include "base/threading/scoped_blocking_call.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/platform_util_internal.h"
-#include "components/dbus/thread_linux/dbus_thread_linux.h"
+// This file gets pulled in in Chromecast builds, which causes "gn check" to
+// complain as Chromecast doesn't use (or depend on) //components/dbus.
+// TODO(crbug.com/1215474): Eliminate //chrome being visible in the GN structure
+// on Chromecast and remove the nogncheck below.
+#include "components/dbus/thread_linux/dbus_thread_linux.h"  // nogncheck
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"

chrome/browser/predictors/autocomplete_action_predictor_unittest.cc

@@ -21,7 +21,6 @@
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "chrome/browser/history/history_service_factory.h"
-#include "chrome/browser/prefetch/no_state_prefetch/prerender_test_utils.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/history/core/browser/history_service.h"

chrome/browser/prefetch/no_state_prefetch/prerender_unittest.cc

@@ -27,8 +27,8 @@
 #include "chrome/browser/predictors/loading_predictor.h"
 #include "chrome/browser/predictors/loading_predictor_factory.h"
 #include "chrome/browser/predictors/loading_test_util.h"
+#include "chrome/browser/prefetch/no_state_prefetch/chrome_no_state_prefetch_contents_delegate.h"
 #include "chrome/browser/prefetch/no_state_prefetch/chrome_no_state_prefetch_manager_delegate.h"
-#include "chrome/browser/prefetch/no_state_prefetch/prerender_test_utils.h"
 #include "chrome/common/chrome_features.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"

chrome/browser/resource_coordinator/tab_load_tracker_unittest.cc

@@ -10,7 +10,6 @@
 #include "base/process/kill.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/prefetch/no_state_prefetch/no_state_prefetch_manager_factory.h"
-#include "chrome/browser/prefetch/no_state_prefetch/prerender_test_utils.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/no_state_prefetch/browser/no_state_prefetch_handle.h"

chrome/browser/ui/views/apps/chrome_native_app_window_views.cc

@@ -7,7 +7,6 @@
 #include <stddef.h>
 #include <utility>
 
-#include "apps/ui/views/app_window_frame_view.h"
 #include "base/cxx17_backports.h"
 #include "base/no_destructor.h"
 #include "build/build_config.h"

chrome/browser/ui/views/user_education/feature_promo_bubble_view_unittest.cc

@@ -14,7 +14,6 @@
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "chrome/browser/ui/views/frame/test_with_browser_view.h"
 #include "chrome/browser/ui/views/user_education/feature_promo_bubble_params.h"
-#include "chrome/test/chromedriver/chrome/ui_events.h"
 #include "chrome/test/data/grit/chrome_test_resources.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "ui/events/base_event_utils.h"

chrome/test/BUILD.gn

@@ -4904,36 +4904,112 @@ test("unit_tests") {
     "//chrome:child_dependencies",
     "//chrome:resources",
     "//chrome:strings",
+    "//chrome/app:command_ids",
+    "//chrome/app/theme:chrome_unscaled_resources_grit",
+    "//chrome/app/vector_icons",
+    "//chrome/browser:active_use_util",
+    "//chrome/browser:buildflags",
+    "//chrome/browser:permissions_proto",
+    "//chrome/browser:theme_properties",
+    "//chrome/browser/browsing_data:constants",
+    "//chrome/browser/devtools",
+    "//chrome/browser/media/router",
+    "//chrome/browser/media/router:media_router_feature",
     "//chrome/browser/media/router:unittests",
+    "//chrome/browser/net:probe_message_proto",
     "//chrome/browser/notifications:unit_tests",
     "//chrome/browser/payments:unittests",
     "//chrome/browser/persisted_state_db:persisted_state_db",
+    "//chrome/browser/persisted_state_db:persisted_state_db_content_proto",
     "//chrome/browser/privacy_budget:unit_tests",
+    "//chrome/browser/profile_resetter:profile_reset_report_proto",
+    "//chrome/browser/profiling_host",
+    "//chrome/browser/push_messaging:budget_proto",
+    "//chrome/browser/safe_browsing:advanced_protection",
+    "//chrome/browser/safe_browsing:metrics_collector",
+    "//chrome/browser/safe_browsing:verdict_cache_manager_factory",
+    "//chrome/browser/sharing/proto",
+    "//chrome/browser/storage_access_api:permissions",
+    "//chrome/browser/sync_file_system/drive_backend:sync_file_system_drive_proto",
     "//chrome/browser/ui:test_support",
+    "//chrome/browser/ui/commander:fuzzy_finder",
+    "//chrome/browser/ui/webui/downloads:mojo_bindings",
+    "//chrome/browser/ui/webui/new_tab_page:mojo_bindings",
     "//chrome/browser/updates/announcement_notification:unit_tests",
     "//chrome/browser/video_tutorials:unit_tests",
     "//chrome/browser/web_share_target:unit_tests",
     "//chrome/common:test_support",
+    "//chrome/common:version_header",
+    "//chrome/common/privacy_budget:test_support",
     "//chrome/common/privacy_budget:unit_tests",
     "//chrome/common/profiler:unit_tests",
+    "//chrome/common/search:generate_chrome_colors_info",
+    "//chrome/common/search:generate_colors_info",
+    "//chrome/common/themes:autogenerated_theme_util",
     "//chrome/services/file_util:unit_tests",
+    "//chrome/services/qrcode_generator/public/cpp",
+    "//chrome/test/data:chrome_test_resources_grit",
     "//components/account_id",
+    "//components/assist_ranker/proto",
     "//components/autofill/content/renderer:test_support",
+    "//components/background_sync",
+    "//components/blocked_content",
+    "//components/blocklist/opt_out_blocklist",
+    "//components/bookmarks/browser",
+    "//components/bookmarks/common",
+    "//components/bookmarks/managed",
+    "//components/browser_sync",
+    "//components/browsing_data/content",
     "//components/browsing_data/content:test_support",
+    "//components/browsing_data/core",
+    "//components/captive_portal/content",
     "//components/captive_portal/core:buildflags",
     "//components/component_updater:test_support",
+    "//components/content_settings/browser",
     "//components/content_settings/browser:test_support",
+    "//components/content_settings/browser/ui",
     "//components/content_settings/core/test:test_support",
+    "//components/country_codes",
     "//components/data_reduction_proxy/core/browser:test_support",
     "//components/data_use_measurement/core",
     "//components/download/public/background_service/test:test_support",
+    "//components/drive",
+    "//components/drive:test_support",
+    "//components/embedder_support",
+    "//components/encrypted_messages",
+    "//components/encrypted_messages:encrypted_message_proto",
+    "//components/enterprise/common/proto:connectors_proto",
+    "//components/enterprise/common/proto:device_trust_report_event_proto",
+    "//components/enterprise/common/proto:extensions_workflow_events_proto",
     "//components/favicon/core/test:test_support",
+    "//components/feature_engagement/public",
+    "//components/feed:buildflags",
+    "//components/feed/core/v2:feed_core_stubs",
+    "//components/feed/core/v2:feed_core_v2",
+    "//components/feedback",
+    "//components/flags_ui",
     "//components/flags_ui:test_support",
+    "//components/history/content/browser",
+    "//components/history/core/common",
+    "//components/history_clusters/core",
     "//components/history_clusters/core:test_support",
+    "//components/image_fetcher/core",
+    "//components/image_fetcher/core:test_support",
+    "//components/infobars/content",
+    "//components/invalidation/impl",
+    "//components/invalidation/impl:test_support",
+    "//components/language/core/browser",
+    "//components/leveldb_proto:test_support",
+    "//components/live_caption:constants",
+    "//components/lookalikes/core:features",
     "//components/mirroring:mirroring_tests",
     "//components/nacl/common:buildflags",
+    "//components/no_state_prefetch/browser",
+    "//components/no_state_prefetch/common",
     "//components/offline_items_collection/core/test_support",
     "//components/offline_pages/task:test_support",
+    "//components/omnibox/browser:vector_icons",
+    "//components/onc",
     "//components/optimization_guide/content/browser",
     "//components/optimization_guide/content/browser:test_support",
     "//components/optimization_guide/content/renderer",
@@ -4943,39 +5019,98 @@ test("unit_tests") {
     "//components/page_info",
     "//components/page_load_metrics/browser",
     "//components/page_load_metrics/browser:test_support",
+    "//components/page_load_metrics/common",
     "//components/page_load_metrics/common:test_support",
+    "//components/paint_preview/common/mojom",
+    "//components/password_manager/content/browser",
+    "//components/payments/content",
+    "//components/performance_manager",
+    "//components/performance_manager/public/mojom",
+    "//components/performance_manager/test_support:test_support_common",
+    "//components/policy/core/browser:test_support",
+    "//components/privacy_sandbox:privacy_sandbox_prefs",
+    "//components/proxy_config",
+    "//components/query_parser",
     "//components/query_tiles:unit_tests",
+    "//components/reading_list/core",
+    "//components/reading_list/features:flags",
+    "//components/renderer_context_menu",
+    "//components/reporting/client:report_queue",
+    "//components/reporting/client:report_queue_configuration",
+    "//components/reporting/client:report_queue_provider",
     "//components/reporting/client:test_support",
     "//components/reporting/encryption:decryption",
     "//components/reporting/encryption:encryption",
     "//components/reporting/encryption:encryption_module",
     "//components/reporting/encryption:encryption_module_interface",
+    "//components/reporting/encryption:primitives",
     "//components/reporting/encryption:test_support",
     "//components/reporting/encryption:testing_primitives",
+    "//components/reporting/encryption:verification",
     "//components/reporting/storage:storage_uploader_interface",
     "//components/reporting/storage:test_support",
+    "//components/reporting/util:shared_vector",
+    "//components/reporting/util:status_macros",
+    "//components/reporting/util:task_runner_context",
     "//components/reporting/util:test_callbacks_support",
+    "//components/reputation/core",
     "//components/resources",
     "//components/safe_browsing:buildflags",
+    "//components/safe_browsing/content/browser",
+    "//components/safe_browsing/content/browser:client_side_detection",
+    "//components/safe_browsing/content/browser:client_side_model_loader",
+    "//components/safe_browsing/content/common:interfaces",
+    "//components/safe_browsing/content/common:interfaces_shared_cpp_sources",
+    "//components/safe_browsing/content/password_protection",
     "//components/safe_browsing/content/password_protection:mock_password_protection",
+    "//components/safe_browsing/content/web_ui",
+    "//components/safe_browsing/core:client_model_proto",
     "//components/safe_browsing/core:features",
+    "//components/safe_browsing/core:verdict_cache_manager",
+    "//components/safe_browsing/core/browser:referrer_chain_provider",
+    "//components/safe_browsing/core/browser/sync",
+    "//components/safe_browsing/core/common",
     "//components/safe_browsing/core/db",
     "//components/safe_browsing/core/db:test_database_manager",
     "//components/safe_search_api:test_support",
     "//components/schema_org/common:improved_mojom",
+    "//components/search",
+    "//components/security_interstitials/content:proto",
+    "//components/security_interstitials/content:security_interstitial_page",
+    "//components/security_interstitials/core:unsafe_resource",
+    "//components/send_tab_to_self",
+    "//components/services/app_service/public/cpp:intents",
     "//components/services/app_service/public/cpp:protocol_handling",
+    "//components/services/paint_preview_compositor/public/mojom",
     "//components/services/patch/content",
     "//components/services/unzip/content",
+    "//components/site_engagement/content",
+    "//components/site_engagement/core",
+    "//components/site_isolation",
     "//components/spellcheck:buildflags",
+    "//components/spellcheck/browser",
+    "//components/spellcheck/common",
+    "//components/spellcheck/common:spellcheck_result",
+    "//components/spellcheck/renderer",
+    "//components/sqlite_proto",
     "//components/strings",
+    "//components/subresource_filter/core/browser",
     "//components/subresource_filter/core/browser:test_support",
     "//components/subresource_redirect:test_support",
+    "//components/subresource_redirect/proto",
     "//components/sync:test_support",
+    "//components/sync_bookmarks",
     "//components/sync_device_info:test_support",
     "//components/sync_sessions:test_support",
     "//components/sync_user_events:test_support",
+    "//components/tab_count_metrics",
+    "//components/tab_groups",
     "//components/translate/core/browser:test_support",
     "//components/ukm/content",
+    "//components/unified_consent",
+    "//components/url_formatter/spoof_checks/common_words:common",
+    "//components/url_formatter/spoof_checks/common_words:common_words_dafsa",
+    "//components/user_manager",
     "//components/variations:test_support",
     "//components/version_info:generate_version_info",
     "//content/app/resources",
@@ -4987,8 +5122,9 @@ test("unit_tests") {
     "//device/bluetooth:mocks",
     "//device/fido",
     "//device/fido:test_support",
-    "//extensions/buildflags",
+    "//gin",
     "//google_apis",
+    "//google_apis/gcm",
     "//gpu:test_support",
     "//media:test_support",
     "//mojo/public/cpp/bindings",
@@ -4996,36 +5132,67 @@ test("unit_tests") {
     "//net:test_support",
     "//ppapi/buildflags",
     "//services/data_decoder/public/cpp:test_support",
+    "//services/device/public/cpp:device_features",
     "//services/device/public/cpp:test_support",
     "//services/network:test_support",
     "//services/network/public/cpp",
     "//services/network/public/mojom",
+    "//services/preferences/public/cpp/tracked",
+    "//services/preferences/public/cpp/tracked:test_support",
+    "//services/preferences/public/mojom",
+    "//services/resource_coordinator/public/cpp/memory_instrumentation:browser",
+    "//services/service_manager/public/cpp/test:test_support",
     "//skia",
+    "//storage/browser:test_support",
     "//testing/gmock",
     "//testing/gtest",
     "//testing/perf:unit_tests",
+    "//third_party/blink/public/common/privacy_budget:test_support",
     "//third_party/icu",
     "//third_party/leveldatabase",
     "//third_party/libaddressinput",
     "//third_party/libphonenumber",
     "//third_party/metrics_proto",
+    "//third_party/microsoft_webauthn",
     "//third_party/re2",
     "//third_party/webrtc_overrides:webrtc_component",
+    "//third_party/widevine/cdm:headers",
+    "//third_party/zlib/google:zip",
     "//ui/base:test_support",
+    "//ui/base/clipboard:clipboard_test_support",
     "//ui/display:test_support",
+    "//ui/events:gesture_detection",
+    "//ui/events:test_support",
     "//ui/gfx:test_support",
     "//ui/gl",
     "//ui/native_theme:test_support",
     "//ui/resources",
+    "//ui/shell_dialogs",
     "//ui/web_dialogs:web_dialogs_unittests",
+    "//ui/webui",
+    "//ui/webui/resources/cr_components/customize_themes:mojom",
     "//v8",
   ]
 
+  if (enable_paint_preview) {
+    deps += [ "//chrome/browser/paint_preview:services" ]
+  }
+
   if (is_mac) {
     data_deps += [ "//chrome:chrome_framework" ]
     deps += [
+      "//chrome/app_shim",
+      "//chrome/browser/apps/app_shim",
+      "//chrome/browser/ui/cocoa/notifications:common",
+      "//chrome/common/notifications",
+      "//chrome/common/safe_browsing:archive_analyzer_results",
+      "//chrome/common/safe_browsing:disk_image_type_sniffer_mac",
       "//chrome/services/mac_notifications:unit_tests",
       "//chrome/services/mac_notifications/public/cpp",
+      "//chrome/services/mac_notifications/public/mojom",
+      "//chrome/utility/safe_browsing/mac",
+      "//chrome/utility/safe_browsing/mac:dmg_common",
+      "//ui/events/devices:test_support",
     ]
   }
 
@@ -5034,8 +5201,17 @@ test("unit_tests") {
     sources += [ "../browser/ui/startup/credential_provider_signin_info_fetcher_win_unittest.cc" ]
     deps += [
       "//chrome:packed_resources_integrity",
+      "//chrome/browser:chrome_process_finder",
+      "//chrome/browser/safe_browsing/chrome_cleaner",
+      "//chrome/browser/safe_browsing/chrome_cleaner:public",
       "//chrome/browser/win/conflicts:unit_tests",
+      "//chrome/chrome_elf:constants",
+      "//chrome/common/notifications",
+      "//chrome/services/util_win:lib",
       "//chrome/test:credential_provider_test_utils",
+      "//components/chrome_cleaner/public/constants",
+      "//components/chrome_cleaner/public/proto",
+      "//ui/events/devices:test_support",
     ]
   }
 
@@ -5145,27 +5321,54 @@ test("unit_tests") {
       "//chrome:chrome_android_core",
       "//chrome/android:app_hooks_java",
       "//chrome/android:chrome_java",
+      "//chrome/android/modules/dev_ui/provider:native",
+      "//chrome/browser:client_discourse_context_proto",
+      "//chrome/browser:delta_file_proto",
+      "//chrome/browser:explore_sites_proto",
+      "//chrome/browser:profile_token",
+      "//chrome/browser:usage_stats_proto",
+      "//chrome/browser/commerce/merchant_viewer:merchant_viewer_data_manager",
       "//chrome/browser/continuous_search/internal:unit_tests",
+      "//chrome/browser/flags:flags_android",
       "//chrome/browser/locale:delegate_public_impl_java",
       "//chrome/browser/long_screenshots:services",
+      "//chrome/browser/notifications",
       "//chrome/browser/optimization_guide/android:native_j_unittests_jni_headers",
       "//chrome/browser/optimization_guide/android:native_java_unittests",
       "//chrome/browser/password_check/android:unit_tests",
       "//chrome/browser/reading_list/android:unit_tests",
+      "//chrome/browser/share",
+      "//chrome/browser/supervised_user/kids_chrome_management:proto",
       "//chrome/browser/thumbnail:unit_tests",
       "//chrome/browser/updates:unit_tests",
       "//chrome/services/media_gallery_util:unit_tests",
+      "//components/back_forward_cache",
+      "//components/crash/content/browser",
       "//components/download/internal/common:internal_java",
+      "//components/embedder_support/android:browser_context",
       "//components/externalauth/android:google_delegate_public_impl_java",
       "//components/favicon/core/test:test_support",
+      "//components/feed/core/shared_prefs:feed_shared_prefs",
       "//components/feed/core/v2:test_helpers",
+      "//components/feed/mojom:mojo_bindings",
       "//components/gcm_driver/instance_id/android:instance_id_driver_java",
       "//components/gcm_driver/instance_id/android:instance_id_driver_test_support_java",
+      "//components/infobars/android",
       "//components/location/android:test_support",
+      "//components/media_router/browser:test_support",
       "//components/messages/android:test_support",
       "//components/module_installer/android:module_installer_java",
+      "//components/offline_pages/core/request_header",
+      "//components/offline_pages/task",
+      "//components/pref_registry",
+      "//components/services/unzip:in_process",
+      "//components/signin/core/browser",
       "//components/signin/public/android:signin_java_test_support",
+      "//components/ukm:test_support",
+      "//components/webapk:proto",
+      "//components/webapps/browser",
       "//content/public/android:content_java",
+      "//ui/events/devices:test_support",
     ]
     if (use_v8_context_snapshot) {
       deps += [ "//tools/v8_context_snapshot:v8_context_snapshot_assets" ]
@@ -5569,9 +5772,20 @@ test("unit_tests") {
     }
 
     deps += [
+      "//chrome:packed_resources_integrity_hash",
+      "//chrome/browser:cart_db_content_proto",
+      "//chrome/browser/media/router:test_support",
       "//chrome/browser/promo_browser_command:mojo_bindings",
+      "//chrome/browser/resource_coordinator:intervention_policy_database_proto",
+      "//chrome/browser/resource_coordinator:tab_manager_features",
       "//chrome/browser/resource_coordinator:tab_metrics_event_proto",
+      "//chrome/browser/resource_coordinator/tab_ranker",
       "//chrome/browser/resource_coordinator/tab_ranker:tab_features_test_helper",
+      "//chrome/browser/resources:component_extension_resources_grit",
+      "//chrome/browser/resources/new_tab_page_instant:resources_grit",
+      "//chrome/browser/ui/color:color_headers",
+      "//chrome/browser/ui/webui/discards:mojo_bindings",
+      "//chrome/browser/web_applications:web_applications_test_support",
       "//chrome/services/speech:unit_tests",
       "//components/chrome_cleaner/test:test_name_helper",
       "//components/enterprise",
@@ -5589,6 +5803,8 @@ test("unit_tests") {
       "//third_party/libaddressinput",
       "//third_party/zxcvbn-cpp",
       "//ui/base/idle:test_support",
+      "//ui/color:color_headers",
+      "//ui/color:test_support",
       "//ui/native_theme:test_support",
     ]
     if (is_win) {
@@ -5596,8 +5812,68 @@ test("unit_tests") {
     }
     if (is_chromeos_ash) {
       deps += [
+        "//ash/assistant/model",
+        "//ash/assistant/util",
+        "//ash/components/audio",
+        "//ash/content/scanning",
+        "//ash/public/cpp:test_support",
+        "//ash/shortcut_viewer",
+        "//ash/shortcut_viewer/strings:strings_grit",
+        "//chrome/browser/ash/crosapi",
+        "//chrome/browser/ash/crosapi:unit_tests",
+        "//chrome/browser/chromeos:arc_test_support",
+        "//chrome/browser/nearby_sharing:share_target",
+        "//chrome/browser/nearby_sharing/certificates",
+        "//chrome/browser/nearby_sharing/common",
+        "//chrome/browser/nearby_sharing/contacts",
+        "//chrome/browser/nearby_sharing/instantmessaging/proto",
+        "//chrome/browser/nearby_sharing/local_device_data",
+        "//chrome/browser/nearby_sharing/proto:tachyon_proto",
+        "//chrome/browser/supervised_user/kids_chrome_management:proto",
+        "//chrome/browser/ui/webui/nearby_share:mojom",
+        "//chrome/browser/ui/webui/nearby_share/public/mojom",
+        "//chrome/common/performance_manager/mojom",
         "//chrome/services/sharing/public/cpp",
         "//chrome/services/sharing/public/cpp:unit_tests",
+        "//chromeos/components/camera_app_ui",
+        "//chromeos/components/feature_usage:feature_usage",
+        "//chromeos/components/multidevice:test_support",
+        "//chromeos/components/proximity_auth",
+        "//chromeos/components/proximity_auth:test_support",
+        "//chromeos/components/sync_wifi",
+        "//chromeos/cryptohome",
+        "//chromeos/dbus",
+        "//chromeos/dbus:update_engine_proto",
+        "//chromeos/dbus/attestation",
+        "//chromeos/dbus/cicerone",
+        "//chromeos/dbus/concierge",
+        "//chromeos/dbus/debug_daemon",
+        "//chromeos/dbus/hermes",
+        "//chromeos/dbus/power",
+        "//chromeos/dbus/seneschal",
+        "//chromeos/dbus/shill",
+        "//chromeos/disks",
+        "//chromeos/disks:test_support",
+        "//chromeos/login/auth:test_support",
+        "//chromeos/login/login_state:test_support",
+        "//chromeos/login/session",
+        "//chromeos/memory/userspace_swap",
+        "//chromeos/services/assistant/public/cpp",
+        "//chromeos/services/assistant/public/shared",
+        "//chromeos/services/device_sync/public/cpp:test_support",
+        "//chromeos/services/multidevice_setup/public/cpp:test_support",
+        "//chromeos/services/secure_channel/public/cpp/client:test_support",
+        "//chromeos/system",
+        "//chromeos/ui/base",
+        "//components/services/app_service/public/cpp:app_update",
+        "//components/services/app_service/public/cpp:instance_update",
+        "//components/session_manager/core",
+        "//components/webapk:proto",
+        "//third_party/protobuf:protobuf_full",
+        "//ui/base/ime/chromeos",
+        "//ui/chromeos",
+        "//ui/file_manager:resources_grit",
+        "//ui/wm/public",
       ]
     }
   }
@@ -5717,6 +5993,9 @@ test("unit_tests") {
     ]
 
     deps += [
+      "//chromeos/crosapi/mojom",
+      "//chromeos/lacros:test_support",
+      "//chromeos/ui/base",
       "//components/account_manager_core",
       "//components/account_manager_core:test_support",
     ]
@@ -6318,6 +6597,8 @@ test("unit_tests") {
       "//chrome/browser/web_applications:unit_tests",
       "//chrome/browser/web_applications:web_applications_unit_tests",
       "//chrome/browser/web_applications/extensions:unit_tests",
+      "//chrome/common/apps/platform_apps",
+      "//chrome/common/extensions:extension_features_unittest",
       "//chrome/common/extensions/api",
       "//chrome/utility/image_writer:unit_tests",
       "//components/enterprise:test_support",
@@ -6326,8 +6607,11 @@ test("unit_tests") {
       "//extensions:extensions_resources",
       "//extensions/browser:test_support",
       "//extensions/browser:value_store_test_support",
+      "//extensions/browser/updater",
+      "//extensions/buildflags",
       "//extensions/common",
       "//extensions/common:mojom",
+      "//extensions/renderer",
       "//extensions/renderer:unit_test_support",
       "//extensions/strings",
       "//google_apis",
@@ -6455,6 +6739,7 @@ test("unit_tests") {
     # TODO(crbug/1056278): Enable this on Fuchsia
     if (!is_fuchsia) {
       deps += [
+        "//components/safe_browsing/core:file_type_policies",
         "//components/safe_browsing/core:file_type_policies_test_support",
         "//components/safe_browsing/core/common:test_support",
       ]
@@ -6539,6 +6824,8 @@ test("unit_tests") {
     deps += [
       ":test_proto",
       "../common/safe_browsing:mock_binary_feature_extractor",
+      "//chrome/common/safe_browsing:binary_feature_extractor",
+      "//chrome/common/safe_browsing:download_type_util",
       "//chrome/services/file_util/public/cpp:unit_tests",
       "//components/safe_browsing/content/renderer:websocket_sb_handshake_throttle_unittest",
       "//components/safe_browsing/content/triggers:ad_redirect_trigger",
@@ -6602,7 +6889,9 @@ test("unit_tests") {
     ]
 
     deps += [
+      "//chrome/common/printing",
       "//chrome/common/printing:unit_tests",
+      "//components/printing/common:mojo_interfaces",
       "//printing",
       "//printing:test_support",
       "//printing/mojom",
@@ -6824,6 +7113,8 @@ test("unit_tests") {
         "../browser/google/google_update_policy_fetcher_win_util_unittest.cc",
         "../browser/google/google_update_win_unittest.cc",
       ]
+
+      deps += [ "//google_update" ]
     }
   }
   if (!is_android && !is_chromeos_ash) {
@@ -6854,9 +7145,16 @@ test("unit_tests") {
       "../browser/upgrade_detector/upgrade_detector_chromeos_unittest.cc",
     ]
   }
+  if (is_linux) {
+    deps += [ "//components/dbus/thread_linux" ]
+  }
+
   if (toolkit_views) {
     deps += [
       "//chrome:unit_tests_pak",
+      "//chrome/browser/ui/views",
+      "//components/constrained_window",
+      "//components/media_message_center",
       "//components/media_router/browser:test_support",
       "//components/web_modal:test_support",
       "//content/test:test_support",
@@ -6866,6 +7164,10 @@ test("unit_tests") {
       "//ui/web_dialogs:test_support",
     ]
 
+    if (!is_mac) {
+      deps += [ "//apps/ui/views" ]
+    }
+
     data_deps += [ "//chrome:unit_tests_pak" ]
 
     sources += [
@@ -6878,6 +7180,7 @@ test("unit_tests") {
       "../browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc",
       "../browser/ui/views/autofill/autofill_popup_view_native_views_unittest.cc",
       "../browser/ui/views/autofill/autofill_popup_view_utils_unittest.cc",
+      "../browser/ui/views/bookmarks/bookmark_bar_view_test_helper.h",
       "../browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc",
       "../browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc",
       "../browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc",
@@ -7082,6 +7385,27 @@ test("unit_tests") {
     sources +=
         [ "../browser/ui/views/frame/windows_10_caption_button_unittest.cc" ]
   }
+
+  # This target gets pulled in in Chromecast builds, even though it doesn't get
+  # built or used there. The below files cause "gn check" failures in ways that
+  # would be resolvable only by adding "nogncheck" on the includes in question.
+  # Rather than doing that, simply eliminate the files from being visible to
+  # GN.
+  # NOTE: A natural idea would be to set sources to the empty set here, but
+  # that surprisingly turns out to cause its own "gn check" problems as various
+  # utility headers are contained in those sources that other test targets in
+  # //chrome include.
+  # TODO(crbug.com/1215474): Eliminate //chrome being visible in the GN structure
+  # on Chromecast and remove this section entirely.
+  if (is_linux && is_chromecast) {
+    sources -= [
+      "../browser/browsing_data/browsing_data_media_license_helper_unittest.cc",
+      "../browser/extensions/api/safe_browsing_private/safe_browsing_private_event_router_unittest.cc",
+      "../browser/printing/cloud_print/privet_http_unittest.cc",
+      "../browser/ui/tab_contents/chrome_web_contents_view_handle_drop_unittest.cc",
+      "../browser/ui/webui/management/management_ui_handler_unittest.cc",
+    ]
+  }
 }
 
 static_library("test_support_unit") {

chrome/utility/safe_browsing/mac/BUILD.gn

@@ -27,7 +27,12 @@ config("dmg_public_config") {
 }
 
 source_set("dmg_common") {
-  visibility = [ ":*" ]
+  visibility = [
+    ":*",
+
+    # Unit tests directly use some of the utilities in this target.
+    "//chrome/test:unit_tests",
+  ]
 
   sources = [
     "convert_big_endian.h",

components/location/android/BUILD.gn

@@ -54,11 +54,12 @@ source_set("settings") {
 source_set("test_support") {
   testonly = true
   sources = [
+    "location_settings_dialog_context.h",
+    "location_settings_dialog_outcome.h",
     "mock_location_settings.cc",
     "mock_location_settings.h",
   ]
   deps = [
-    ":location_settings_dialog_enums_java",
     ":settings",
     "//base",
   ]

third_party/protobuf/BUILD.gn

@@ -241,6 +241,10 @@ static_library("protobuf_full") {
     # Perfetto uses the full library for testing.
     "//third_party/perfetto/gn:protobuf_full",
 
+    # Some unittests need helpers from this target.
+    # Not included in production code.
+    "//chrome/test:unit_tests",
+
     # Some tests inside ChromeOS need reflection to parse golden files.
     # Not included in production code.
     "//chrome/test:usage_time_limit_unittests",

ui/color/BUILD.gn

@@ -56,6 +56,14 @@ component("color") {
   }
 }
 
+source_set("test_support") {
+  testonly = true
+
+  sources = [ "color_test_ids.h" ]
+
+  deps = [ ":color_headers" ]
+}
+
 test("color_unittests") {
   testonly = true
 
@@ -64,7 +72,6 @@ test("color_unittests") {
     "color_provider_manager_unittest.cc",
     "color_provider_unittest.cc",
     "color_recipe_unittest.cc",
-    "color_test_ids.h",
     "color_transform_unittest.cc",
     "run_all_unittests.cc",
   ]
@@ -72,6 +79,7 @@ test("color_unittests") {
   deps = [
     ":color",
     ":mixers",
+    ":test_support",
     "//base/test:test_support",
     "//testing/gtest",
   ]