0

Remove NOTIFICATION_NAV_ENTRY_COMMITTED

Fixed: 1174760
Change-Id: I46945a63fd503be6c748a1ee6664c721716526b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5219332
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Yiren Wang <yrw@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Commit-Queue: Yiren Wang <yrw@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1249746}
This commit is contained in:
Avi Drissman
2024-01-20 01:32:10 +00:00
committed by Chromium LUCI CQ
parent 37f2d98f27
commit ad78ce69e8
2 changed files with 0 additions and 24 deletions
content
browser
public

@ -4201,13 +4201,6 @@ void NavigationControllerImpl::NotifyNavigationEntryCommitted(
delegate_->NotifyNavigationStateChangedFromController(INVALIDATE_TYPE_ALL);
delegate_->NotifyNavigationEntryCommitted(*details);
// TODO(avi): Remove. http://crbug.com/170921
NotificationDetails notification_details =
Details<LoadCommittedDetails>(details);
NotificationService::current()->Notify(NOTIFICATION_NAV_ENTRY_COMMITTED,
Source<NavigationController>(this),
notification_details);
}
// static

@ -19,20 +19,6 @@
namespace content {
enum NotificationType {
NOTIFICATION_CONTENT_START = 0,
// NavigationController ----------------------------------------------------
// A new non-pending navigation entry has been created. This will
// correspond to one NavigationController entry being created (in the case
// of new navigations) or renavigated to (for back/forward navigations).
//
// The source will be the navigation controller doing the commit. The
// details will be NavigationController::LoadCommittedDetails.
// DEPRECATED: Use WebContentsObserver::NavigationEntryCommitted()
// TODO(https://crbug.com/1174760): Remove.
NOTIFICATION_NAV_ENTRY_COMMITTED = NOTIFICATION_CONTENT_START,
// WebContents ---------------------------------------------------------------
// Indicates a RenderWidgetHost has been hidden or restored. The source is
@ -43,9 +29,6 @@ enum NotificationType {
// Use RenderWidgetHostObserver::RenderWidgetHostVisibilityChanged()
// TODO(https://crbug.com/1174771): Remove.
NOTIFICATION_RENDER_WIDGET_VISIBILITY_CHANGED,
// Custom notifications used by the embedder should start from here.
NOTIFICATION_CONTENT_END,
};
} // namespace content