chromium/src
0
Fork 0
Code Activity

Revert "[//skia] Set skia_use_dawn to true by default"

Browse Source 
This reverts commit 5ce282cc98.

Reason for revert:
LUCI Bisection identified this CL as the culprit of a build failure. See the analysis: https://luci-bisection.appspot.com/analysis/b/8780959485051775361

Sample failed build: https://ci.chromium.org/b/8780959485051775361

If this is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?comment=Analysis%3A+https%3A%2F%2Fluci-bisection.appspot.com%2Fanalysis%2Fb%2F8780959485051775361&components=Tools%3ETest%3EFindit&labels=LUCI-Bisection-Wrong%2CPri-3%2CType-Bug&status=Available&summary=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F4530360

Original change's description:
> [//skia] Set `skia_use_dawn` to true by default
>
> A prerequisite to running with Graphite is that `skia_use_dawn` be set
> to true when building. This CL sets it to true by default in the
> production code so that we can ensure that the code is buildable in
> this state and facilitate straightforward local running with Graphite.
>
> NOTE: This flag affects only Graphite code paths, so this CL will have
> no impact on production code.
>
> Bug: 1423574
> Change-Id: Id164b68ab843930c44afb70b1fc17ead5b167df9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4530360
> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
> Commit-Queue: Colin Blundell <blundell@chromium.org>
> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1144565}
>

Bug: 1423574
Change-Id: I394b00e81aaa76fcc7ea0fd5b8d0d65813251a0e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4533054
Commit-Queue: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Bot-Commit: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Owners-Override: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1144569}
This commit is contained in:
luci-bisection@appspot.gserviceaccount.com
2023-05-16 07:33:09 +00:00
committed by Chromium LUCI CQ
parent e98bb37390
commit adc52471c0
2 changed files with 3 additions and 6 deletions
gpu/command_buffer/service/shared_image
shared_image_format_utils.cc
skia
features.gni

4
gpu/command_buffer/service/shared_image/shared_image_format_utils.cc

@ -283,9 +283,7 @@ skgpu::graphite::TextureInfo GetGraphiteTextureInfo(
} else {
CHECK_EQ(gr_context_type, GrContextType::kGraphiteDawn);
#if BUILDFLAG(SKIA_USE_DAWN)
// TODO(crbug.com/1445450): Add support for multiplanar formats, passing
// |plane_index|.
wgpu::TextureFormat wgpu_format = ToDawnFormat(format);
wgpu::TextureFormat wgpu_format = ToDawnFormat(format, plane_index);
if (wgpu_format != wgpu::TextureFormat::Undefined) {
skgpu::graphite::DawnTextureInfo dawn_texture_info;
dawn_texture_info.fSampleCount = 1;

5
skia/features.gni

@ -6,9 +6,8 @@ import("//build/config/features.gni")
import("//printing/buildflags/buildflags.gni")
declare_args() {
# Enable experimental Skia Graphite Dawn backend. Currently enabled for Mac
# only.
skia_use_dawn = is_mac
# Enable experimental Skia Graphite Dawn backend.
skia_use_dawn = false
# Enable experimental Skia Graphite Metal backend. Intended only for debugging
# on non-official developer builds.