chromium/src
0
Fork 0
Code Activity

[Sheriff] Disable DownloadBrowserTest.OverrideDownloadDirectory

Browse Source 
Bug: 1273105
Change-Id: Ia86d5a412eb53f74e0fc64a1abb1b8c473f89d09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3299350
Owners-Override: Wenyu Fu <wenyufu@chromium.org>
Auto-Submit: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/main@{#944783}
This commit is contained in:
Wenyu Fu
2021-11-24 01:35:49 +00:00
committed by Chromium LUCI CQ
parent b6f58fa9dd
commit adf2338218
1 changed files with 8 additions and 1 deletions

9
weblayer/browser/download_browsertest.cc

@ -11,6 +11,7 @@
#include "base/task/post_task.h"
#include "base/test/bind.h"
#include "base/threading/thread_restrictions.h"
#include "build/build_config.h"
#include "content/public/browser/download_manager.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/slow_download_http_response.h"
@ -230,7 +231,13 @@ IN_PROC_BROWSER_TEST_F(DownloadBrowserTest, Basic) {
download_location().DirName());
}
IN_PROC_BROWSER_TEST_F(DownloadBrowserTest, OverrideDownloadDirectory) {
// Test consistently failing on android: crbug.com/1273105
#if defined(OS_ANDROID)
#define MAYBE_OverrideDownloadDirectory DISABLED_OverrideDownloadDirectory
#else
#define MAYBE_OverrideDownloadDirectory OverrideDownloadDirectory
#endif
IN_PROC_BROWSER_TEST_F(DownloadBrowserTest, MAYBE_OverrideDownloadDirectory) {
base::ScopedAllowBlockingForTesting allow_blocking;
base::ScopedTempDir download_dir;
ASSERT_TRUE(download_dir.CreateUniqueTempDir());