chromium/src
0
Fork 0
Code Activity

snap-groups: Update a11y strings

Browse Source 
This updates the a11y strings with the finalized strings.

Test: manual
Fixed: b/344042376
Change-Id: Ib0dbe3de35d18b4dc5e0d1874604fda3f959a169
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5597812
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Sophie Wen <sophiewen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1310352}
This commit is contained in:
Sophie Wen
2024-06-05 01:23:02 +00:00
committed by Chromium LUCI CQ
parent 72e7ca0176
commit ae64b94fef
10 changed files with 25 additions and 13 deletions

11
ash/ash_strings.grd

@ -6510,11 +6510,14 @@ Here are some things you can try to get started.
<message name="IDS_ASH_SNAP_GROUP_UPDATE_RIGHT_WINDOW" desc="Update the right window in the snap group in horizontal screen orientation.">
Update the right window
</message>
<message name="IDS_ASH_SNAP_GROUP_DIVIDER_A11Y_NAME" translateable="false" desc="Accessible name of the snap group divider">
Split view divider
<message name="IDS_ASH_SNAP_GROUP_DIVIDER_A11Y_NAME" desc="Accessible name of the snap group divider">
Split screen divider
</message>
<message name="IDS_ASH_SNAP_GROUP_DIVIDER_A11Y_DESCRIPTION" translateable="false" desc="Accessible description of the snap group divider">
Use left and right or up and down arrows to resize split screen
<message name="IDS_ASH_SNAP_GROUP_DIVIDER_A11Y_DESCRIPTION_HORIZONTAL" desc="Accessible description of the snap group divider">
Use left and right arrows to resize split screen
</message>
<message name="IDS_ASH_SNAP_GROUP_DIVIDER_A11Y_DESCRIPTION_VERTICAL" desc="Accessible description of the snap group divider">
Use up and down arrows to resize split screen
</message>
<!-- Switch Between TABLET/LAPTOP MODE-->

1
ash/ash_strings_grd/IDS_ASH_SNAP_GROUP_DIVIDER_A11Y_DESCRIPTION_HORIZONTAL.png.sha1 Normal file

@ -0,0 +1 @@
7ae016367165fc6b69e2b032dc9f86a671fe316c

1
ash/ash_strings_grd/IDS_ASH_SNAP_GROUP_DIVIDER_A11Y_DESCRIPTION_VERTICAL.png.sha1 Normal file

@ -0,0 +1 @@
59c8a28043377bb7c911460d4e73575a11e59be1

1
ash/ash_strings_grd/IDS_ASH_SNAP_GROUP_DIVIDER_A11Y_NAME.png.sha1 Normal file

@ -0,0 +1 @@
6b304558f84a0ec3f748a966f807a5472a3947f4

12
ash/wm/splitview/split_view_divider_view.cc

@ -81,9 +81,10 @@ END_METADATA
// SplitViewDividerView:
SplitViewDividerView::SplitViewDividerView(SplitViewDivider* divider)
: divider_(divider),
handler_view_(AddChildView(std::make_unique<DividerHandlerView>(
IsLayoutHorizontal(divider_->divider_widget()->GetNativeWindow())))) {
: divider_(divider) {
const bool horizontal = IsLayoutHorizontal(divider_->GetRootWindow());
handler_view_ =
AddChildView(std::make_unique<DividerHandlerView>(horizontal));
SetEventTargeter(std::make_unique<views::ViewTargeter>(this));
SetPaintToLayer(ui::LAYER_TEXTURED);
@ -97,8 +98,9 @@ SplitViewDividerView::SplitViewDividerView(SplitViewDivider* divider)
set_allow_deactivate_on_esc(true);
SetAccessibleName(
l10n_util::GetStringUTF16(IDS_ASH_SNAP_GROUP_DIVIDER_A11Y_NAME));
GetViewAccessibility().SetDescription(
l10n_util::GetStringUTF16(IDS_ASH_SNAP_GROUP_DIVIDER_A11Y_DESCRIPTION));
GetViewAccessibility().SetDescription(l10n_util::GetStringUTF16(
horizontal ? IDS_ASH_SNAP_GROUP_DIVIDER_A11Y_DESCRIPTION_HORIZONTAL
: IDS_ASH_SNAP_GROUP_DIVIDER_A11Y_DESCRIPTION_VERTICAL));
TooltipTextChanged();
SetAccessibleRole(ax::mojom::Role::kToolbar);

8
chrome/app/generated_resources.grd

@ -15078,16 +15078,16 @@ Please help our engineers fix this problem. Tell us what happened right before y
<message name="IDS_A11Y_ALERT_FASTER_SPLITSCREEN_TOAST" desc="The text for the Faster Splitscreen toast during faster splitscreen setup.">
Choose a window for this side
</message>
<message name="IDS_A11Y_ALERT_SNAP_GROUP_RESIZE_LEFT" translateable="false" desc="An alert for snap group resize.">
<message name="IDS_A11Y_ALERT_SNAP_GROUP_RESIZE_LEFT" desc="An alert for snap group resize.">
Resized windows to the left
</message>
<message name="IDS_A11Y_ALERT_SNAP_GROUP_RESIZE_RIGHT" translateable="false" desc="An alert for snap group resize.">
<message name="IDS_A11Y_ALERT_SNAP_GROUP_RESIZE_RIGHT" desc="An alert for snap group resize.">
Resized windows to the right
</message>
<message name="IDS_A11Y_ALERT_SNAP_GROUP_RESIZE_UP" translateable="false" desc="An alert for snap group resize.">
<message name="IDS_A11Y_ALERT_SNAP_GROUP_RESIZE_UP" desc="An alert for snap group resize.">
Resized windows to the top
</message>
<message name="IDS_A11Y_ALERT_SNAP_GROUP_RESIZE_DOWN" translateable="false" desc="An alert for snap group resize.">
<message name="IDS_A11Y_ALERT_SNAP_GROUP_RESIZE_DOWN" desc="An alert for snap group resize.">
Resized windows to the bottom
</message>
<message name="IDS_A11Y_ALERT_WINDOW_OVERVIEW_MODE_ENTERED" desc="The accessible text read when the user enters window overview mode in Ash.">

1
chrome/app/generated_resources_grd/IDS_A11Y_ALERT_SNAP_GROUP_RESIZE_DOWN.png.sha1 Normal file

@ -0,0 +1 @@
ed6c0a21cbcc521dfae05e025b1b8c2f661810f8

1
chrome/app/generated_resources_grd/IDS_A11Y_ALERT_SNAP_GROUP_RESIZE_LEFT.png.sha1 Normal file

@ -0,0 +1 @@
947f59c50169b60e37658b502fa190b8682627b2

1
chrome/app/generated_resources_grd/IDS_A11Y_ALERT_SNAP_GROUP_RESIZE_RIGHT.png.sha1 Normal file

@ -0,0 +1 @@
0052c3000d44f7d0b6e0ce1dfcf7d146bd867cab

1
chrome/app/generated_resources_grd/IDS_A11Y_ALERT_SNAP_GROUP_RESIZE_UP.png.sha1 Normal file

@ -0,0 +1 @@
540a317699f73ab69d3817da5daa1fc942ab2bdb