[CodeHealth] Clean up SimplifiedUrlDisplayCleanup feature.
The feature is inactive and there are no plans to revive it (confirmed with @meacer). Bug: 356237004 Change-Id: I35435a2631bfdddcdc6dd412e7636f2392233f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6110484 Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/main@{#1401883}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
8e2fb81155
commit
aea237163f
chrome/browser/safe_browsing
components/safe_browsing/core/common
ios/chrome/browser/safe_browsing/model
@ -426,8 +426,6 @@ bool ChromePasswordProtectionService::ShouldShowPasswordReusePageInfoBubble(
|
||||
safe_browsing::LoginReputationClientRequest::UrlDisplayExperiment
|
||||
ChromePasswordProtectionService::GetUrlDisplayExperiment() const {
|
||||
safe_browsing::LoginReputationClientRequest::UrlDisplayExperiment experiment;
|
||||
experiment.set_simplified_url_display_enabled(
|
||||
base::FeatureList::IsEnabled(safe_browsing::kSimplifiedUrlDisplay));
|
||||
// Delayed warnings parameters:
|
||||
experiment.set_delayed_warnings_enabled(
|
||||
base::FeatureList::IsEnabled(safe_browsing::kDelayedWarnings));
|
||||
|
@ -309,10 +309,6 @@ constexpr base::FeatureParam<int>
|
||||
"ShowWarningsForSuspiciousNotificationsScoreThreshold",
|
||||
/*default_value=*/100};
|
||||
|
||||
BASE_FEATURE(kSimplifiedUrlDisplay,
|
||||
"SimplifiedUrlDisplay",
|
||||
base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
|
||||
BASE_FEATURE(kSuspiciousSiteTriggerQuotaFeature,
|
||||
"SafeBrowsingSuspiciousSiteTriggerQuota",
|
||||
base::FEATURE_ENABLED_BY_DEFAULT);
|
||||
@ -361,7 +357,6 @@ base::Value::List GetFeatureStatusList() {
|
||||
&kSafeBrowsingRemoveCookiesInAuthRequests,
|
||||
&kSafetyHubAbusiveNotificationRevocation,
|
||||
&kShowWarningsForSuspiciousNotifications,
|
||||
&kSimplifiedUrlDisplay,
|
||||
&kSuspiciousSiteTriggerQuotaFeature,
|
||||
&kTailoredSecurityIntegration,
|
||||
&kVisualFeaturesSizes,
|
||||
|
@ -285,12 +285,6 @@ BASE_DECLARE_FEATURE(kShowWarningsForSuspiciousNotifications);
|
||||
extern const base::FeatureParam<int>
|
||||
kShowWarningsForSuspiciousNotificationsScoreThreshold;
|
||||
|
||||
// Status of the SimplifiedUrlDisplay experiments. This does not control the
|
||||
// individual experiments, those are controlled by their own feature flags.
|
||||
// The feature is only set by Finch so that we can differentiate between
|
||||
// default and control groups of the experiment.
|
||||
BASE_DECLARE_FEATURE(kSimplifiedUrlDisplay);
|
||||
|
||||
// Controls the daily quota for the suspicious site trigger.
|
||||
BASE_DECLARE_FEATURE(kSuspiciousSiteTriggerQuotaFeature);
|
||||
|
||||
|
@ -586,8 +586,9 @@ message LoginReputationClientRequest {
|
||||
optional bool hide_on_interaction = 4;
|
||||
// True if OmniboxUIExperimentElideToRegistrableDomain is enabled.
|
||||
optional bool elide_to_registrable_domain = 5;
|
||||
// True if this is the control group. This sent by the finch config.
|
||||
optional bool simplified_url_display_enabled = 6;
|
||||
|
||||
// Deprecated: simplified_url_display_enabled.
|
||||
reserved 6;
|
||||
};
|
||||
optional UrlDisplayExperiment url_display_experiment = 14;
|
||||
|
||||
|
@ -361,8 +361,6 @@ ChromePasswordProtectionService::GetPasswordProtectionWarningTriggerPref(
|
||||
LoginReputationClientRequest::UrlDisplayExperiment
|
||||
ChromePasswordProtectionService::GetUrlDisplayExperiment() const {
|
||||
safe_browsing::LoginReputationClientRequest::UrlDisplayExperiment experiment;
|
||||
experiment.set_simplified_url_display_enabled(
|
||||
base::FeatureList::IsEnabled(safe_browsing::kSimplifiedUrlDisplay));
|
||||
// Delayed warnings parameters:
|
||||
experiment.set_delayed_warnings_enabled(
|
||||
base::FeatureList::IsEnabled(safe_browsing::kDelayedWarnings));
|
||||
|
Reference in New Issue
Block a user