0

[CodeHealth] Clean up SimplifiedUrlDisplayCleanup feature.

The feature is inactive and there are no plans to revive it
(confirmed with @meacer).

Bug: 356237004
Change-Id: I35435a2631bfdddcdc6dd412e7636f2392233f46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6110484
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Maria Kazinova <kazinova@google.com>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401883}
This commit is contained in:
Maria Kazinova
2025-01-03 10:42:07 -08:00
committed by Chromium LUCI CQ
parent 8e2fb81155
commit aea237163f
5 changed files with 3 additions and 17 deletions
chrome/browser/safe_browsing
components/safe_browsing/core/common
ios/chrome/browser/safe_browsing/model

@ -426,8 +426,6 @@ bool ChromePasswordProtectionService::ShouldShowPasswordReusePageInfoBubble(
safe_browsing::LoginReputationClientRequest::UrlDisplayExperiment safe_browsing::LoginReputationClientRequest::UrlDisplayExperiment
ChromePasswordProtectionService::GetUrlDisplayExperiment() const { ChromePasswordProtectionService::GetUrlDisplayExperiment() const {
safe_browsing::LoginReputationClientRequest::UrlDisplayExperiment experiment; safe_browsing::LoginReputationClientRequest::UrlDisplayExperiment experiment;
experiment.set_simplified_url_display_enabled(
base::FeatureList::IsEnabled(safe_browsing::kSimplifiedUrlDisplay));
// Delayed warnings parameters: // Delayed warnings parameters:
experiment.set_delayed_warnings_enabled( experiment.set_delayed_warnings_enabled(
base::FeatureList::IsEnabled(safe_browsing::kDelayedWarnings)); base::FeatureList::IsEnabled(safe_browsing::kDelayedWarnings));

@ -309,10 +309,6 @@ constexpr base::FeatureParam<int>
"ShowWarningsForSuspiciousNotificationsScoreThreshold", "ShowWarningsForSuspiciousNotificationsScoreThreshold",
/*default_value=*/100}; /*default_value=*/100};
BASE_FEATURE(kSimplifiedUrlDisplay,
"SimplifiedUrlDisplay",
base::FEATURE_DISABLED_BY_DEFAULT);
BASE_FEATURE(kSuspiciousSiteTriggerQuotaFeature, BASE_FEATURE(kSuspiciousSiteTriggerQuotaFeature,
"SafeBrowsingSuspiciousSiteTriggerQuota", "SafeBrowsingSuspiciousSiteTriggerQuota",
base::FEATURE_ENABLED_BY_DEFAULT); base::FEATURE_ENABLED_BY_DEFAULT);
@ -361,7 +357,6 @@ base::Value::List GetFeatureStatusList() {
&kSafeBrowsingRemoveCookiesInAuthRequests, &kSafeBrowsingRemoveCookiesInAuthRequests,
&kSafetyHubAbusiveNotificationRevocation, &kSafetyHubAbusiveNotificationRevocation,
&kShowWarningsForSuspiciousNotifications, &kShowWarningsForSuspiciousNotifications,
&kSimplifiedUrlDisplay,
&kSuspiciousSiteTriggerQuotaFeature, &kSuspiciousSiteTriggerQuotaFeature,
&kTailoredSecurityIntegration, &kTailoredSecurityIntegration,
&kVisualFeaturesSizes, &kVisualFeaturesSizes,

@ -285,12 +285,6 @@ BASE_DECLARE_FEATURE(kShowWarningsForSuspiciousNotifications);
extern const base::FeatureParam<int> extern const base::FeatureParam<int>
kShowWarningsForSuspiciousNotificationsScoreThreshold; kShowWarningsForSuspiciousNotificationsScoreThreshold;
// Status of the SimplifiedUrlDisplay experiments. This does not control the
// individual experiments, those are controlled by their own feature flags.
// The feature is only set by Finch so that we can differentiate between
// default and control groups of the experiment.
BASE_DECLARE_FEATURE(kSimplifiedUrlDisplay);
// Controls the daily quota for the suspicious site trigger. // Controls the daily quota for the suspicious site trigger.
BASE_DECLARE_FEATURE(kSuspiciousSiteTriggerQuotaFeature); BASE_DECLARE_FEATURE(kSuspiciousSiteTriggerQuotaFeature);

@ -586,8 +586,9 @@ message LoginReputationClientRequest {
optional bool hide_on_interaction = 4; optional bool hide_on_interaction = 4;
// True if OmniboxUIExperimentElideToRegistrableDomain is enabled. // True if OmniboxUIExperimentElideToRegistrableDomain is enabled.
optional bool elide_to_registrable_domain = 5; optional bool elide_to_registrable_domain = 5;
// True if this is the control group. This sent by the finch config.
optional bool simplified_url_display_enabled = 6; // Deprecated: simplified_url_display_enabled.
reserved 6;
}; };
optional UrlDisplayExperiment url_display_experiment = 14; optional UrlDisplayExperiment url_display_experiment = 14;

@ -361,8 +361,6 @@ ChromePasswordProtectionService::GetPasswordProtectionWarningTriggerPref(
LoginReputationClientRequest::UrlDisplayExperiment LoginReputationClientRequest::UrlDisplayExperiment
ChromePasswordProtectionService::GetUrlDisplayExperiment() const { ChromePasswordProtectionService::GetUrlDisplayExperiment() const {
safe_browsing::LoginReputationClientRequest::UrlDisplayExperiment experiment; safe_browsing::LoginReputationClientRequest::UrlDisplayExperiment experiment;
experiment.set_simplified_url_display_enabled(
base::FeatureList::IsEnabled(safe_browsing::kSimplifiedUrlDisplay));
// Delayed warnings parameters: // Delayed warnings parameters:
experiment.set_delayed_warnings_enabled( experiment.set_delayed_warnings_enabled(
base::FeatureList::IsEnabled(safe_browsing::kDelayedWarnings)); base::FeatureList::IsEnabled(safe_browsing::kDelayedWarnings));