Remove unused base/sys_byteorder.h includes

Bug: 40284755
Change-Id: If51679d9d4765d125e63121a4a32b473ad2f601c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406492
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Auto-Submit: danakj <danakj@chromium.org>
Owners-Override: Kyle Charbonneau <kylechar@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1282463}

ash/components/arc/net/arc_net_utils_unittest.cc

@@ -7,7 +7,6 @@
 #include <memory>
 #include <string>
 
-#include "base/sys_byteorder.h"
 #include "base/test/task_environment.h"
 #include "chromeos/ash/components/network/device_state.h"
 #include "chromeos/ash/components/network/network_state_test_helper.h"

base/big_endian.h

@@ -17,8 +17,6 @@
 #include "base/containers/span.h"
 #include "base/memory/raw_span.h"
 #include "base/strings/string_piece.h"
-#include "base/sys_byteorder.h"
-#include "build/build_config.h"
 
 namespace base {
 

chrome/browser/metrics/chromeos_metrics_provider.cc

@@ -23,7 +23,6 @@
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
-#include "base/sys_byteorder.h"
 #include "base/task/task_traits.h"
 #include "base/task/thread_pool.h"
 #include "chrome/browser/ash/accessibility/accessibility_manager.h"

chrome/browser/webauthn/android/cable_module_android.cc

@@ -10,7 +10,6 @@
 #include "base/logging.h"
 #include "base/memory/raw_ptr_exclusion.h"
 #include "base/no_destructor.h"
-#include "base/sys_byteorder.h"
 #include "base/task/task_traits.h"
 #include "base/task/thread_pool.h"
 #include "chrome/browser/browser_process.h"

chrome/browser/webauthn/chrome_authenticator_request_delegate.cc

@@ -20,7 +20,6 @@
 #include "base/memory/raw_ptr.h"
 #include "base/ranges/algorithm.h"
 #include "base/strings/string_split.h"
-#include "base/sys_byteorder.h"
 #include "base/task/thread_pool.h"
 #include "base/values.h"
 #include "build/build_config.h"

chrome/services/sharing/webrtc/ipc_network_manager.cc

@@ -10,7 +10,6 @@
 
 #include "base/functional/bind.h"
 #include "base/location.h"
-#include "base/sys_byteorder.h"
 #include "base/task/single_thread_task_runner.h"
 #include "components/webrtc/net_address_utils.h"
 #include "net/base/ip_address.h"

components/gcm_driver/crypto/gcm_message_cryptographer.cc

@@ -18,7 +18,6 @@
 #include "base/numerics/safe_conversions.h"
 #include "base/numerics/safe_math.h"
 #include "base/strings/strcat.h"
-#include "base/sys_byteorder.h"
 #include "crypto/hkdf.h"
 #include "third_party/boringssl/src/include/openssl/aead.h"
 

components/gcm_driver/fake_gcm_client.cc

@@ -12,7 +12,6 @@
 #include "base/functional/bind.h"
 #include "base/location.h"
 #include "base/strings/string_number_conversions.h"
-#include "base/sys_byteorder.h"
 #include "base/task/sequenced_task_runner.h"
 #include "base/task/single_thread_task_runner.h"
 #include "base/time/time.h"

components/media_router/common/providers/cast/channel/cast_socket.cc

@@ -19,7 +19,6 @@
 #include "base/numerics/safe_conversions.h"
 #include "base/observer_list.h"
 #include "base/strings/string_number_conversions.h"
-#include "base/sys_byteorder.h"
 #include "base/task/single_thread_task_runner.h"
 #include "base/time/time.h"
 #include "components/media_router/common/providers/cast/channel/cast_auth_util.h"

components/media_router/common/providers/cast/channel/cast_socket_unittest.cc

@@ -20,7 +20,6 @@
 #include "base/path_service.h"
 #include "base/run_loop.h"
 #include "base/strings/string_number_conversions.h"
-#include "base/sys_byteorder.h"
 #include "base/task/single_thread_task_runner.h"
 #include "base/test/bind.h"
 #include "base/timer/mock_timer.h"

components/policy/core/common/policy_loader_win_unittest.cc

@@ -23,7 +23,6 @@
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
-#include "base/sys_byteorder.h"
 #include "base/task/sequenced_task_runner.h"
 #include "base/values.h"
 #include "base/win/registry.h"

components/policy/core/common/registry_dict.cc

@@ -10,10 +10,10 @@
 
 #include "base/json/json_reader.h"
 #include "base/logging.h"
+#include "base/numerics/byte_conversions.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
-#include "base/sys_byteorder.h"
 #include "base/values.h"
 #include "build/build_config.h"
 #include "components/policy/core/common/schema.h"

components/segmentation_platform/internal/database/ukm_url_table.cc

@@ -9,7 +9,6 @@
 #include "base/containers/span.h"
 #include "base/hash/md5.h"
 #include "base/logging.h"
-#include "base/sys_byteorder.h"
 #include "components/database_utils/url_converter.h"
 #include "sql/database.h"
 #include "sql/statement.h"

content/child/font_warmup_win_unittest.cc

@@ -17,7 +17,6 @@
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/path_service.h"
-#include "base/sys_byteorder.h"
 #include "base/test/task_environment.h"
 
 #include "content/child/dwrite_font_proxy/dwrite_font_proxy_win.h"

crypto/encryptor.cc

@@ -9,7 +9,6 @@
 
 #include "base/logging.h"
 #include "base/strings/string_util.h"
-#include "base/sys_byteorder.h"
 #include "crypto/openssl_util.h"
 #include "crypto/symmetric_key.h"
 #include "third_party/boringssl/src/include/openssl/aes.h"

device/fido/cable/v2_handshake.cc

@@ -12,12 +12,12 @@
 #include <type_traits>
 
 #include "base/base64url.h"
+#include "base/numerics/byte_conversions.h"
 #include "base/numerics/safe_conversions.h"
 #include "base/numerics/safe_math.h"
 #include "base/ranges/algorithm.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
-#include "base/sys_byteorder.h"
 #include "components/cbor/reader.h"
 #include "components/cbor/values.h"
 #include "components/cbor/writer.h"

media/base/android/media_drm_bridge.cc

@@ -23,7 +23,6 @@
 #include "base/ranges/algorithm.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
-#include "base/sys_byteorder.h"
 #include "base/system/sys_info.h"
 #include "base/task/single_thread_task_runner.h"
 #include "media/base/android/android_util.h"

media/cast/encoding/audio_encoder.cc

@@ -19,7 +19,6 @@
 #include "base/logging.h"
 #include "base/memory/raw_ptr.h"
 #include "base/numerics/byte_conversions.h"
-#include "base/sys_byteorder.h"
 #include "base/time/time.h"
 #include "base/trace_event/trace_event.h"
 #include "build/build_config.h"

media/cast/test/receiver/audio_decoder.cc

@@ -17,7 +17,6 @@
 #include "base/memory/raw_ptr.h"
 #include "base/numerics/byte_conversions.h"
 #include "base/numerics/safe_conversions.h"
-#include "base/sys_byteorder.h"
 #include "build/build_config.h"
 #include "media/cast/common/encoded_frame.h"
 #include "third_party/opus/src/include/opus.h"

media/cast/test/receiver/audio_decoder_unittest.cc

@@ -11,9 +11,9 @@
 
 #include "base/functional/bind.h"
 #include "base/functional/callback_helpers.h"
+#include "base/numerics/byte_conversions.h"
 #include "base/synchronization/condition_variable.h"
 #include "base/synchronization/lock.h"
-#include "base/sys_byteorder.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
 #include "media/cast/cast_config.h"

media/filters/audio_decoder_unittest.cc

@@ -16,7 +16,6 @@
 #include "base/hash/md5.h"
 #include "base/run_loop.h"
 #include "base/strings/stringprintf.h"
-#include "base/sys_byteorder.h"
 #include "base/test/task_environment.h"
 #include "base/threading/platform_thread.h"
 #include "base/time/time.h"

media/filters/mac/audio_toolbox_audio_decoder.cc

@@ -12,7 +12,6 @@
 #include "base/logging.h"
 #include "base/memory/raw_ptr.h"
 #include "base/ranges/algorithm.h"
-#include "base/sys_byteorder.h"
 #include "base/task/bind_post_task.h"
 #include "media/base/audio_buffer.h"
 #include "media/base/audio_codecs.h"

media/filters/vp9_parser.cc

@@ -18,8 +18,8 @@
 #include "base/functional/bind.h"
 #include "base/functional/callback_helpers.h"
 #include "base/logging.h"
+#include "base/numerics/byte_conversions.h"
 #include "base/numerics/safe_conversions.h"
-#include "base/sys_byteorder.h"
 #include "media/filters/vp9_compressed_header_parser.h"
 #include "media/filters/vp9_uncompressed_header_parser.h"
 

media/filters/vpx_video_decoder.cc

@@ -19,7 +19,6 @@
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/numerics/byte_conversions.h"
-#include "base/sys_byteorder.h"
 #include "base/task/bind_post_task.h"
 #include "base/trace_event/trace_event.h"
 #include "media/base/decoder_buffer.h"

media/video/gpu_memory_buffer_video_frame_pool.cc

@@ -26,7 +26,6 @@
 #include "base/metrics/histogram_macros.h"
 #include "base/ranges/algorithm.h"
 #include "base/strings/stringprintf.h"
-#include "base/sys_byteorder.h"
 #include "base/task/sequenced_task_runner.h"
 #include "base/time/default_tick_clock.h"
 #include "base/time/time.h"

pdf/pdfium/pdfium_font_linux.cc

@@ -27,7 +27,6 @@
 #include "base/posix/eintr_wrapper.h"
 #include "base/sequence_checker.h"
 #include "base/strings/string_util.h"
-#include "base/sys_byteorder.h"
 #include "components/services/font/public/cpp/font_loader.h"
 #include "pdf/pdfium/pdfium_engine.h"
 #include "third_party/blink/public/platform/web_font_description.h"

remoting/protocol/stun_tcp_packet_processor.cc

@@ -8,7 +8,6 @@
 #include "base/no_destructor.h"
 #include "base/notreached.h"
 #include "base/numerics/byte_conversions.h"
-#include "base/sys_byteorder.h"
 #include "net/base/io_buffer.h"
 #include "third_party/webrtc/media/base/rtp_utils.h"
 #include "third_party/webrtc/rtc_base/time_utils.h"

services/network/mdns_responder.cc

@@ -12,7 +12,6 @@
 #include <string>
 #include <utility>
 
-#include "base/big_endian.h"
 #include "base/functional/bind.h"
 #include "base/logging.h"
 #include "base/memory/raw_ptr.h"
@@ -20,7 +19,6 @@
 #include "base/numerics/safe_conversions.h"
 #include "base/rand_util.h"
 #include "base/strings/stringprintf.h"
-#include "base/sys_byteorder.h"
 #include "base/time/default_tick_clock.h"
 #include "base/time/time.h"
 #include "base/timer/timer.h"

services/network/p2p/socket_udp_unittest.cc

@@ -16,7 +16,6 @@
 #include "base/memory/raw_ptr.h"
 #include "base/notreached.h"
 #include "base/run_loop.h"
-#include "base/sys_byteorder.h"
 #include "base/test/task_environment.h"
 #include "base/time/time.h"
 #include "base/unguessable_token.h"

services/network/public/cpp/server/web_socket.cc

@@ -11,7 +11,6 @@
 #include "base/hash/sha1.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
-#include "base/sys_byteorder.h"
 #include "net/websockets/websocket_deflate_parameters.h"
 #include "net/websockets/websocket_extension.h"
 #include "net/websockets/websocket_handshake_constants.h"

third_party/blink/common/origin_trials/trial_token.cc

@@ -8,10 +8,10 @@
 #include <optional>
 
 #include "base/base64.h"
-#include "base/big_endian.h"
 #include "base/json/json_reader.h"
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
+#include "base/numerics/byte_conversions.h"
 #include "base/strings/strcat.h"
 #include "base/strings/string_piece.h"
 #include "base/time/time.h"

third_party/blink/public/common/privacy_budget/identifiable_token_builder.h

@@ -9,7 +9,6 @@
 
 #include "base/containers/span.h"
 #include "base/strings/string_piece.h"
-#include "base/sys_byteorder.h"
 #include "base/template_util.h"
 #include "third_party/blink/public/common/common_export.h"
 #include "third_party/blink/public/common/privacy_budget/identifiability_internal_templates.h"

third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.cc

@@ -37,7 +37,6 @@
 #include "base/numerics/checked_math.h"
 #include "base/numerics/safe_conversions.h"
 #include "base/ranges/algorithm.h"
-#include "base/sys_byteorder.h"
 #include "base/types/expected_macros.h"
 #include "third_party/blink/public/web/web_serialized_script_value_version.h"
 #include "third_party/blink/renderer/bindings/core/v8/idl_types.h"

third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_serializer.cc

@@ -6,7 +6,7 @@
 
 #include "base/auto_reset.h"
 #include "base/feature_list.h"
-#include "base/sys_byteorder.h"
+#include "base/numerics/byte_conversions.h"
 #include "third_party/blink/public/common/features.h"
 #include "third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom-blink.h"
 #include "third_party/blink/public/platform/web_blob_info.h"

third_party/blink/renderer/core/html/canvas/image_data.cc

@@ -28,7 +28,6 @@
 
 #include "third_party/blink/renderer/core/html/canvas/image_data.h"
 
-#include "base/sys_byteorder.h"
 #include "third_party/blink/renderer/bindings/core/v8/to_v8_traits.h"
 #include "third_party/blink/renderer/bindings/core/v8/v8_image_bitmap_options.h"
 #include "third_party/blink/renderer/bindings/core/v8/v8_union_float32array_uint16array_uint8clampedarray.h"

third_party/blink/renderer/modules/font_access/font_metadata.cc

@@ -7,10 +7,8 @@
 #include <memory>
 #include <utility>
 
-#include "base/big_endian.h"
 #include "base/metrics/histogram_functions.h"
 #include "base/numerics/safe_conversions.h"
-#include "base/sys_byteorder.h"
 #include "build/build_config.h"
 #include "third_party/blink/renderer/bindings/core/v8/script_promise_resolver.h"
 #include "third_party/blink/renderer/core/fileapi/blob.h"

third_party/blink/renderer/platform/fonts/simple_font_data.cc

@@ -36,7 +36,7 @@
 #include <utility>
 
 #include "base/memory/ptr_util.h"
-#include "base/sys_byteorder.h"
+#include "base/numerics/byte_conversions.h"
 #include "build/build_config.h"
 #include "skia/ext/font_utils.h"
 #include "third_party/blink/renderer/platform/font_family_names.h"

third_party/blink/renderer/platform/graphics/color_correction_test_utils.cc

@@ -6,7 +6,6 @@
 
 #include "base/containers/heap_array.h"
 #include "base/notreached.h"
-#include "base/sys_byteorder.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/skia/modules/skcms/skcms.h"
 

third_party/blink/renderer/platform/graphics/logging_canvas.cc

@@ -33,7 +33,6 @@
 #include <unicode/unistr.h>
 
 #include "base/logging.h"
-#include "base/sys_byteorder.h"
 #include "build/build_config.h"
 #include "third_party/blink/renderer/platform/graphics/skia/skia_utils.h"
 #include "third_party/blink/renderer/platform/image-encoders/image_encoder.h"

third_party/blink/renderer/platform/p2p/ipc_network_manager.cc

@@ -12,7 +12,6 @@
 #include "base/logging.h"
 #include "base/memory/weak_ptr.h"
 #include "base/metrics/histogram_macros.h"
-#include "base/sys_byteorder.h"
 #include "base/task/single_thread_task_runner.h"
 #include "components/webrtc/net_address_utils.h"
 #include "net/base/ip_address.h"

third_party/zlib/google/compression_utils.cc

@@ -6,7 +6,6 @@
 
 #include "base/check_op.h"
 #include "base/process/memory.h"
-#include "base/sys_byteorder.h"
 
 #include "third_party/zlib/google/compression_utils_portable.h"
 

ui/base/resource/data_pack.cc

@@ -22,8 +22,6 @@
 #include "base/memory/ref_counted_memory.h"
 #include "base/strings/string_piece.h"
 #include "base/synchronization/lock.h"
-#include "base/sys_byteorder.h"
-#include "build/build_config.h"
 #include "net/filter/gzip_header.h"
 #include "third_party/zlib/google/compression_utils.h"
 #include "ui/base/resource/resource_scale_factor.h"
@@ -378,12 +376,6 @@ base::StringPiece DataPack::GetStringPieceFromOffset(
 
 std::optional<base::StringPiece> DataPack::GetStringPiece(
     uint16_t resource_id) const {
-  // It won't be hard to make this endian-agnostic, but it's not worth
-  // bothering to do right now.
-#if !defined(ARCH_CPU_LITTLE_ENDIAN)
-#error "datapack assumes little endian"
-#endif
-
   const Entry* target = LookupEntryById(resource_id);
   if (!target)
     return std::nullopt;
@@ -455,9 +447,6 @@ void DataPack::CheckForDuplicateResources(
 bool DataPack::WritePack(const base::FilePath& path,
                          const std::map<uint16_t, base::StringPiece>& resources,
                          TextEncodingType text_encoding_type) {
-#if !defined(ARCH_CPU_LITTLE_ENDIAN)
-#error "datapack assumes little endian"
-#endif
   if (text_encoding_type != UTF8 && text_encoding_type != UTF16 &&
       text_encoding_type != BINARY) {
     LOG(ERROR) << "Invalid text encoding type, got " << text_encoding_type

ui/base/x/x11_cursor_loader_unittest.cc

@@ -6,8 +6,9 @@
 
 #undef Bool
 
+#include "base/containers/span.h"
 #include "base/memory/ref_counted_memory.h"
-#include "base/sys_byteorder.h"
+#include "base/numerics/byte_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace ui {

ui/base/x/x11_pointer_grab.cc

@@ -8,7 +8,6 @@
 #include "base/check.h"
 #include "base/functional/bind.h"
 #include "base/no_destructor.h"
-#include "base/sys_byteorder.h"
 #include "ui/base/x/x11_util.h"
 #include "ui/events/devices/x11/device_data_manager_x11.h"
 #include "ui/gfx/x/connection.h"