chromium/src
0
Fork 0
Code Activity

[gtm] Small changes

Browse Source 
1. Fixed the bug when no task is showing, "Add a Task" button has a
large gap with the bottom of the container.
2. Update the tooltip/a11y name of the combobox

Bug: b/326658243
Change-Id: Ia3c663f5d4a534e78b94d61e711e628a4425ad6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5374716
Auto-Submit: Wen-Chien Wang <wcwang@chromium.org>
Commit-Queue: Wen-Chien Wang <wcwang@chromium.org>
Reviewed-by: Artsiom Mitrokhin <amitrokhin@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273692}
This commit is contained in:
Wen-Chien Wang
2024-03-15 22:24:00 +00:00
committed by Chromium LUCI CQ
parent a336c31bf4
commit af923e7bef
4 changed files with 15 additions and 6 deletions

2
ash/ash_strings.grd

@ -7352,7 +7352,7 @@ New install
Classwork type: <ph name="GLANCEABLES_CLASSROOM_LIST_NAME">$1<ex>Due soon</ex></ph>
</message>
<message name="IDS_GLANCEABLES_TASKS_DROPDOWN_ACCESSIBLE_NAME" desc="The glanceable displays tasks items fetched from Google Tasks API. This is the a11y name announced by ChromeVox for the dropdown menu allowing to switch tasks lists.">
Google tasks list
Task list: <ph name="GLANCEABLES_TASKS_LIST_NAME">$1<ex>Task List 1</ex></ph>
</message>
<message name="IDS_GLANCEABLES_TASKS_SELECTED_LIST_ACCESSIBLE_NAME" desc="The glanceable displays tasks items fetched from Google Tasks API. This is the a11y name announced by ChromeVox for the active tasks list.">
Google tasks list: <ph name="GLANCEABLES_TASKS_LIST_NAME">$1<ex>Task List 1</ex></ph>

2
ash/ash_strings_grd/IDS_GLANCEABLES_TASKS_DROPDOWN_ACCESSIBLE_NAME.png.sha1

@ -1 +1 @@
d9ff5705b027c5ecf44f9f250d9a6da6c9a38a3d
c18928ad31e33bbbdcff702769ea3e59d290c786

12
ash/glanceables/tasks/glanceables_tasks_view.cc

@ -476,8 +476,15 @@ void GlanceablesTasksView::UpdateTasksInTaskList(
}
}
task_list_initially_empty_ = num_tasks_shown == 0;
// Set `task_items_container_view_` to invisible if there is no task so that
// the layout manager won't include it as a visible view.
task_items_container_view_->SetVisible(
task_items_container_view_->children().size() > 0);
list_footer_view_->SetVisible(tasks->item_count() >= kMaximumTasks);
task_list_combo_box_view_->SetTooltipText(
l10n_util::GetStringFUTF16(IDS_GLANCEABLES_TASKS_DROPDOWN_ACCESSIBLE_NAME,
base::UTF8ToUTF16(task_list_title)));
task_items_container_view_->SetAccessibleName(l10n_util::GetStringFUTF16(
IDS_GLANCEABLES_TASKS_SELECTED_LIST_ACCESSIBLE_NAME,
base::UTF8ToUTF16(task_list_title)));
@ -691,8 +698,9 @@ void GlanceablesTasksView::CreateComboBoxView() {
views::MaximumFlexSizeRule::kPreferred));
combobox_view_observation_.Observe(task_list_combo_box_view_);
task_list_combo_box_view_->SetTooltipText(l10n_util::GetStringUTF16(
IDS_GLANCEABLES_TASKS_DROPDOWN_ACCESSIBLE_NAME));
// Assign a default value for tooltip and accessible text.
task_list_combo_box_view_->SetTooltipText(l10n_util::GetStringFUTF16(
IDS_GLANCEABLES_TASKS_DROPDOWN_ACCESSIBLE_NAME, u""));
task_list_combo_box_view_->SetAccessibleDescription(u"");
task_list_combo_box_view_->SetSelectionChangedCallback(base::BindRepeating(
&GlanceablesTasksView::SelectedTasksListChanged, base::Unretained(this)));

5
ash/system/unified/tasks_bubble_view.cc

@ -161,8 +161,6 @@ TasksBubbleView::TasksBubbleView(const ui::ListModel<api::TaskList>* task_lists)
views::MaximumFlexSizeRule::kPreferred));
combobox_view_observation_.Observe(task_list_combo_box_view_);
task_list_combo_box_view_->SetTooltipText(l10n_util::GetStringUTF16(
IDS_GLANCEABLES_TASKS_DROPDOWN_ACCESSIBLE_NAME));
task_list_combo_box_view_->SetAccessibleDescription(u"");
task_list_combo_box_view_->SetSelectionChangedCallback(base::BindRepeating(
&TasksBubbleView::SelectedTasksListChanged, base::Unretained(this)));
@ -287,6 +285,9 @@ void TasksBubbleView::UpdateTasksList(const std::string& task_list_id,
list_footer_view_->UpdateItemsCount(num_tasks_shown_, num_tasks_);
list_footer_view_->SetVisible(num_tasks_shown_ > 0);
task_list_combo_box_view_->SetTooltipText(
l10n_util::GetStringFUTF16(IDS_GLANCEABLES_TASKS_DROPDOWN_ACCESSIBLE_NAME,
base::UTF8ToUTF16(task_list_title)));
task_items_container_view_->SetAccessibleName(l10n_util::GetStringFUTF16(
IDS_GLANCEABLES_TASKS_SELECTED_LIST_ACCESSIBLE_NAME,
base::UTF8ToUTF16(task_list_title)));