Remove additional_args_key from generate_buildbot_json.py.
The initialize_args_for_test function in generate_buildbot_json.py accepts an argument for additional args keys to apply. The only use of this argument is gtest_args being passed in for generating gtests, but no tests set that key, so the code for handling it is unused. Change-Id: I5fb5f50b49a3dea53e5eff138326ad20ece58291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5483827 Reviewed-by: Stephanie Kim <kimstephanie@google.com> Auto-Submit: Garrett Beaty <gbeaty@google.com> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/main@{#1291943}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
cd5549deb3
commit
afb41c9213
@ -586,8 +586,7 @@ class BBJSONGenerator(object): # pylint: disable=useless-object-inheritance
|
||||
|
||||
return a
|
||||
|
||||
def initialize_args_for_test(
|
||||
self, generated_test, tester_config, additional_arg_keys=None):
|
||||
def initialize_args_for_test(self, generated_test, tester_config):
|
||||
args = []
|
||||
args.extend(generated_test.get('args', []))
|
||||
args.extend(tester_config.get('args', []))
|
||||
@ -606,10 +605,6 @@ class BBJSONGenerator(object): # pylint: disable=useless-object-inheritance
|
||||
add_conditional_args('win_args', self.is_win)
|
||||
add_conditional_args('win64_args', self.is_win64)
|
||||
|
||||
for key in additional_arg_keys or []:
|
||||
args.extend(generated_test.pop(key, []))
|
||||
args.extend(tester_config.get(key, []))
|
||||
|
||||
if args:
|
||||
generated_test['args'] = self.maybe_fixup_args_array(args)
|
||||
|
||||
@ -750,8 +745,7 @@ class BBJSONGenerator(object): # pylint: disable=useless-object-inheritance
|
||||
result.setdefault('test', test_name)
|
||||
self.initialize_swarming_dictionary_for_test(result, tester_config)
|
||||
|
||||
self.initialize_args_for_test(
|
||||
result, tester_config, additional_arg_keys=['gtest_args'])
|
||||
self.initialize_args_for_test(result, tester_config)
|
||||
result = self.update_and_cleanup_test(result, test_name, tester_name,
|
||||
tester_config, waterfall)
|
||||
if self.is_android(tester_config) and 'swarming' in result:
|
||||
|
Reference in New Issue
Block a user