chromium/src
0
Fork 0
Code Activity

[Mac Resource Bundle] Add crash keys to ResourceBundle::GetLocaleFilePath

Browse Source 
This cl adds crash keys collect some information about a rare crash on
macOS.

Bug: 394631579
Change-Id: I56e5f797f5fadfed345ed5ad9afe13676327e857
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6253642
Commit-Queue: Jayson Adams <shrike@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418960}
This commit is contained in:
Jayson Adams
2025-02-11 15:44:28 -08:00
committed by Chromium LUCI CQ
parent ea8675d166
commit b342af786a
1 changed files with 12 additions and 0 deletions

12
ui/base/resource/resource_bundle.cc

@ -476,6 +476,18 @@ std::string ResourceBundle::LoadLocaleResources(const std::string& pref_locale,
std::size(path_copy));
base::debug::Alias(path_copy);
#endif // BUILDFLAG(IS_WIN)
// Collect diagnostic info for https://crbug.com/394631579 .
#if BUILDFLAG(IS_MAC)
SCOPED_CRASH_KEY_STRING32("LoadLocaleResources", "pref_locale",
pref_locale);
SCOPED_CRASH_KEY_STRING32("LoadLocaleResources", "app_locale", app_locale);
SCOPED_CRASH_KEY_STRING1024("LoadLocaleResources", "override_filepath",
GetOverriddenPakPath().AsUTF8Unsafe());
SCOPED_CRASH_KEY_STRING1024("LoadLocaleResources", "locale_filepath",
locale_file_path.AsUTF8Unsafe());
#endif // BUILDFLAG(IS_MAC)
NOTREACHED();
}