chromium/src
0
Fork 0
Code Activity

Clean up enable-pip-tuck

Browse Source 
The feature was enabled on M130, and has been stable for a couple
of milestones.

BUG=b:394327675
TEST=build

Change-Id: I6dfe1e26764ff5ffc79d77a040b0099067ce49b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6232621
Commit-Queue: Kazuki Takise <takise@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1416575}
This commit is contained in:
Kazuki Takise
2025-02-05 19:22:14 -08:00
committed by Chromium LUCI CQ
parent 28c1357c95
commit b3a97d2fa1
9 changed files with 3 additions and 35 deletions

7
ash/constants/ash_features.cc

@ -2315,9 +2315,6 @@ BASE_FEATURE(kPhoneHubShortQuickActionPodsTitles,
// Enables GIF search in Picker.
BASE_FEATURE(kPickerGifs, "PickerGifs", base::FEATURE_ENABLED_BY_DEFAULT);
// Enables or disables the tuck feature for Picture in Picture.
BASE_FEATURE(kPipTuck, "PipTuck", base::FEATURE_ENABLED_BY_DEFAULT);
// Enables or disables the preference of using constant frame rate for camera
// when streaming.
BASE_FEATURE(kPreferConstantFrameRate,
@ -4205,10 +4202,6 @@ bool IsPinAutosubmitBackfillFeatureEnabled() {
return base::FeatureList::IsEnabled(kQuickUnlockPinAutosubmitBackfill);
}
bool IsPipTuckEnabled() {
return base::FeatureList::IsEnabled(kPipTuck);
}
bool IsPrinterPreviewCrosAppEnabled() {
return base::FeatureList::IsEnabled(kPrintPreviewCrosApp);
}

2
ash/constants/ash_features.h

@ -760,7 +760,6 @@ extern const base::FeatureParam<base::TimeDelta> kPhoneHubPingTimeout;
COMPONENT_EXPORT(ASH_CONSTANTS)
BASE_DECLARE_FEATURE(kPhoneHubShortQuickActionPodsTitles);
COMPONENT_EXPORT(ASH_CONSTANTS) BASE_DECLARE_FEATURE(kPickerGifs);
COMPONENT_EXPORT(ASH_CONSTANTS) BASE_DECLARE_FEATURE(kPipTuck);
COMPONENT_EXPORT(ASH_CONSTANTS) BASE_DECLARE_FEATURE(kPreferConstantFrameRate);
COMPONENT_EXPORT(ASH_CONSTANTS) BASE_DECLARE_FEATURE(kPrintPreviewCrosApp);
COMPONENT_EXPORT(ASH_CONSTANTS) BASE_DECLARE_FEATURE(kProjectorManagedUser);
@ -1276,7 +1275,6 @@ COMPONENT_EXPORT(ASH_CONSTANTS) bool IsMouseImposterCheckEnabled();
COMPONENT_EXPORT(ASH_CONSTANTS) bool IsSplitKeyboardRefactorEnabled();
COMPONENT_EXPORT(ASH_CONSTANTS) bool IsPickerUpdateEnabled();
COMPONENT_EXPORT(ASH_CONSTANTS) bool IsPinAutosubmitBackfillFeatureEnabled();
COMPONENT_EXPORT(ASH_CONSTANTS) bool IsPipTuckEnabled();
COMPONENT_EXPORT(ASH_CONSTANTS) bool IsPrinterPreviewCrosAppEnabled();
COMPONENT_EXPORT(ASH_CONSTANTS) bool IsProductivityLauncherImageSearchEnabled();
COMPONENT_EXPORT(ASH_CONSTANTS) bool IsProjectorEnabled();

7
ash/wm/pip/pip_controller_unittest.cc

@ -6,7 +6,6 @@
#include <memory>
#include "ash/constants/ash_features.h"
#include "ash/shell.h"
#include "ash/test/ash_test_base.h"
#include "ash/wm/collision_detection/collision_detection_utils.h"
@ -16,7 +15,6 @@
#include "ash/wm/window_dimmer.h"
#include "ash/wm/window_state.h"
#include "ash/wm/wm_event.h"
#include "base/test/scoped_feature_list.h"
#include "chromeos/ui/base/window_state_type.h"
#include "ui/aura/client/aura_constants.h"
#include "ui/compositor/layer.h"
@ -44,7 +42,7 @@ constexpr gfx::Size kExpectedPipDefaultSize(200, 133);
class PipControllerTest : public AshTestBase {
public:
PipControllerTest() : scoped_feature_list_(features::kPipTuck) {}
PipControllerTest() = default;
PipControllerTest(const PipControllerTest&) = delete;
PipControllerTest& operator=(const PipControllerTest&) = delete;
@ -66,9 +64,6 @@ class PipControllerTest : public AshTestBase {
window.get()->Show();
return window;
}
private:
base::test::ScopedFeatureList scoped_feature_list_;
};
class PipControllerTestAPI {

5
ash/wm/pip/pip_window_resizer.cc

@ -174,7 +174,7 @@ void PipWindowResizer::Drag(const gfx::PointF& location_in_parent,
float in_screen_area = in_screen_bounds.width() * in_screen_bounds.height();
if (bounds_area != 0.f) {
in_screen_fraction_ = in_screen_area / bounds_area;
if (may_dismiss_horizontally_ && features::IsPipTuckEnabled()) {
if (may_dismiss_horizontally_) {
if (bounds_area != 0.f) {
Shell::Get()->pip_controller()->SetDimOpacity(
fmin(0.5f, 1 - in_screen_fraction_));
@ -294,8 +294,7 @@ void PipWindowResizer::CompleteDrag() {
in_screen_fraction_ < kPipDismissFraction ||
(in_screen_fraction_ != 1.f &&
fling_amount >= kPipSwipeToDismissFlingThresholdSquared);
bool should_tuck = should_dismiss_or_tuck && may_dismiss_horizontally_ &&
features::IsPipTuckEnabled();
bool should_tuck = should_dismiss_or_tuck && may_dismiss_horizontally_;
bool should_dismiss = should_dismiss_or_tuck && !should_tuck;
if (should_dismiss) {

4
chrome/browser/about_flags.cc

@ -7928,10 +7928,6 @@ const FeatureEntry kFeatureEntries[] = {
flag_descriptions::kAccessibilityMouseKeysDescription, kOsCrOS,
FEATURE_VALUE_TYPE(features::kAccessibilityMouseKeys)},
{"enable-pip-tuck", flag_descriptions::kPipTuckName,
flag_descriptions::kPipTuckDescription, kOsCrOS,
FEATURE_VALUE_TYPE(ash::features::kPipTuck)},
{"event-based-log-upload", flag_descriptions::kEventBasedLogUpload,
flag_descriptions::kEventBasedLogUploadDescription, kOsCrOS,
FEATURE_VALUE_TYPE(features::kEventBasedLogUpload)},

5
chrome/browser/flag-metadata.json

@ -3580,11 +3580,6 @@
"owners": [ "jonmann@chromium.org", "nayebi@chromium.org" ],
"expiry_milestone": 125
},
{
"name": "enable-pip-tuck",
"owners": [ "takise@chromium.org" ],
"expiry_milestone": 135
},
{
"name": "enable-pix-payments",
"owners": [ "siashah@google.com", "chrome-payments-team@google.com", "payments-autofill-team@google.com" ],

3
chrome/browser/flag_descriptions.cc

@ -1527,9 +1527,6 @@ const char kEnableWindowsGamingInputDataFetcherDescription[] =
"Enable Windows.Gaming.Input by default to provide game controller "
"support on Windows 10 desktop.";
const char kPipTuckName[] = "Enable tuck for PiP windows";
const char kPipTuckDescription[] = "Enables window tucking for PiP windows. ";
const char kPrivacyGuideAiSettingsName[] = "AI settings in Privacy Guide";
const char kPrivacyGuideAiSettingsDescription[] =
"Enables the AI settings linkout in the Privacy Guide completion card.";

3
chrome/browser/flag_descriptions.h

@ -798,9 +798,6 @@ extern const char kEnableNetworkLoggingToFileDescription[];
extern const char kEnableWindowsGamingInputDataFetcherName[];
extern const char kEnableWindowsGamingInputDataFetcherDescription[];
extern const char kPipTuckName[];
extern const char kPipTuckDescription[];
extern const char kPrivacyGuideAiSettingsName[];
extern const char kPrivacyGuideAiSettingsDescription[];

2
tools/metrics/histograms/enums.xml

@ -9245,7 +9245,6 @@ from previous Chrome versions.
<int value="-1935889520" label="LinkedServicesSetting:enabled"/>
<int value="-1935787681" label="SystemNotifications:disabled"/>
<int value="-1935597303" label="OptimizeEarlyNavigation:enabled"/>
<int value="-1935466197" label="PipTuck:enabled"/>
<int value="-1935055754" label="WebShare:enabled"/>
<int value="-1934661084" label="ForceUnifiedConsentBump:disabled"/>
<int value="-1933425042" label="OfflinePreviews:enabled"/>
@ -14649,7 +14648,6 @@ from previous Chrome versions.
<int value="219117936" label="AllowReaderForAccessibility:enabled"/>
<int value="219162425" label="TabClosureMethodRefactor:disabled"/>
<int value="219384037" label="ESimPolicy:disabled"/>
<int value="220182175" label="PipTuck:disabled"/>
<int value="220654375" label="SearchResultInlineIcon:disabled"/>
<int value="221212638" label="StartSurfaceAndroid:enabled"/>
<int value="221363150" label="ForceEnableFaceAe:disabled"/>