chromium/src
0
Fork 0
Code Activity

[prefs] Destroy delegate instance in InMemoryPrefStore::ReadPrefsAsync

Browse Source 
Fixed: 340440539
Change-Id: If12ee9001353c10d2231d0241e491ebf3120dc70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5533859
Reviewed-by: Gabriel Charette <gab@chromium.org>
Auto-Submit: Ankush Singh <ankushkush@google.com>
Commit-Queue: Ankush Singh <ankushkush@google.com>
Cr-Commit-Position: refs/heads/main@{#1301235}
This commit is contained in:
Ankush Singh
2024-05-15 12:51:17 +00:00
committed by Chromium LUCI CQ
parent ef15fd3331
commit b473d9060c
2 changed files with 5 additions and 1 deletions

4
components/prefs/in_memory_pref_store.cc

@ -81,6 +81,10 @@ PersistentPrefStore::PrefReadError InMemoryPrefStore::ReadPrefs() {
return PersistentPrefStore::PREF_READ_ERROR_NONE;
}
void InMemoryPrefStore::ReadPrefsAsync(ReadErrorDelegate* error_delegate) {
delete error_delegate;
}
void InMemoryPrefStore::ReportValueChanged(const std::string& key,
uint32_t flags) {
for (Observer& observer : observers_)

2
components/prefs/in_memory_pref_store.h

@ -49,7 +49,7 @@ class COMPONENTS_PREFS_EXPORT InMemoryPrefStore : public PersistentPrefStore {
bool ReadOnly() const override;
PrefReadError GetReadError() const override;
PersistentPrefStore::PrefReadError ReadPrefs() override;
void ReadPrefsAsync(ReadErrorDelegate* error_delegate) override {}
void ReadPrefsAsync(ReadErrorDelegate* error_delegate) override;
void SchedulePendingLossyWrites() override {}
void OnStoreDeletionFromDisk() override {}
bool IsInMemoryPrefStore() const override;