0

Get rid of base::Closure in shortcut_manager.cc

Context: https://docs.google.com/document/d/1J4N3V5UmzZL9BZGNrn95E4xJu4cz3ynbg21zXR-J_qA/edit#

Bug: 1007635
Change-Id: I1910c2ad1c47d00f069d6c70dbc7dc6e1ef2eedd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434929
Auto-Submit: Andrew Shulaev <ddrone@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#811459}
This commit is contained in:
Andrew Shulaev
2020-09-29 00:33:34 +00:00
committed by Commit Bot
parent 603380cab0
commit b4b3d367d2
2 changed files with 1 additions and 2 deletions
PRESUBMIT.py
chrome/browser/apps/platform_apps

@ -319,7 +319,6 @@ _NOT_CONVERTED_TO_MODERN_BIND_AND_CALLBACK = '|'.join((
'^base/callback.h', # Intentional.
'^chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc',
'^chrome/browser/apps/guest_view/',
'^chrome/browser/apps/platform_apps/shortcut_manager.cc',
'^chrome/browser/browsing_data/',
'^chrome/browser/captive_portal/captive_portal_browsertest.cc',
'^chrome/browser/chromeos/',

@ -129,7 +129,7 @@ void AppShortcutManager::OnExtensionWillBeInstalled(
// shortcut in the applications menu (e.g., Start Menu).
if (is_update) {
web_app::UpdateAllShortcuts(base::UTF8ToUTF16(old_name), profile_,
extension, base::Closure());
extension, base::OnceClosure());
} else {
CreateShortcutsForApp(profile_, extension);
}