chromium/src
0
Fork 0
Code Activity

Remove obsolete OutputController timing histograms.

Browse Source 
Fixed: 1088905
Change-Id: I2ac06cd576f72cbb3b3ea04987902c8d9e307093
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240025
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777338}
This commit is contained in:
Dale Curtis
2020-06-11 14:14:41 +00:00
committed by Commit Bot
parent 62369b5ea3
commit b4c79a77a6
2 changed files with 6 additions and 5 deletions
services/audio
output_controller.cc
tools/metrics/histograms
histograms.xml

5
services/audio/output_controller.cc

@ -183,7 +183,6 @@ bool OutputController::CreateStream() {
void OutputController::RecreateStreamWithTimingUMA(
OutputController::RecreateReason reason) {
SCOPED_UMA_HISTOGRAM_TIMER("Media.AudioOutputController.CreateTime");
RecreateStream(reason);
}
@ -300,7 +299,6 @@ void OutputController::RecreateStream(OutputController::RecreateReason reason) {
void OutputController::Play() {
DCHECK(task_runner_->BelongsToCurrentThread());
SCOPED_UMA_HISTOGRAM_TIMER("Media.AudioOutputController.PlayTime");
TRACE_EVENT0("audio", "OutputController::Play");
SendLogMessage("%s([state=%s])", __func__, StateToString(state_));
@ -347,7 +345,6 @@ void OutputController::StopStream() {
void OutputController::Pause() {
DCHECK(task_runner_->BelongsToCurrentThread());
SCOPED_UMA_HISTOGRAM_TIMER("Media.AudioOutputController.PauseTime");
TRACE_EVENT0("audio", "OutputController::Pause");
SendLogMessage("%s([state=%s])", __func__, StateToString(state_));
@ -384,7 +381,6 @@ void OutputController::Flush() {
void OutputController::Close() {
DCHECK(task_runner_->BelongsToCurrentThread());
TRACE_EVENT0("audio", "OutputController::Close");
SCOPED_UMA_HISTOGRAM_TIMER("Media.AudioOutputController.CloseTime");
SendLogMessage("%s([state=%s])", __func__, StateToString(state_));
if (state_ != kClosed) {
@ -612,7 +608,6 @@ void OutputController::OnDeviceChange() {
if (disable_local_output_)
return; // No actions need to be taken while local output is disabled.
SCOPED_UMA_HISTOGRAM_TIMER("Media.AudioOutputController.DeviceChangeTime");
SendLogMessage("%s([state=%s])", __func__, StateToString(state_));
// TODO(dalecurtis): Notify the renderer side that a device change has

6
tools/metrics/histograms/histograms.xml

@ -75541,6 +75541,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram>
<histogram name="Media.AudioOutputController" units="ms" expires_after="M85">
<obsolete>
Removed 06/2020. No longer needed.
</obsolete>
<owner>dalecurtis@chromium.org</owner>
<summary>Measures the time taken for AudioOutputController::</summary>
</histogram>
@ -199993,6 +199996,9 @@ regressions. -->
</histogram_suffixes>
<histogram_suffixes name="MediaAudioOutputControllerTime" separator=".">
<obsolete>
Removed 06/2020. No longer needed.
</obsolete>
<suffix name="CloseTime" label="Measures the time taken for DoClose()."/>
<suffix name="CreateTime" label="Measures the time taken for DoCreate()."/>
<suffix name="DeviceChangeTime"