chromium/src
0
Fork 0
Code Activity

[Doc] Add reminder to test edge cases to commit_checklist.md

Browse Source 
Under step  for manual testing. The developer doesn't have to test
these edge cases every time, but this bullet is a useful reminder to
think about what unexpected situations could break your code.

Bug: 1142952
Change-Id: Ie5cf5878bc555582e7ea0f8bdf425872b01e834f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506066
Reviewed-by: Zork <zork@chromium.org>
Commit-Queue: Zork <zork@chromium.org>
Auto-Submit: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822279}
This commit is contained in:
Toby Huang
2020-10-29 18:38:02 +00:00
committed by Commit Bot
parent 3a29113fc7
commit b54e133214
1 changed files with 8 additions and 0 deletions

8
docs/commit_checklist.md

@ -78,6 +78,14 @@ changes to a test device. If you're testing Chrome for ChromeOS, follow the
[Simple Chrome][simple-chrome] instructions to deploy your changes to a test
device. Make sure you hit every code path you changed.
Think about testing any edge cases that could break your code. Some common edge
cases to consider:
* Guest mode
* Enterprise/EDU/Supervised users
* Accessibility
* Official Chrome-branded build (for Googlers)
## 6. Write unit or browser tests for any new code
Consider automating any manual testing you did in the previous step.