chromium/src
0
Fork 0
Code Activity

[gn check] Enable //chrome/test:interactive_ui_tests

Browse Source 
The changes are straightforward.

Bug: 1158929
Change-Id: Ic952c62fce1ce9fa34093c23561b67b90f567aef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2919814
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#887980}
This commit is contained in:
Colin Blundell
2021-06-01 15:36:33 +00:00
committed by Chromium LUCI CQ
parent 0bbf12c1e6
commit b7eadc483c
4 changed files with 60 additions and 3 deletions

1
.gn

@ -63,7 +63,6 @@ default_args = {
# their includes checked for proper dependencies when you run either
# "gn check" or "gn gen --check".
no_check_targets = [
"//chrome/test:interactive_ui_tests",
"//chrome/test:unit_tests",
"//chrome/test:unit_tests__library",
"//extensions/browser:*", # 20 errors

1
ash/BUILD.gn

@ -2636,6 +2636,7 @@ static_library("test_support") {
"//chrome/test:browser_tests",
"//chrome/test:browser_tests_runner",
"//chrome/test:captured_sites_interactive_tests",
"//chrome/test:interactive_ui_tests",
"//chrome/test:test_support",
"//chrome/test:test_support_ui",
"//chrome/test:test_support_unit",

2
chrome/browser/ui/hung_renderer/hung_renderer_interactive_uitest.cc

@ -9,7 +9,7 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tab_dialogs.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/test/test_browser_dialog.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/interactive_test_utils.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/browser/render_view_host.h"

59
chrome/test/BUILD.gn

@ -7231,6 +7231,7 @@ if (!is_android) {
"../browser/extensions/extension_crash_recovery_browsertest.cc",
"../browser/extensions/extension_fullscreen_apitest.cc",
"../browser/extensions/extension_function_test_utils.cc",
"../browser/extensions/extension_function_test_utils.h",
"../browser/extensions/extension_keybinding_apitest.cc",
"../browser/extensions/omnibox_focus_interactive_test.cc",
"../browser/extensions/window_open_interactive_apitest.cc",
@ -7333,23 +7334,51 @@ if (!is_android) {
"//chrome:packed_resources",
"//chrome:resources",
"//chrome:strings",
"//chrome/app:command_ids",
"//chrome/browser",
"//chrome/browser:unexpire_flags",
"//chrome/browser/devtools",
"//chrome/browser/devtools:test_support",
"//chrome/browser/resource_coordinator:tab_metrics_event_proto",
"//chrome/browser/resource_coordinator/tab_ranker",
"//chrome/browser/web_applications:web_applications_test_support",
"//chrome/common:version_header",
"//chrome/renderer",
"//components/back_forward_cache",
"//components/blocked_content",
"//components/bookmarks/browser",
"//components/bookmarks/common",
"//components/constrained_window",
"//components/content_settings/browser",
"//components/embedder_support",
"//components/enterprise:test_support",
"//components/feature_engagement/public",
"//components/feature_engagement/test:test_support",
"//components/flags_ui",
"//components/fullscreen_control",
"//components/infobars/content",
"//components/javascript_dialogs",
"//components/keep_alive_registry",
"//components/live_caption",
"//components/media_message_center",
"//components/media_router/browser:test_support",
"//components/metrics:content",
"//components/reading_list/core",
"//components/reading_list/features:flags",
"//components/renderer_context_menu",
"//components/resources",
"//components/security_interstitials/content:security_interstitial_page",
"//components/shared_highlighting/core/common",
"//components/site_engagement/content",
"//components/soda:constants",
"//components/sync",
"//components/sync:test_support_model",
"//components/tab_groups",
"//components/translate/content/browser:test_support",
"//components/ukm:test_support",
"//components/ukm:ukm_test_helper",
"//content/app/resources",
"//content/test:browsertest_support",
"//content/test:test_support",
"//crypto:platform",
"//crypto:test_support",
@ -7360,6 +7389,7 @@ if (!is_android) {
"//net",
"//net:net_resources",
"//net:test_support",
"//ppapi/shared_impl:test_support",
"//services/metrics/public/cpp:ukm_builders",
"//skia",
"//testing/gmock",
@ -7370,7 +7400,12 @@ if (!is_android) {
"//ui/base:base_interactive_ui_tests",
"//ui/base:test_support",
"//ui/base/clipboard:clipboard_test_support",
"//ui/display:display_manager_test_api",
"//ui/display:test_support",
"//ui/display/manager",
"//ui/events:events_interactive_ui_tests",
"//ui/events:gesture_detection",
"//ui/events:test_support",
"//ui/web_dialogs:test_support",
]
@ -7393,6 +7428,14 @@ if (!is_android) {
data_deps += [ "//chrome:packed_resources" ]
}
if (is_linux || is_chromeos) {
deps += [ "//ui/platform_window/common" ]
}
if (use_ozone) {
deps += [ "//ui/ozone" ]
}
if (use_aura) {
sources += [
"../browser/ui/aura/accessibility/automation_manager_aura_browsertest.cc",
@ -7400,6 +7443,7 @@ if (!is_android) {
]
deps += [
"//ui/aura:aura_interactive_ui_tests",
"//ui/aura:test_support",
"//ui/base/dragdrop:types",
"//ui/base/dragdrop/mojom",
]
@ -7510,6 +7554,7 @@ if (!is_android) {
"//chrome/browser/chromeos:test_support",
"//chrome/browser/media/router:test_support",
"//chromeos/dbus",
"//chromeos/login/auth",
"//chromeos/ui/frame:test_support",
]
sources += [
@ -7527,10 +7572,16 @@ if (!is_android) {
]
}
# These tests are not applicable on Chrome OS - Ash and Lacros.
if (is_chromeos_ash || is_chromeos_lacros) {
# These tests are not applicable on Chrome OS - Ash and Lacros.
sources -=
[ "../browser/ui/signin_view_controller_interactive_uitest.cc" ]
deps += [
"//chromeos/ui/base",
"//chromeos/ui/frame",
"//chromeos/ui/frame:test_support",
]
}
if (is_chromeos_lacros) {
@ -7605,6 +7656,12 @@ if (!is_android) {
"//chrome",
"//chrome:chrome_framework",
]
deps += [
"//chrome/browser/apps/app_shim",
"//chrome/browser/web_applications/extensions",
"//components/spellcheck:buildflags",
]
}
if (enable_downgrade_processing) {