Get rid of ViewMsg_MoveOrResizeStarted message.

This message which is only sent on windows and ash. Looking back on the
history (http://crrev.com/30f75e61) when this message was added it was
intended to hide auto complete popups. Being that we dismiss select
popups on focus changes and size changes I believe this method is not
needed anymore.

BUG=1051648

Change-Id: I463da85c9916c2140e4093447df1aacefc75b9c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493282
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821841}

chrome/browser/ui/views/frame/browser_view.cc

@@ -2638,9 +2638,6 @@ void BrowserView::OnWindowBeginUserBoundsChange() {
   if (!web_contents)
     return;
   interactive_resize_in_progress_ = true;
-  web_contents->GetMainFrame()
-      ->GetRenderViewHost()
-      ->NotifyMoveOrResizeStarted();
 }
 
 void BrowserView::OnWindowEndUserBoundsChange() {

content/browser/renderer_host/render_message_filter.cc

@@ -77,7 +77,7 @@
 namespace content {
 namespace {
 
-const uint32_t kRenderFilteredMessageClasses[] = {ViewMsgStart};
+const uint32_t kRenderFilteredMessageClasses[] = {FrameMsgStart};
 
 }  // namespace
 

content/browser/renderer_host/render_view_host_impl.cc

@@ -59,7 +59,6 @@
 #include "content/common/page_messages.h"
 #include "content/common/render_message_filter.mojom.h"
 #include "content/common/renderer.mojom.h"
-#include "content/common/view_messages.h"
 #include "content/public/browser/ax_event_notification_details.h"
 #include "content/public/browser/browser_accessibility_state.h"
 #include "content/public/browser/browser_context.h"
@@ -851,10 +850,6 @@ void RenderViewHostImpl::ExecutePluginActionAtLocation(
       ->PluginActionAt(local_location, plugin_action);
 }
 
-void RenderViewHostImpl::NotifyMoveOrResizeStarted() {
-  Send(new ViewMsg_MoveOrResizeStarted(GetRoutingID()));
-}
-
 void RenderViewHostImpl::PostRenderViewReady() {
   GetProcess()->PostTaskWhenProcessIsReady(base::BindOnce(
       &RenderViewHostImpl::RenderViewReady, weak_factory_.GetWeakPtr()));

content/browser/renderer_host/render_view_host_impl.h

@@ -131,7 +131,6 @@ class CONTENT_EXPORT RenderViewHostImpl
   RenderViewHostDelegate* GetDelegate() override;
   SiteInstanceImpl* GetSiteInstance() override;
   bool IsRenderViewLive() override;
-  void NotifyMoveOrResizeStarted() override;
 
   void SendWebPreferencesToRenderer();
   void SendRendererPreferencesToRenderer(

content/common/BUILD.gn

@@ -154,7 +154,6 @@ source_set("common") {
     "url_schemes.cc",
     "url_schemes.h",
     "user_agent.cc",
-    "view_messages.h",
     "web_package/signed_exchange_utils.cc",
     "web_package/signed_exchange_utils.h",
   ]
@@ -583,14 +582,13 @@ mojom("mojo_bindings") {
       traits_private_headers = [
         "//content/common/frame_messages.h",
         "//content/common/input_messages.h",
-        "//content/common/view_messages.h",
         "//content/public/common/common_param_traits.h",
         "//services/network/public/cpp/p2p_param_traits.h",
       ]
 
       traits_public_deps = [
         # NOTE: These dependencies are here to satisfy gn check because
-        # common_param_traits_macros.h and/or view_messages.h include their headers.
+        # common_param_traits_macros.h include their headers.
         # Although the mojo bindings target is configured to allow direct circular
         # includes from //content/common and //content/public/common, this isn't a
         # transitive allowance, so those targets' own public_deps aren't included in
@@ -705,7 +703,6 @@ mojom("mojo_bindings") {
         ]
         traits_headers =
             [ "//third_party/blink/public/platform/mac/web_scrollbar_theme.h" ]
-        traits_private_headers = [ "//content/common/view_messages.h" ]
         traits_public_deps = [ "//third_party/blink/public:blink_headers" ]
       },
     ]

content/common/content_message_generator.h

@@ -36,11 +36,6 @@
 #ifndef CONTENT_COMMON_UNFREEZABLE_FRAME_MESSAGES_H_
 #error "Failed to include content/common/unfreezable_frame_messages.h"
 #endif
-#undef CONTENT_COMMON_VIEW_MESSAGES_H_
-#include "content/common/view_messages.h"
-#ifndef CONTENT_COMMON_VIEW_MESSAGES_H_
-#error "Failed to include content/common/view_messages.h"
-#endif
 #include "media/media_buildflags.h"
 
 #if defined(OS_ANDROID)

content/common/view_messages.h

@@ -1,31 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CONTENT_COMMON_VIEW_MESSAGES_H_
-#define CONTENT_COMMON_VIEW_MESSAGES_H_
-
-// IPC messages for page rendering.
-
-#include "ipc/ipc_message_macros.h"
-
-
-#undef IPC_MESSAGE_EXPORT
-#define IPC_MESSAGE_EXPORT CONTENT_EXPORT
-
-#define IPC_MESSAGE_START ViewMsgStart
-
-// Messages sent from the browser to the renderer.
-
-// Notification that a move or resize renderer's containing window has
-// started.
-IPC_MESSAGE_ROUTED0(ViewMsg_MoveOrResizeStarted)
-
-// -----------------------------------------------------------------------------
-// Messages sent from the renderer to the browser.
-
-// Adding a new message? Stick to the sort order above: first platform
-// independent ViewMsg, then ifdefs for platform specific ViewMsg, then platform
-// independent ViewHostMsg, then ifdefs for platform specific ViewHostMsg.
-
-#endif  // CONTENT_COMMON_VIEW_MESSAGES_H_

content/public/browser/render_view_host.h

@@ -91,10 +91,6 @@ class CONTENT_EXPORT RenderViewHost : public IPC::Sender {
   // Returns true if the RenderView is active and has not crashed.
   virtual bool IsRenderViewLive() = 0;
 
-  // Notification that a move or resize renderer's containing window has
-  // started.
-  virtual void NotifyMoveOrResizeStarted() = 0;
-
  private:
   // This interface should only be implemented inside content.
   friend class RenderViewHostImpl;

content/renderer/render_view_impl.cc

@@ -13,7 +13,6 @@
 #include "base/strings/string_piece.h"
 #include "content/child/webthemeengine_impl_default.h"
 #include "content/common/page_messages.h"
-#include "content/common/view_messages.h"
 #include "content/public/common/content_client.h"
 #include "content/public/common/content_constants.h"
 #include "content/public/common/content_features.h"
@@ -345,8 +344,6 @@ bool RenderViewImpl::OnMessageReceived(const IPC::Message& message) {
 
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(RenderViewImpl, message)
-    IPC_MESSAGE_HANDLER(ViewMsg_MoveOrResizeStarted, OnMoveOrResizeStarted)
-
     // Page messages.
     IPC_MESSAGE_HANDLER(PageMsg_SetHistoryOffsetAndLength,
                         OnSetHistoryOffsetAndLength)
@@ -742,11 +739,6 @@ void RenderViewImpl::DidUpdateRendererPreferences() {
 #endif
 }
 
-void RenderViewImpl::OnMoveOrResizeStarted() {
-  if (GetWebView())
-    GetWebView()->CancelPagePopup();
-}
-
 #if defined(OS_ANDROID)
 void RenderViewImpl::SuspendVideoCaptureDevices(bool suspend) {
   if (!main_render_frame_)

content/renderer/render_view_impl.h

@@ -323,8 +323,6 @@ class CONTENT_EXPORT RenderViewImpl : public blink::WebViewClient,
   static WindowOpenDisposition NavigationPolicyToDisposition(
       blink::WebNavigationPolicy policy);
 
-  void OnMoveOrResizeStarted();
-
   // Misc private functions ----------------------------------------------------
 
 #if defined(OS_ANDROID)

ipc/ipc_message_start.h

@@ -15,7 +15,6 @@ enum IPCMessageStart {
   AutomationMsgStart = 0,
   FrameMsgStart,
   PageMsgStart,
-  ViewMsgStart,
   TestMsgStart,
   WorkerMsgStart,
   NaClMsgStart,
@@ -23,7 +22,6 @@ enum IPCMessageStart {
   MediaMsgStart,
   PpapiMsgStart,
   ChromeMsgStart,
-  DragMsgStart,
   PrintMsgStart,
   ExtensionMsgStart,
   ChromotingMsgStart,

ipc/trace_ipc_message.cc

@@ -28,9 +28,6 @@ void WriteIpcMessageIdAsProtozero(uint32_t message_id,
     case PageMsgStart:
       message_class = ChromeLegacyIpc::CLASS_PAGE;
       break;
-    case ViewMsgStart:
-      message_class = ChromeLegacyIpc::CLASS_VIEW;
-      break;
     case TestMsgStart:
       message_class = ChromeLegacyIpc::CLASS_TEST;
       break;
@@ -52,9 +49,6 @@ void WriteIpcMessageIdAsProtozero(uint32_t message_id,
     case ChromeMsgStart:
       message_class = ChromeLegacyIpc::CLASS_CHROME;
       break;
-    case DragMsgStart:
-      message_class = ChromeLegacyIpc::CLASS_DRAG;
-      break;
     case PrintMsgStart:
       message_class = ChromeLegacyIpc::CLASS_PRINT;
       break;