0

[VC Camera Effects] Background blur can only be off/light/full

Constrain the set of user-settable background blur states to off,
light, and full (AKA "maximum").

Screenshot:

https://screenshot.googleplex.com/RD9FNcw8upR9GUU

Bug: b/265165832
Change-Id: I40e680f6e7bd2d3af3b257e86a4e36b97646bdcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4163921
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Andre Le <leandre@chromium.org>
Commit-Queue: Roger Tinkoff <rtinkoff@google.com>
Cr-Commit-Position: refs/heads/main@{#1092809}
This commit is contained in:
Roger Tinkoff
2023-01-14 22:27:58 +00:00
committed by Chromium LUCI CQ
parent c3a0d26ab7
commit b966f8180e
3 changed files with 5 additions and 13 deletions

@ -1481,6 +1481,9 @@ Style notes:
<message name="IDS_ASH_VIDEO_CONFERENCE_BUBBLE_BACKGROUND_BLUR_MAXIMUM" desc="Text for background blur 'maximum' setting, in the VC bubble.">
Maximum
</message>
<message name="IDS_ASH_VIDEO_CONFERENCE_BUBBLE_BACKGROUND_BLUR_FULL" desc="Text 'full' is a synonym of the background blur 'maximum' setting, in the VC bubble.">
Full
</message>
<message name="IDS_ASH_VIDEO_CONFERENCE_BUBBLE_PORTRAIT_RELIGHT_NAME" desc="Text for name of the portrait relight effect in the VC bubble.">
Portrait Relighting
</message>

@ -0,0 +1 @@
d4805f3057a87ffe2703e24d64f57632048e45d1

@ -515,27 +515,15 @@ void CameraEffectsController::InitializeEffectControls() {
effect.get(),
/*state_value=*/BackgroundBlurEffectState::kOff,
/*string_id=*/IDS_ASH_VIDEO_CONFERENCE_BUBBLE_BACKGROUND_BLUR_OFF);
AddBackgroundBlurStateToEffect(
effect.get(),
/*state_value=*/BackgroundBlurEffectState::kLowest,
/*string_id=*/IDS_ASH_VIDEO_CONFERENCE_BUBBLE_BACKGROUND_BLUR_LOWEST);
AddBackgroundBlurStateToEffect(
effect.get(),
/*state_value=*/BackgroundBlurEffectState::kLight,
/*string_id=*/IDS_ASH_VIDEO_CONFERENCE_BUBBLE_BACKGROUND_BLUR_LIGHT);
AddBackgroundBlurStateToEffect(
effect.get(),
/*state_value=*/BackgroundBlurEffectState::kMedium,
/*string_id=*/IDS_ASH_VIDEO_CONFERENCE_BUBBLE_BACKGROUND_BLUR_MEDIUM);
AddBackgroundBlurStateToEffect(
effect.get(),
/*state_value=*/BackgroundBlurEffectState::kHeavy,
/*string_id=*/IDS_ASH_VIDEO_CONFERENCE_BUBBLE_BACKGROUND_BLUR_HEAVY);
AddBackgroundBlurStateToEffect(
effect.get(),
/*state_value=*/BackgroundBlurEffectState::kMaximum,
/*string_id=*/
IDS_ASH_VIDEO_CONFERENCE_BUBBLE_BACKGROUND_BLUR_MAXIMUM);
IDS_ASH_VIDEO_CONFERENCE_BUBBLE_BACKGROUND_BLUR_FULL);
AddEffect(std::move(effect));
}