chromium/src
0
Fork 0
Code Activity

[media] Mark ScopedAudioInputStream::stream_ as DanglingUntriaged

Browse Source 
... per https://chromium.googlesource.com/chromium/src/+/main/docs/dangling_ptr_guide.md#i-don_t-own-the-affected-component

  `AudioInputStreamDataInterceptor::Close()` causes
  `ScopedAudioInputStream::stream_` to dangle immediately. Replacing
  `AudioInputStreamDataInterceptor`'s management of its own memory with
  smart pointers is likely to take some time.

Bug: 377749732
Change-Id: Ib50a6386e9a5cdf861084429f75750066f4b0168
Cq-Include-Trybots: luci.chromium.try:win-arm64-rel
DanglingUntriaged-notes: The use of `delete this` in
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6001075
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Commit-Queue: Jonathan Lee <jonathanjlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1379763}
This commit is contained in:
Jonathan Lee
2024-11-07 17:11:10 +00:00
committed by Chromium LUCI CQ
parent e38fc88b52
commit b9712601a3
1 changed files with 3 additions and 1 deletions

4
media/audio/win/audio_low_latency_input_win_unittest.cc

@ -271,7 +271,9 @@ class ScopedAudioInputStream {
}
private:
raw_ptr<AudioInputStream> stream_;
// TODO(crbug.com/377749732): Fix dangling pointer when used with
// `AudioInputStreamDataInterceptor`.
raw_ptr<AudioInputStream, DanglingUntriaged> stream_;
};
class WinAudioInputTest : public ::testing::Test,