chromium/src
0
Fork 0
Code Activity

Add surface_frame_trace_id and display_trace_id to PipelineReporter

Browse Source 
This is a follow-up change for https://crrev.com/c/6208011 which will
allow us to join EventLatency and PipelineReporter events.

The source of truth for the definition of the ChromeFrameReporter proto
message lives in the Perfetto repository (unlike ChromeTrackEvent) so
this change needs to be made across both repositories.

Perfetto change (needs to land first): https://r.android.com/3474330

Bug: b:394060351
Change-Id: Ic7437081615fe31a8cb4b5816a02059d6fe934dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6226043
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Petr Cermak <petrcermak@chromium.org>
Auto-Submit: Petr Cermak <petrcermak@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1416148}
This commit is contained in:
Petr Cermak
2025-02-05 07:38:23 -08:00
committed by Chromium LUCI CQ
parent bebbbca598
commit ba4856c1f1
2 changed files with 9 additions and 2 deletions

7
cc/metrics/compositor_frame_reporter.cc

@ -1545,6 +1545,13 @@ void CompositorFrameReporter::ReportCompositorLatencyTraceEvents(
reporter->add_high_latency_contribution_stage(stage);
}
reporter->set_surface_frame_trace_id(args_.trace_id);
const std::optional<int64_t>& display_trace_id =
viz_breakdown_.presentation_feedback.display_trace_id;
if (display_trace_id) {
reporter->set_display_trace_id(*display_trace_id);
}
// TODO(crbug.com/40132773): Set 'drop reason' if applicable.
});

4
services/tracing/perfetto/privacy_filtered_fields-inl.h

@ -155,8 +155,8 @@ constexpr MessageInfo kChromeHistogramSample = {kChromeHistogramSampleIndices,
nullptr};
// Proto Message: ChromeFrameReporter
constexpr int kChromeFrameReporterIndices[] = {1, 2, 3, 4, 5, 6,
7, 8, 9, 10, 11, -1};
constexpr int kChromeFrameReporterIndices[] = {1, 2, 3, 4, 5, 6, 7,
8, 9, 10, 11, 17, 18, -1};
constexpr MessageInfo kChromeFrameReporter = {kChromeFrameReporterIndices,
nullptr};