chromium/src
0
Fork 0
Code Activity

Use SharedImage usage for is_overlay_candidate in webxr drawing buffer

Browse Source 
In preparation to remove the field. It's no op, because:
* SharedImage is never created with SCANOUT [1]
* Image is used only as source for CopySubTexture via gles [2]

[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/gpu/xr_webgl_drawing_buffer.cc;drc=27d34700b83f381c62e3a348de2e6dfdc08364b8;l=501
[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/gpu/xr_frame_transport.cc;drc=27d34700b83f381c62e3a348de2e6dfdc08364b8;l=170

Bug: 390568190
Change-Id: I95daae61388fa8e3ec4634cfe239407b74f437b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6187730
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1409673}
This commit is contained in:
Vasiliy Telezhnikov
2025-01-22 07:48:12 -08:00
committed by Chromium LUCI CQ
parent 2e05216b02
commit bad543cb98
1 changed files with 2 additions and 2 deletions

4
third_party/blink/renderer/platform/graphics/gpu/xr_webgl_drawing_buffer.cc vendored

@ -662,8 +662,8 @@ XRWebGLDrawingBuffer::TransferToStaticBitmapImage() {
ThreadScheduler::Current()->CleanupTaskRunner(),
std::move(release_callback),
/*supports_display_compositing=*/true,
// CreateColorBuffer() never sets the SCANOUT usage bit.
/*is_overlay_candidate=*/false);
/*is_overlay_candidate=*/
buffer->shared_image->usage().Has(gpu::SHARED_IMAGE_USAGE_SCANOUT));
}
// static