0

Revert "Add webui_resources_tools_python_unittests."

This reverts commit 782dbb8052.

Reason for revert: newly added tests are failing: crbug.com/398286661

Original change's description:
> Add webui_resources_tools_python_unittests.
>
> This adds a new test step/binary called
> webui_resources_tools_python_unittests that runs the python unit tests
> in //ui/webui/resources/tools.
>
> No-Try: true
> Bug: 378504039
> Change-Id: I8f7d1c34cf8a66a30f24d4295565a1596f7d4338
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6277637
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Cr-Commit-Position: refs/heads/main@{#1423226}

Bug: 378504039, 398286661
Change-Id: Ida93c848800ec243cbe3dc38a3075691be8937e0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6292926
Auto-Submit: Muyao Xu <muyaoxu@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Muyao Xu <muyaoxu@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Muyao Xu <muyaoxu@google.com>
Cr-Commit-Position: refs/heads/main@{#1423416}
This commit is contained in:
Muyao Xu
2025-02-21 14:15:11 -08:00
committed by Chromium LUCI CQ
parent 8b5ddccbf9
commit bafb2bdc07
30 changed files with 0 additions and 393 deletions
BUILD.gn
infra/config
generated
builders
build
Mac Builder Siso FYI
Mac Tests Siso FYI
ci
Linux Builder
Linux Tests
Mac Builder
Mac13 Tests
Win x64 Builder
Win10 Tests x64
linux-win-cross-rel
win-arm64-rel
win11-arm64-rel-tests
try
linux-dcheck-off-rel
linux-full-remote-rel
linux-rel-test-selection
linux-rel
linux-win-cross-rel
linux_chromium_compile_rel_ng
mac13-tests
mac_chromium_compile_rel_ng
win-arm64-rel
win-rel
testing
targets
testing/scripts
tools/code_cache_generator
ui/webui/resources/tools

@ -168,7 +168,6 @@ group("gn_all") {
"//tools/polymer:polymer_tools_python_unittests",
"//tools/privacy_budget:privacy_budget_tools",
"//ui/accessibility/extensions:extensions",
"//ui/webui/resources/tools:webui_resources_tools_python_unittests",
]
}

@ -1738,22 +1738,6 @@
"test": "views_perftests",
"test_id_prefix": "ninja://ui/views:views_perftests/"
},
{
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "webui_resources_tools_python_unittests",
"swarming": {
"dimensions": {
"cpu": "x86-64",
"os": "Mac-14"
},
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test": "webui_resources_tools_python_unittests",
"test_id_prefix": "ninja://ui/webui/resources/tools:webui_resources_tools_python_unittests/"
},
{
"isolate_profile_data": true,
"merge": {

@ -1716,22 +1716,6 @@
"test": "views_perftests",
"test_id_prefix": "ninja://ui/views:views_perftests/"
},
{
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "webui_resources_tools_python_unittests",
"swarming": {
"dimensions": {
"cpu": "x86-64",
"os": "Mac-14"
},
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test": "webui_resources_tools_python_unittests",
"test_id_prefix": "ninja://ui/webui/resources/tools:webui_resources_tools_python_unittests/"
},
{
"isolate_profile_data": true,
"merge": {

@ -2101,21 +2101,6 @@
"test": "blink_web_tests",
"test_id_prefix": "ninja://:blink_web_tests/"
},
{
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "webui_resources_tools_python_unittests",
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
},
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test": "webui_resources_tools_python_unittests",
"test_id_prefix": "ninja://ui/webui/resources/tools:webui_resources_tools_python_unittests/"
},
{
"isolate_profile_data": true,
"merge": {

@ -2070,21 +2070,6 @@
"test": "blink_web_tests",
"test_id_prefix": "ninja://:blink_web_tests/"
},
{
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "webui_resources_tools_python_unittests",
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
},
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test": "webui_resources_tools_python_unittests",
"test_id_prefix": "ninja://ui/webui/resources/tools:webui_resources_tools_python_unittests/"
},
{
"isolate_profile_data": true,
"merge": {

@ -5140,22 +5140,6 @@
"test": "views_perftests",
"test_id_prefix": "ninja://ui/views:views_perftests/"
},
{
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "webui_resources_tools_python_unittests",
"swarming": {
"dimensions": {
"cpu": "x86-64",
"os": "Mac-13"
},
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test": "webui_resources_tools_python_unittests",
"test_id_prefix": "ninja://ui/webui/resources/tools:webui_resources_tools_python_unittests/"
},
{
"isolate_profile_data": true,
"merge": {

@ -1717,22 +1717,6 @@
"test": "views_perftests",
"test_id_prefix": "ninja://ui/views:views_perftests/"
},
{
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "webui_resources_tools_python_unittests",
"swarming": {
"dimensions": {
"cpu": "x86-64",
"os": "Mac-13"
},
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test": "webui_resources_tools_python_unittests",
"test_id_prefix": "ninja://ui/webui/resources/tools:webui_resources_tools_python_unittests/"
},
{
"isolate_profile_data": true,
"merge": {

@ -2138,22 +2138,6 @@
"test": "views_perftests",
"test_id_prefix": "ninja://ui/views:views_perftests/"
},
{
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "webui_resources_tools_python_unittests",
"swarming": {
"dimensions": {
"cpu": "x86-64",
"os": "Windows-10-19045"
},
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test": "webui_resources_tools_python_unittests",
"test_id_prefix": "ninja://ui/webui/resources/tools:webui_resources_tools_python_unittests/"
},
{
"isolate_profile_data": true,
"merge": {

@ -2115,22 +2115,6 @@
"test": "views_perftests",
"test_id_prefix": "ninja://ui/views:views_perftests/"
},
{
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "webui_resources_tools_python_unittests",
"swarming": {
"dimensions": {
"cpu": "x86-64",
"os": "Windows-10-19045"
},
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test": "webui_resources_tools_python_unittests",
"test_id_prefix": "ninja://ui/webui/resources/tools:webui_resources_tools_python_unittests/"
},
{
"isolate_profile_data": true,
"merge": {

@ -1862,21 +1862,6 @@
"test": "views_perftests",
"test_id_prefix": "ninja://ui/views:views_perftests/"
},
{
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "webui_resources_tools_python_unittests",
"swarming": {
"dimensions": {
"cpu": "x86-64",
"os": "Windows-10-19045"
},
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test": "webui_resources_tools_python_unittests",
"test_id_prefix": "ninja://ui/webui/resources/tools:webui_resources_tools_python_unittests/"
},
{
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"

@ -2094,23 +2094,6 @@
"test": "views_perftests",
"test_id_prefix": "ninja://ui/views:views_perftests/"
},
{
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "webui_resources_tools_python_unittests",
"swarming": {
"dimensions": {
"cpu": "arm64",
"os": "Windows-11",
"screen_scaling_percent": "100"
},
"expiration": 7200,
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test": "webui_resources_tools_python_unittests",
"test_id_prefix": "ninja://ui/webui/resources/tools:webui_resources_tools_python_unittests/"
},
{
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"

@ -2088,23 +2088,6 @@
"test": "views_perftests",
"test_id_prefix": "ninja://ui/views:views_perftests/"
},
{
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "webui_resources_tools_python_unittests",
"swarming": {
"dimensions": {
"cpu": "arm64",
"os": "Windows-11",
"screen_scaling_percent": "100"
},
"expiration": 7200,
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test": "webui_resources_tools_python_unittests",
"test_id_prefix": "ninja://ui/webui/resources/tools:webui_resources_tools_python_unittests/"
},
{
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"

@ -2101,21 +2101,6 @@
"test": "blink_web_tests",
"test_id_prefix": "ninja://:blink_web_tests/"
},
{
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "webui_resources_tools_python_unittests",
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
},
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test": "webui_resources_tools_python_unittests",
"test_id_prefix": "ninja://ui/webui/resources/tools:webui_resources_tools_python_unittests/"
},
{
"isolate_profile_data": true,
"merge": {

@ -2101,21 +2101,6 @@
"test": "blink_web_tests",
"test_id_prefix": "ninja://:blink_web_tests/"
},
{
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "webui_resources_tools_python_unittests",
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
},
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test": "webui_resources_tools_python_unittests",
"test_id_prefix": "ninja://ui/webui/resources/tools:webui_resources_tools_python_unittests/"
},
{
"isolate_profile_data": true,
"merge": {

@ -2101,21 +2101,6 @@
"test": "blink_web_tests",
"test_id_prefix": "ninja://:blink_web_tests/"
},
{
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "webui_resources_tools_python_unittests",
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
},
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test": "webui_resources_tools_python_unittests",
"test_id_prefix": "ninja://ui/webui/resources/tools:webui_resources_tools_python_unittests/"
},
{
"isolate_profile_data": true,
"merge": {

@ -2101,21 +2101,6 @@
"test": "blink_web_tests",
"test_id_prefix": "ninja://:blink_web_tests/"
},
{
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "webui_resources_tools_python_unittests",
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
},
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test": "webui_resources_tools_python_unittests",
"test_id_prefix": "ninja://ui/webui/resources/tools:webui_resources_tools_python_unittests/"
},
{
"isolate_profile_data": true,
"merge": {

@ -1862,21 +1862,6 @@
"test": "views_perftests",
"test_id_prefix": "ninja://ui/views:views_perftests/"
},
{
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "webui_resources_tools_python_unittests",
"swarming": {
"dimensions": {
"cpu": "x86-64",
"os": "Windows-10-19045"
},
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test": "webui_resources_tools_python_unittests",
"test_id_prefix": "ninja://ui/webui/resources/tools:webui_resources_tools_python_unittests/"
},
{
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"

@ -2101,21 +2101,6 @@
"test": "blink_web_tests",
"test_id_prefix": "ninja://:blink_web_tests/"
},
{
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "webui_resources_tools_python_unittests",
"swarming": {
"dimensions": {
"os": "Ubuntu-22.04"
},
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test": "webui_resources_tools_python_unittests",
"test_id_prefix": "ninja://ui/webui/resources/tools:webui_resources_tools_python_unittests/"
},
{
"isolate_profile_data": true,
"merge": {

@ -1739,22 +1739,6 @@
"test": "views_perftests",
"test_id_prefix": "ninja://ui/views:views_perftests/"
},
{
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "webui_resources_tools_python_unittests",
"swarming": {
"dimensions": {
"cpu": "x86-64",
"os": "Mac-13"
},
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test": "webui_resources_tools_python_unittests",
"test_id_prefix": "ninja://ui/webui/resources/tools:webui_resources_tools_python_unittests/"
},
{
"isolate_profile_data": true,
"merge": {

@ -5140,22 +5140,6 @@
"test": "views_perftests",
"test_id_prefix": "ninja://ui/views:views_perftests/"
},
{
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "webui_resources_tools_python_unittests",
"swarming": {
"dimensions": {
"cpu": "x86-64",
"os": "Mac-13"
},
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test": "webui_resources_tools_python_unittests",
"test_id_prefix": "ninja://ui/webui/resources/tools:webui_resources_tools_python_unittests/"
},
{
"isolate_profile_data": true,
"merge": {

@ -2094,23 +2094,6 @@
"test": "views_perftests",
"test_id_prefix": "ninja://ui/views:views_perftests/"
},
{
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "webui_resources_tools_python_unittests",
"swarming": {
"dimensions": {
"cpu": "arm64",
"os": "Windows-11",
"screen_scaling_percent": "100"
},
"expiration": 7200,
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test": "webui_resources_tools_python_unittests",
"test_id_prefix": "ninja://ui/webui/resources/tools:webui_resources_tools_python_unittests/"
},
{
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"

@ -2138,22 +2138,6 @@
"test": "views_perftests",
"test_id_prefix": "ninja://ui/views:views_perftests/"
},
{
"isolate_profile_data": true,
"merge": {
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "webui_resources_tools_python_unittests",
"swarming": {
"dimensions": {
"cpu": "x86-64",
"os": "Windows-10-19045"
},
"service_account": "chromium-tester@chops-service-accounts.iam.gserviceaccount.com"
},
"test": "webui_resources_tools_python_unittests",
"test_id_prefix": "ninja://ui/webui/resources/tools:webui_resources_tools_python_unittests/"
},
{
"isolate_profile_data": true,
"merge": {

@ -2086,11 +2086,6 @@
"${ISOLATED_OUTDIR}",
],
},
"webui_resources_tools_python_unittests": {
"label": "//ui/webui/resources/tools:webui_resources_tools_python_unittests",
"type": "generated_script",
"skip_usage_check": True,
},
"webview_64_cts_tests": {
"label": "//android_webview/test:webview_64_cts_tests",
"type": "script",

@ -1745,13 +1745,6 @@ targets.binaries.script(
],
)
targets.binaries.generated_script(
name = "webui_resources_tools_python_unittests",
label = "//ui/webui/resources/tools:webui_resources_tools_python_unittests",
# All references are in starlark.
skip_usage_check = True,
)
targets.binaries.console_test_launcher(
name = "power_sampler_unittests",
label = "//tools/mac/power:power_sampler_unittests",

@ -2596,7 +2596,6 @@ targets.bundle(
name = "desktop_once_isolated_scripts",
targets = [
"test_env_py_unittests",
"webui_resources_tools_python_unittests",
"xvfb_py_unittests",
],
)

@ -2072,10 +2072,6 @@ targets.tests.isolated_script_test(
name = "polymer_tools_python_unittests",
)
targets.tests.isolated_script_test(
name = "webui_resources_tools_python_unittests",
)
targets.tests.gtest_test(
name = "power_sampler_unittests",
)

@ -38,7 +38,6 @@ KNOWN_TYP_TEST_RUNNERS = {
'run_blinkpy_tests.py',
'run_mac_signing_tests.py',
'run_mini_installer_tests.py',
'run_webui_resources_tools_tests.py',
'test_suite_all.py', # //tools/grit:grit_python_unittests
}

@ -22,7 +22,6 @@ executable("code_cache_generator") {
"//gin:gin",
"//mojo/core/embedder",
"//third_party/blink/public:blink",
"//tools/v8_context_snapshot:buildflags",
"//v8",
]
data_deps = []

@ -1,23 +0,0 @@
# Copyright 2025 The Chromium Authors
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import("//testing/test.gni")
script_test("webui_resources_tools_python_unittests") {
script = "//testing/scripts/run_isolated_script_test.py"
args = [ "@WrappedPath(" + rebase_path(
"//ui/webui/resources/tools/run_webui_resources_tools_tests.py",
root_build_dir) + ")" ]
data = [
"//ui/webui/resources/tools/",
# typ is the testing harness used for python unit tests.
"//third_party/catapult/third_party/typ/",
"//third_party/node/",
# Needed for eslint_ts_test.EslintTsTest.testSuccess
"//tools/typescript/tsconfig_base.json",
]
data_deps = [ "//tools/code_cache_generator" ]
}

@ -1,20 +0,0 @@
#!/usr/bin/env python3
# Copyright 2025 The Chromium Authors
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import os
import sys
THIS_DIR = os.path.abspath(os.path.dirname(__file__))
SRC_DIR = os.path.dirname(
os.path.dirname(os.path.dirname(os.path.dirname(THIS_DIR))))
TYP_DIR = os.path.join(SRC_DIR, 'third_party', 'catapult', 'third_party', 'typ')
if not TYP_DIR in sys.path:
sys.path.insert(0, TYP_DIR)
import typ
os.chdir(THIS_DIR)
sys.exit(typ.main(top_level_dir=THIS_DIR, suffixes=['*_test.py']))