[code health] Remove 4 WebAuthentication.ChromeOS.U2FClient histograms
This CL removes these expired histograms: - WebAuthentication.ChromeOS.U2FClient.IsU2fEnabledDuration - WebAuthentication.ChromeOS.U2FClient.IsUvpaaDuration - WebAuthentication.ChromeOS.U2FClient.IsUvpaaStatus - WebAuthentication.ChromeOS.U2FClient.IsU2fEnabledStatus Fixed: 1447191 Change-Id: I5cbd20ee094fa110a604a9f1bfc3b06c1a4415b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4621864 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/main@{#1160828}
This commit is contained in:
Orin Jaworski
committed by
Chromium LUCI CQ
Chromium LUCI CQ
parent
c70ba714fc
commit
bc6d4e5ef5
@ -46,19 +46,6 @@ constexpr int kU2FShortTimeout = 3000;
|
||||
// credentials.
|
||||
constexpr int kU2FMediumTimeout = 10000;
|
||||
|
||||
// U2FClientStatus represents the outcome of a DBus method call to u2fd. It
|
||||
// needs to be kept in sync with the WebAuthenticationU2FClientStatus metrics
|
||||
// enum.
|
||||
//
|
||||
// These values are persisted to logs. Entries should not be renumbered and
|
||||
// numeric values should never be reused.
|
||||
enum class U2FClientStatus {
|
||||
kOk = 0,
|
||||
kUnknownError = 1,
|
||||
// Add new values here.
|
||||
kMaxValue = kUnknownError,
|
||||
};
|
||||
|
||||
template <typename ResponseProto>
|
||||
absl::optional<ResponseProto> ConvertResponse(dbus::Response* dbus_response) {
|
||||
if (!dbus_response) {
|
||||
@ -144,21 +131,13 @@ void U2FClientImpl::IsUvpaa(const u2f::IsUvpaaRequest& request,
|
||||
proxy_->CallMethod(
|
||||
&method_call, kU2FShortTimeout,
|
||||
base::BindOnce(
|
||||
[](base::TimeTicks start,
|
||||
DBusMethodCallback<u2f::IsUvpaaResponse> callback,
|
||||
[](DBusMethodCallback<u2f::IsUvpaaResponse> callback,
|
||||
dbus::Response* dbus_response) {
|
||||
base::UmaHistogramTimes(
|
||||
"WebAuthentication.ChromeOS.U2FClient.IsUvpaaDuration",
|
||||
base::TimeTicks::Now() - start);
|
||||
absl::optional<u2f::IsUvpaaResponse> response =
|
||||
ConvertResponse<u2f::IsUvpaaResponse>(dbus_response);
|
||||
base::UmaHistogramEnumeration(
|
||||
"WebAuthentication.ChromeOS.U2FClient.IsUvpaaStatus",
|
||||
response ? U2FClientStatus::kOk
|
||||
: U2FClientStatus::kUnknownError);
|
||||
std::move(callback).Run(std::move(response));
|
||||
},
|
||||
base::TimeTicks::Now(), std::move(callback)));
|
||||
std::move(callback)));
|
||||
}
|
||||
|
||||
void U2FClientImpl::IsU2FEnabled(
|
||||
@ -170,21 +149,13 @@ void U2FClientImpl::IsU2FEnabled(
|
||||
proxy_->CallMethod(
|
||||
&method_call, kU2FShortTimeout,
|
||||
base::BindOnce(
|
||||
[](base::TimeTicks start,
|
||||
DBusMethodCallback<u2f::IsU2fEnabledResponse> callback,
|
||||
[](DBusMethodCallback<u2f::IsU2fEnabledResponse> callback,
|
||||
dbus::Response* dbus_response) {
|
||||
base::UmaHistogramTimes(
|
||||
"WebAuthentication.ChromeOS.U2FClient.IsU2fEnabledDuration",
|
||||
base::TimeTicks::Now() - start);
|
||||
absl::optional<u2f::IsU2fEnabledResponse> response =
|
||||
ConvertResponse<u2f::IsU2fEnabledResponse>(dbus_response);
|
||||
base::UmaHistogramEnumeration(
|
||||
"WebAuthentication.ChromeOS.U2FClient.IsU2fEnabledStatus",
|
||||
response ? U2FClientStatus::kOk
|
||||
: U2FClientStatus::kUnknownError);
|
||||
std::move(callback).Run(std::move(response));
|
||||
},
|
||||
base::TimeTicks::Now(), std::move(callback)));
|
||||
std::move(callback)));
|
||||
}
|
||||
|
||||
void U2FClientImpl::MakeCredential(
|
||||
@ -196,12 +167,8 @@ void U2FClientImpl::MakeCredential(
|
||||
proxy_->CallMethod(
|
||||
&method_call, kU2FInfiniteTimeout,
|
||||
base::BindOnce(
|
||||
[](base::TimeTicks start,
|
||||
DBusMethodCallback<u2f::MakeCredentialResponse> callback,
|
||||
[](DBusMethodCallback<u2f::MakeCredentialResponse> callback,
|
||||
dbus::Response* dbus_response) {
|
||||
base::UmaHistogramMediumTimes(
|
||||
"WebAuthentication.ChromeOS.U2FClient.IsU2fEnabledDuration",
|
||||
base::TimeTicks::Now() - start);
|
||||
absl::optional<u2f::MakeCredentialResponse> response =
|
||||
ConvertResponse<u2f::MakeCredentialResponse>(dbus_response);
|
||||
if (response) {
|
||||
@ -214,7 +181,7 @@ void U2FClientImpl::MakeCredential(
|
||||
}
|
||||
std::move(callback).Run(std::move(response));
|
||||
},
|
||||
base::TimeTicks::Now(), std::move(callback)));
|
||||
std::move(callback)));
|
||||
}
|
||||
|
||||
void U2FClientImpl::GetAssertion(
|
||||
|
||||
@ -111545,15 +111545,6 @@ others/histograms.xml -->
|
||||
<int value="2" label="Blocked"/>
|
||||
</enum>
|
||||
|
||||
<enum name="WebAuthenticationU2FClientStatus">
|
||||
<summary>Outcome of a DBus method call to u2fd.</summary>
|
||||
<int value="0" label="OK"/>
|
||||
<int value="1" label="Unknown Error">
|
||||
Method call failed, e.g. because the service was unavailable or the request
|
||||
timed out.
|
||||
</int>
|
||||
</enum>
|
||||
|
||||
<enum name="WebauthnOptInPromoNotOfferedReason">
|
||||
<int value="0" label="Unknown"/>
|
||||
<int value="1"
|
||||
|
||||
@ -115,40 +115,6 @@ chromium-metrics-reviews@google.com.
|
||||
</summary>
|
||||
</histogram>
|
||||
|
||||
<histogram name="WebAuthentication.ChromeOS.U2FClient.IsU2fEnabledDuration"
|
||||
units="ms" expires_after="2022-08-31">
|
||||
<owner>martinkr@google.com</owner>
|
||||
<owner>chrome-webauthn@google.com</owner>
|
||||
<summary>The duration of a u2fd IsU2fEnabled request.</summary>
|
||||
</histogram>
|
||||
|
||||
<histogram name="WebAuthentication.ChromeOS.U2FClient.IsU2fEnabledStatus"
|
||||
enum="WebAuthenticationU2FClientStatus" expires_after="2023-05-14">
|
||||
<owner>martinkr@google.com</owner>
|
||||
<owner>chrome-webauthn@google.com</owner>
|
||||
<summary>
|
||||
Records whether a u2fd IsU2fEnabled DBus call completed successfully or
|
||||
encountered an error.
|
||||
</summary>
|
||||
</histogram>
|
||||
|
||||
<histogram name="WebAuthentication.ChromeOS.U2FClient.IsUvpaaDuration"
|
||||
units="ms" expires_after="2022-08-31">
|
||||
<owner>martinkr@google.com</owner>
|
||||
<owner>chrome-webauthn@google.com</owner>
|
||||
<summary>The duration of a u2fd IsUvpaa request.</summary>
|
||||
</histogram>
|
||||
|
||||
<histogram name="WebAuthentication.ChromeOS.U2FClient.IsUvpaaStatus"
|
||||
enum="WebAuthenticationU2FClientStatus" expires_after="2022-12-31">
|
||||
<owner>martinkr@google.com</owner>
|
||||
<owner>chrome-webauthn@google.com</owner>
|
||||
<summary>
|
||||
Records whether a u2fd IsUvpaa DBus call completed successfully or
|
||||
encountered an error.
|
||||
</summary>
|
||||
</histogram>
|
||||
|
||||
<histogram name="WebAuthentication.ConditionalUiPasskeyCount" units="passkeys"
|
||||
expires_after="2023-11-12">
|
||||
<owner>kenrb@chromium.org</owner>
|
||||
|
||||
Reference in New Issue
Block a user