chromium/src
0
Fork 0
Code Activity

Revert of Fixing all of problems found by vc++ /analyze in GCM code (patchset id:1 of https://codereview.chromium.org/713573003/)

Browse Source 
Reason for revert:
Reverting since it's causing a crash on canary.

Original issue's description:
> Fixing all of problems found by vc++ /analyze in GCM code
>
> There was only a minor (harmless) case of variable shadowing.
>
> BUG=427616
> R=zea@chromium.org
>
> Committed: https://crrev.com/3e021981ccc2be8de7443ff1a18439551b22ea75
> Cr-Commit-Position: refs/heads/master@{#303338}

TBR=zea@chromium.org,brucedawson@chromium.org,fgorski@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=427616

Review URL: https://codereview.chromium.org/712793003

Cr-Commit-Position: refs/heads/master@{#303396}
This commit is contained in:
matthewyuan
2014-11-08 14:36:05 -08:00
committed by Commit bot
parent 87607055f5
commit bca70e90f5
1 changed files with 5 additions and 5 deletions

10
google_apis/gcm/engine/gcm_store_impl.cc

@ -552,11 +552,11 @@ void GCMStoreImpl::Backend::SetGServicesSettings(
// Remove all existing settings.
leveldb::ReadOptions read_options;
read_options.verify_checksums = true;
scoped_ptr<leveldb::Iterator> db_iter(db_->NewIterator(read_options));
for (db_iter->Seek(MakeSlice(kGServiceSettingKeyStart));
db_iter->Valid() && db_iter->key().ToString() < kGServiceSettingKeyEnd;
db_iter->Next()) {
write_batch.Delete(db_iter->key());
scoped_ptr<leveldb::Iterator> iter(db_->NewIterator(read_options));
for (iter->Seek(MakeSlice(kGServiceSettingKeyStart));
iter->Valid() && iter->key().ToString() < kGServiceSettingKeyEnd;
iter->Next()) {
write_batch.Delete(iter->key());
}
// Add the new settings.