chromium/src
0
Fork 0
Code Activity

holdingspace: Update strings for refresh of holdingspace.

Browse Source 
Lowercased f in "Quick files" and lowercased q in "Pin to quick files" and "Unpin from quick files"

Screenshot of holdingspace a11y text: http://shortn/_EurYnvul1n
Recording of holdingspace tooltip text: http://shortn/_M1qCg0AnlG
Screenshot of Files app, "Unpin from quick files": http://shortn/_DdhtjCWQsF
Screenshot of Files app, "Pin to quick files": http://shortn/_VR6QJmJ5bA
Screenshot holdingspace welcome text in tablet mode: http://shortn/_iSCkgyGMRq
Screenshot holdingspace welcome text in non tablet mode: http://shortn/_WnCEzxGbgx

Bug: 1352521
Change-Id: I3a085a5bcbcaf44b2a2d9247183fe967d7d55b87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3923029
Auto-Submit: Angel Sanchez <angelsan@google.com>
Reviewed-by: David Black <dmblack@google.com>
Commit-Queue: Angel Sanchez <angelsan@google.com>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Quick-Run: Angel Sanchez <angelsan@google.com>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/main@{#1052165}
This commit is contained in:
Angel
2022-09-28 02:00:52 +00:00
committed by Chromium LUCI CQ
parent 373057054c
commit bdbaa203ff
10 changed files with 15 additions and 15 deletions

4
ash/ash_strings.grd

@ -1320,8 +1320,8 @@ This file contains the strings for ash.
<message name="IDS_ASH_HOLDING_SPACE_TITLE" desc="Title of the holding space tray and bubble.">
Tote
</message>
<message name="IDS_ASH_HOLDING_SPACE_TITLE_REBRAND" desc="Title of the holding space tray and bubble when rebranding is enabled.">
Quick Files
<message name="IDS_ASH_HOLDING_SPACE_TITLE_REFRESH" desc="Title of the holding space tray and bubble when refresh is enabled.">
Quick files
</message>
<message name="IDS_ASH_HOLDING_SPACE_PINNED_TITLE" desc="Title of the pinned files area in the holding space bubble.">
Pinned files

1
ash/ash_strings_grd/IDS_ASH_HOLDING_SPACE_TITLE_REBRAND.png.sha1

@ -1 +0,0 @@
0efba1b5cba684074d8ca48b4007a3c6ed0db170

1
ash/ash_strings_grd/IDS_ASH_HOLDING_SPACE_TITLE_REFRESH.png.sha1 Normal file

@ -0,0 +1 @@
07f8666ac7e7007146fef018e56add86199e81d1

4
ash/system/holding_space/holding_space_tray.cc

@ -302,7 +302,7 @@ std::u16string HoldingSpaceTray::GetAccessibleNameForTray() {
return l10n_util::GetStringFUTF16(
IDS_ASH_HOLDING_SPACE_A11Y_NAME,
features::IsHoldingSpaceRebrandEnabled()
? l10n_util::GetStringUTF16(IDS_ASH_HOLDING_SPACE_TITLE_REBRAND)
? l10n_util::GetStringUTF16(IDS_ASH_HOLDING_SPACE_TITLE_REFRESH)
: l10n_util::GetStringUTF16(IDS_ASH_HOLDING_SPACE_TITLE));
}
@ -314,7 +314,7 @@ views::View* HoldingSpaceTray::GetTooltipHandlerForPoint(
std::u16string HoldingSpaceTray::GetTooltipText(const gfx::Point& point) const {
return features::IsHoldingSpaceRebrandEnabled()
? l10n_util::GetStringUTF16(IDS_ASH_HOLDING_SPACE_TITLE_REBRAND)
? l10n_util::GetStringUTF16(IDS_ASH_HOLDING_SPACE_TITLE_REFRESH)
: l10n_util::GetStringUTF16(IDS_ASH_HOLDING_SPACE_TITLE);
}

4
ash/system/holding_space/holding_space_tray_unittest.cc

@ -3647,7 +3647,7 @@ TEST_P(HoldingSpaceTrayRebrandTest, CheckTrayAccessibilityText) {
EXPECT_EQ(
GetTray()->GetAccessibleNameForTray(),
IsHoldingSpaceRebrandEnabled()
? u"Quick Files: recent screen captures, downloads, and pinned files"
? u"Quick files: recent screen captures, downloads, and pinned files"
: u"Tote: recent screen captures, downloads, and pinned files");
}
@ -3669,7 +3669,7 @@ TEST_P(HoldingSpaceTrayRebrandTest, CheckTrayTooltipText) {
StartSession(/*pre_mark_time_of_first_add=*/true);
GetTray()->FirePreviewsUpdateTimerIfRunningForTesting();
EXPECT_EQ(GetTray()->GetTooltipText(gfx::Point()),
IsHoldingSpaceRebrandEnabled() ? u"Quick Files" : u"Tote");
IsHoldingSpaceRebrandEnabled() ? u"Quick files" : u"Tote");
}
TEST_P(HoldingSpaceTrayRebrandTest, PaintsSeparatorBetweenBubbles) {

8
ui/chromeos/file_manager_strings.grdp

@ -1195,10 +1195,10 @@
Got it
</message>
<message name="IDS_FILE_BROWSER_HOLDING_SPACE_WELCOME_TEXT" desc="In the Holding Space welcome banner, text of the welcome message.">
Right-click a file, and select "<ph name="PIN_COMMAND">$1<ex>Pin to Quick Files</ex></ph>" for quick access to your files in shelf.
Right-click a file, and select "<ph name="PIN_COMMAND">$1<ex>Pin to quick files</ex></ph>" for quick access to your files in shelf.
</message>
<message name="IDS_FILE_BROWSER_HOLDING_SPACE_WELCOME_TEXT_IN_TABLET_MODE_HTML" desc="In the Holding Space welcome banner, text of the welcome message in tablet mode.">
Touch &amp; hold a file and tap <ph name="ICON">&lt;span class='icon'&gt;&lt;/span&gt;</ph>, and select "<ph name="PIN_COMMAND">$1<ex>Pin to Quick Files</ex></ph>" for quick access to your files in shelf.
Touch &amp; hold a file and tap <ph name="ICON">&lt;span class='icon'&gt;&lt;/span&gt;</ph>, and select "<ph name="PIN_COMMAND">$1<ex>Pin to quick files</ex></ph>" for quick access to your files in shelf.
</message>
<message name="IDS_FILE_BROWSER_HOLDING_SPACE_WELCOME_TITLE" desc="In the Holding Space welcome banner, title of banner.">
Create a shortcut for your files
@ -1468,10 +1468,10 @@
<!-- Holding space -->
<message name="IDS_FILE_BROWSER_HOLDING_SPACE_PIN_COMMAND_LABEL" desc="Label for the command which pins one or more files to the holding space.">
Pin to Quick Files
Pin to quick files
</message>
<message name="IDS_FILE_BROWSER_HOLDING_SPACE_UNPIN_COMMAND_LABEL" desc="Label for the command which unpins one or more files from the holding space.">
Unpin from Quick Files
Unpin from quick files
</message>
<message name="IDS_FILE_BROWSER_HOLDING_SPACE_PIN_TO_SHELF_COMMAND_LABEL" desc="Label for the command which pins one or more files to the holding space in the shelf.">
Pin to shelf

2
ui/chromeos/file_manager_strings_grdp/IDS_FILE_BROWSER_HOLDING_SPACE_PIN_COMMAND_LABEL.png.sha1

@ -1 +1 @@
4ef49a88bf3725e9b9ae89d3aa2e70803f7ac1cf
359489454763999cb6068f00b65668101d25fede

2
ui/chromeos/file_manager_strings_grdp/IDS_FILE_BROWSER_HOLDING_SPACE_UNPIN_COMMAND_LABEL.png.sha1

@ -1 +1 @@
d75fcdc93eef8b1dcf4f9cb6e98ac11c41c62c24
3c363b61fdc50720109770f979989e43a64aafda

2
ui/chromeos/file_manager_strings_grdp/IDS_FILE_BROWSER_HOLDING_SPACE_WELCOME_TEXT.png.sha1

@ -1 +1 @@
5aaeed79c1c77194160ee03522975304fba498f4
c784c9036257656fae83312dbff583a4514dd743

2
ui/chromeos/file_manager_strings_grdp/IDS_FILE_BROWSER_HOLDING_SPACE_WELCOME_TEXT_IN_TABLET_MODE_HTML.png.sha1

@ -1 +1 @@
a163b52c3a774a1ac16c6d2b44a83182bf826190
17bb9ccdc08d3600961107c1f5305095ac20d4ac