chromium/src
0
Fork 0
Code Activity

Remove TODO comments for some functions in pdf.cc

Browse Source 
Remove the TODO comments regarding chromium:1440430 for
IsPDFDocTagged(), GetPDFStructTreeForPage() and GetPDFPageSizeByIndex()
since their remaining use cases are only in test environment and the
Skia already have test coverage through field trial.

Bug: 1440430
Change-Id: Ifea5458fd221eaf7590ab4427592caf1b6d88c09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4548365
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Nigi <nigi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1146711}
This commit is contained in:
Hui Yingst
2023-05-19 21:10:52 +00:00
committed by Chromium LUCI CQ
parent 6b8ad5cdb1
commit bee930867f
1 changed files with 0 additions and 6 deletions

6
pdf/pdf.cc

@ -98,16 +98,12 @@ bool GetPDFDocInfo(base::span<const uint8_t> pdf_buffer,
return engine_exports->GetPDFDocInfo(pdf_buffer, page_count, max_page_width);
}
// TODO(crbug.com/1440430): Make sure its callers set
// `g_use_skia_renderer_enabled_by_policy` before calling this function.
absl::optional<bool> IsPDFDocTagged(base::span<const uint8_t> pdf_buffer) {
ScopedSdkInitializer scoped_sdk_initializer(/*enable_v8=*/true);
PDFEngineExports* engine_exports = PDFEngineExports::Get();
return engine_exports->IsPDFDocTagged(pdf_buffer);
}
// TODO(crbug.com/1440430): Make sure its callers set
// `g_use_skia_renderer_enabled_by_policy` before calling this function.
base::Value GetPDFStructTreeForPage(base::span<const uint8_t> pdf_buffer,
int page_index) {
ScopedSdkInitializer scoped_sdk_initializer(/*enable_v8=*/true);
@ -115,8 +111,6 @@ base::Value GetPDFStructTreeForPage(base::span<const uint8_t> pdf_buffer,
return engine_exports->GetPDFStructTreeForPage(pdf_buffer, page_index);
}
// TODO(crbug.com/1440430): Make sure its callers set
// `g_use_skia_renderer_enabled_by_policy` before calling this function.
absl::optional<gfx::SizeF> GetPDFPageSizeByIndex(
base::span<const uint8_t> pdf_buffer,
int page_index) {