0

AW Finch: fix documentation for seed signature

No change to logic. This updates documentation for the 'signature' field
of aw_variations_seed.proto. As far as I can tell this was never
documented accurately and was probably just bad copy-paste from
'is_gzip_compressed'.

This also clarifies that 'is_gzip_compressed' only has to do with GZIP
compression. There's also something called delta compression, but that's
handled at a different layer of code so it's not relevant for this
proto.

Fixed: 1295929
Test: N/A
Change-Id: I01e8aee59ca44afa9d36bad9e14783e1847d06dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3593858
Reviewed-by: Rakib Hasan <rmhasan@google.com>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#995347}
This commit is contained in:
Nate Fischer
2022-04-22 21:14:07 +00:00
committed by Chromium LUCI CQ
parent 8a5c19f483
commit c0922a0b68

@ -16,7 +16,8 @@ option java_package = "org.chromium.android_webview.proto";
//
// Next tag: 7
message AwVariationsSeed {
// Whether seed_data is compressed. Comes from HTTP header "X-Seed-Signature".
// A base64-encoded signature of the seed data. This can be used by the client
// to verify the seed contents. Comes from HTTP header "X-Seed-Signature".
optional string signature = 1;
// 2-letter country code. Comes from HTTP header "X-Country".
optional string country = 2;
@ -24,7 +25,7 @@ message AwVariationsSeed {
// sections 3.3.1 and 14.18 for the format.
// This was deprecated in favor of the |date| field in October 2019.
optional string date_header = 3 [deprecated = true];
// Whether seed_data is compressed. Comes from HTTP header "IM".
// Whether seed_data is GZIP compressed. Comes from HTTP header "IM".
optional bool is_gzip_compressed = 4;
// The download body, itself a serialized VariationsSeed proto.
optional bytes seed_data = 5;