chromium/src
0
Fork 0
Code Activity

Re-add accidently removed NOINLINE attribute on UI/IOThreadRun methods

Browse Source 
Accidently removed in https://chromium-review.googlesource.com/c/chromium/src/+/969104
when I moved the methods over from BrowserThreadImpl.

Not having it is likely the cause of the symbol vanishing in optimized
builds which causes crbug.com/824716.

TBR=jam@chromium.org

Bug: 824716
Change-Id: Ia53ec332140a7b21013b16765c8f9f0813930604
Reviewed-on: https://chromium-review.googlesource.com/986476
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546854}
This commit is contained in:
Gabriel Charette
2018-03-29 18:26:04 +00:00
committed by Commit Bot
parent c93ce0dff3
commit c20a9e88cf
1 changed files with 2 additions and 2 deletions

4
content/browser/browser_process_sub_thread.cc

@ -144,13 +144,13 @@ void BrowserProcessSubThread::CompleteInitializationOnBrowserThread() {
MSVC_DISABLE_OPTIMIZE()
MSVC_PUSH_DISABLE_WARNING(4748)
void BrowserProcessSubThread::UIThreadRun(base::RunLoop* run_loop) {
NOINLINE void BrowserProcessSubThread::UIThreadRun(base::RunLoop* run_loop) {
const int line_number = __LINE__;
Thread::Run(run_loop);
base::debug::Alias(&line_number);
}
void BrowserProcessSubThread::IOThreadRun(base::RunLoop* run_loop) {
NOINLINE void BrowserProcessSubThread::IOThreadRun(base::RunLoop* run_loop) {
const int line_number = __LINE__;
Thread::Run(run_loop);
base::debug::Alias(&line_number);