0

Fix linking with gold by cleaning up lib dependencies.

- Remove pangoft2, we don't use it anywhere.
- Add gdk, fontconfig and freetype2 as dependencies of skia.  Gdk is
  used in platform_canvas_linux.
- X11, Xrender and Xext are used by the IPC system, so everything that
  depends on common, needs to link in those libs.  By moving the
  link_settings line into the libcommon.a target, all projects
  inherit these.

Review URL: http://codereview.chromium.org/60070


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13055 0039d316-1c4b-4281-b951-d872f2087c98
This commit is contained in:
tc@google.com
2009-04-02 23:31:55 +00:00
parent 77e802a962
commit c24e5d031e
4 changed files with 41 additions and 12 deletions
build/linux
chrome
skia
webkit

@ -33,16 +33,44 @@
},
},
{
'target_name': 'pangoft2',
'target_name': 'freetype2',
'type': 'settings',
'direct_dependent_settings': {
'cflags': [
'<!@(python pkg_config_wrapper.py --cflags pangoft2)',
'<!@(python pkg_config_wrapper.py --cflags freetype2)',
],
},
'link_settings': {
'libraries': [
'<!@(python pkg_config_wrapper.py --libs pangoft2)',
'<!@(python pkg_config_wrapper.py --libs freetype2)',
],
},
},
{
'target_name': 'fontconfig',
'type': 'settings',
'direct_dependent_settings': {
'cflags': [
'<!@(python pkg_config_wrapper.py --cflags fontconfig)',
],
},
'link_settings': {
'libraries': [
'<!@(python pkg_config_wrapper.py --libs fontconfig)',
],
},
},
{
'target_name': 'gdk',
'type': 'settings',
'direct_dependent_settings': {
'cflags': [
'<!@(python pkg_config_wrapper.py --cflags gdk-2.0)',
],
},
'link_settings': {
'libraries': [
'<!@(python pkg_config_wrapper.py --libs gdk-2.0)',
],
},
},

@ -314,6 +314,13 @@
'dependencies': [
'../build/linux/system.gyp:gtk',
],
'link_settings': {
'libraries': [
'-lX11',
'-lXrender',
'-lXext',
],
},
}, { # else: 'OS!="linux"'
'sources!': [
'third_party/xdg_user_dirs/xdg_user_dir_lookup.cc',
@ -1537,13 +1544,6 @@
# Needed for chrome_dll_main.cc #include of gtk/gtk.h
'../build/linux/system.gyp:gtk',
],
'link_settings': {
'libraries': [
'-lX11',
'-lXrender',
'-lXext',
],
},
'copies': [
{
'destination': '<(PRODUCT_DIR)',

@ -688,7 +688,9 @@
}],
[ 'OS == "linux"', {
'dependencies': [
'../build/linux/system.gyp:gtk',
'../build/linux/system.gyp:gdk',
'../build/linux/system.gyp:fontconfig',
'../build/linux/system.gyp:freetype2',
],
'cflags': [
'-Wno-unused',

@ -4446,7 +4446,6 @@
['OS=="linux"', {
'dependencies': [
'../build/linux/system.gyp:gtk',
'../build/linux/system.gyp:pangoft2',
],
'sources!': [
'glue/plugins/plugin_stubs.cc',