chromium/src
0
Fork 0
Code Activity

Revert "graphite: Use monolithic pipeline cache"

Browse Source 
This reverts commit d4842c84d4.

Reason for revert: Causing crashes in crbug.com/378058742.

Original change's description:
> graphite: Use monolithic pipeline cache
>
> Enable vulkan_monolithic_pipeline_cache for Graphite/Dawn/Vulkan. Also
> wire up the idle cleanup signal which serializes VkPipelineCache to
> disk.
>
> Bug: 370343334
> Change-Id: Idbde65be830e969bdf013a5398f6bbd63981d730
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5914392
> Commit-Queue: Kyle Charbonneau <kylechar@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1379001}

Bug: 370343334, 378058742
Change-Id: Ia8276a14c5d77c4ebaccff526adf4276fbc135b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6004061
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Saifuddin Hitawala <hitawala@chromium.org>
Commit-Queue: Kyle Charbonneau <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1380577}
This commit is contained in:
Kyle Charbonneau
2024-11-08 20:30:28 +00:00
committed by Chromium LUCI CQ
parent 4bc7463481
commit c26127f14e
2 changed files with 0 additions and 5 deletions

4
gpu/command_buffer/service/dawn_context_provider.cc

@ -121,10 +121,6 @@ std::vector<const char*> GetEnabledToggles(
}
#endif
if (backend_type == wgpu::BackendType::Vulkan) {
enabled_toggles.push_back("vulkan_monolithic_pipeline_cache");
}
// Skip expensive swiftshader vkCmdDraw* for tests.
// TODO(penghuang): rename kDisableGLDrawingForTests to
// kDisableGpuDrawingForTests

1
gpu/command_buffer/service/graphite_cache_controller.cc

@ -79,7 +79,6 @@ void GraphiteCacheController::CleanUpAllResources() {
#if BUILDFLAG(SKIA_USE_DAWN)
if (dawn_context_provider_) {
dawn::native::ReduceMemoryUsage(dawn_context_provider_->GetDevice().Get());
dawn::native::PerformIdleTasks(dawn_context_provider_->GetDevice());
}
#endif
}