chromium/src
0
Fork 0
Code Activity

[PDF Ink Signatures] Refactor test set brush message function

Browse Source 
Refactor CreateSetAnnotationBrushMessageForTesting() by making the type
parameter an `std::string_view` instead of a `const std::string&`.

Change-Id: I9122877fce61f8b64765ffba6ee0a84f2744f2a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6045003
Commit-Queue: Andy Phan <andyphan@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1387978}
This commit is contained in:
Andy Phan
2024-11-26 01:25:12 +00:00
committed by Chromium LUCI CQ
parent 152c4a2003
commit c28d2a0ae4
2 changed files with 3 additions and 4 deletions

4
pdf/test/pdf_ink_test_helpers.cc

@ -4,7 +4,7 @@
#include "pdf/test/pdf_ink_test_helpers.h"
#include <string>
#include <string_view>
#include <utility>
#include "base/notreached.h"
@ -27,7 +27,7 @@ std::optional<ink::StrokeInputBatch> CreateInkInputBatch(
}
base::Value::Dict CreateSetAnnotationBrushMessageForTesting(
const std::string& type,
std::string_view type,
double size,
const TestAnnotationBrushMessageParams* params) {
base::Value::Dict message;

3
pdf/test/pdf_ink_test_helpers.h

@ -6,7 +6,6 @@
#define PDF_TEST_PDF_INK_TEST_HELPERS_H_
#include <optional>
#include <string>
#include <string_view>
#include "base/containers/span.h"
@ -47,7 +46,7 @@ std::optional<ink::StrokeInputBatch> CreateInkInputBatch(
base::Value::Dict CreateSetAnnotationModeMessageForTesting(bool enable);
base::Value::Dict CreateSetAnnotationBrushMessageForTesting(
const std::string& type,
std::string_view type,
double size,
const TestAnnotationBrushMessageParams* params);