0

Unflag PerformanceEntrySafeSort

It's been verified to work, and the finch was only there for a safe
merge.

Bug: 391339239
Change-Id: I8b1bcd2ce4e3816d9cf01fef2b1a7b32d720276d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6308568
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1426417}
This commit is contained in:
Noam Rosenthal
2025-02-28 10:01:54 -08:00
committed by Chromium LUCI CQ
parent 3219d07dfc
commit c3ecd61ad9
3 changed files with 2 additions and 28 deletions
testing/variations
third_party/blink/renderer

@ -16960,25 +16960,6 @@
]
}
],
"PerformanceEntrySafeSort": [
{
"platforms": [
"android",
"chromeos",
"linux",
"mac",
"windows"
],
"experiments": [
{
"name": "Enabled",
"enable_features": [
"PerformanceEntrySafeSort"
]
}
]
}
],
"PeripheralCustomization": [
{
"platforms": [

@ -37,7 +37,6 @@
#include "third_party/blink/renderer/core/dom/dom_high_res_time_stamp.h"
#include "third_party/blink/renderer/core/frame/dom_window.h"
#include "third_party/blink/renderer/platform/bindings/script_wrappable.h"
#include "third_party/blink/renderer/platform/runtime_enabled_features.h"
#include "third_party/blink/renderer/platform/wtf/hash_set.h"
#include "third_party/blink/renderer/platform/wtf/text/wtf_string.h"
@ -113,14 +112,11 @@ class CORE_EXPORT PerformanceEntry : public ScriptWrappable {
// TODO: create NT entry eagerly so that we don't have to do this
// https://bugs.chromium.org/p/chromium/issues/detail?id=1432565
if (a->EntryTypeEnum() == kNavigation &&
(b->EntryTypeEnum() != kNavigation ||
!RuntimeEnabledFeatures::PerformanceEntrySafeSortEnabled())) {
b->EntryTypeEnum() != kNavigation) {
return true;
} else if (b->EntryTypeEnum() == kNavigation) {
return false;
} else if (a->EntryTypeEnum() == kPaint &&
(b->EntryTypeEnum() != kPaint ||
!RuntimeEnabledFeatures::PerformanceEntrySafeSortEnabled())) {
} else if (a->EntryTypeEnum() == kPaint && b->EntryTypeEnum() != kPaint) {
return true;
} else if (b->EntryTypeEnum() == kPaint) {
return false;

@ -3282,9 +3282,6 @@
status: "experimental",
base_feature: "none",
},
{
name: "PerformanceEntrySafeSort",
},
{
name: "PerformanceManagerInstrumentation",
base_feature: "none",