chromium/src
0
Fork 0
Code Activity

Fix awkward wording in java_asserts.md

Browse Source 
Change-Id: Ibd45b235c9547dd83b27fedbd414fa5c5eb6a42a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3781549
Reviewed-by: Samuel Huang <huangs@chromium.org>
Auto-Submit: Sam Maier <smaier@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1027416}
This commit is contained in:
Sam Maier
2022-07-22 21:01:16 +00:00
committed by Chromium LUCI CQ
parent 655bc6accf
commit c465ee8cb5
1 changed files with 3 additions and 3 deletions

6
build/android/docs/java_asserts.md

@ -70,9 +70,9 @@ asserts](https://chromium-review.googlesource.com/c/chromium/src/+/3307087) on
Canary. It spiked our crash rate, and it was decided to not do this again, as
it's bad user experience to crash the app incessantly for non-fatal issues.
So, we asked the R8 team with an ask to allow us to rewrite the bytecode of
these assertions, which they implemented for us. Now, instead of just turning
it on and throwing an `AssertionError`, [R8 would call a provided assertion
So, we asked the R8 team for a feature which would rewrite the bytecode of these
assertions, which they implemented for us. Now, instead of just turning it on
and throwing an `AssertionError`, [R8 would call a provided assertion
handler](https://r8.googlesource.com/r8/+/aefe7bc18a7ce19f3e9c6dac0bedf6d182bbe142/src/main/java/com/android/tools/r8/ParseFlagInfoImpl.java#124)
with the `AssertionError`. We then wrote a [silent assertion
reporter](https://chromium-review.googlesource.com/c/chromium/src/+/3746261)