0

Update watchlists.md after Gerrit watchlists analyzer

Watchlists processing is now handled by the Watchlists analyzer on
Gerrit. Update the docs to reflect the new state of watchlists.

Bug: 324130575
Change-Id: Id3617b10d32d73b5e8f1ff15416b6fdb0a86f761
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5274051
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1257418}
This commit is contained in:
Gavin Mak
2024-02-07 17:37:54 +00:00
committed by Chromium LUCI CQ
parent 77d1c7a4af
commit c5bab533bd

@ -6,14 +6,6 @@ changes that modify that portion of code, thereby giving that watcher an
opportunity to make comments on chromium-review.googlesource.com even before the
change is committed.
**Important :** As watchlists are processed locally when uploading using `git cl
upload` it is not possible to define watchlists for Gerrit CLs generated by
tools such as the [Skia autoroller][skia-autoroller] (see
[crbug.com/982198][crbug-982198]). In order to be notified of autoroller
commits, find the [corresponding config file][roller-configs] and add email
addresses of people to be notified of roller commits in the `sheriff` field of
the autoroller config.
## Syntax
Watchlists are defined using a `WATCHLISTS` file, which resides at the root of a
@ -48,9 +40,9 @@ is the same as matching `.*A_WORD.*`.
Each name in `WATCHLISTS` must be defined first in `WATCHLIST_DEFINITIONS`.
Watchlist processing takes place during `git-cl upload` and are non-binding;
that is, an approval from that watcher is not needed for commit. It merely gives
the watcher an opportunity to make comments, if any.
Watchlist processing takes place on Gerrit with the "Watchlists" analyzer and is
non-binding; that is, an approval from that watcher is not needed for commit. It
merely gives the watcher an opportunity to make comments, if any.
## Editing Watchlists
@ -64,13 +56,3 @@ Example (from src):
```
python third_party/depot_tools/watchlists.py PATH/TO/FILE1 PATH/TO/FILE2 ....
```
## Override
To override watchlist processing, use `git cl upload` with `--bypass-hooks`.
[//]: # (the reference link section should be alphabetically sorted)
[skia-autoroller]: https://skia.googlesource.com/buildbot/+/HEAD/autoroll/README.md
[crbug-982198]: https://bugs.chromium.org/p/chromium/issues/detail?id=982198
[roller-configs]: https://skia.googlesource.com/buildbot/+/HEAD/autoroll/config