[iOS] Add feature flag for trusted vault infobar improvements
Bug: 408165259 Change-Id: Ib56b77667452ba6b7a825eb84e58d4baa1d671dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6441382 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rafał Godlewski <rgod@google.com> Cr-Commit-Position: refs/heads/main@{#1444672}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
a3b3df1f5f
commit
c64097e47c
chrome/browser
components/sync/base
ios/chrome/browser/flags
@ -8770,6 +8770,11 @@
|
||||
"owners": ["vmiura@google.com", "vtelezhnikov@google.com", "chrome-compositor@google.com"],
|
||||
"expiry_milestone": 140
|
||||
},
|
||||
{
|
||||
"name": "sync-trusted-vault-infobar-improvements",
|
||||
"owners": ["rgod@google.com", "ylahodiuk@google.com"],
|
||||
"expiry_milestone": 140
|
||||
},
|
||||
{
|
||||
"name": "sync-webauthn-credentials",
|
||||
"owners": [ "chrome-webauthn@google.com" ],
|
||||
|
@ -154,4 +154,10 @@ BASE_FEATURE(kSyncSimulateBookmarksPingPongForTesting,
|
||||
"SyncSimulateBookmarksPingPongForTesting",
|
||||
base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
|
||||
#if BUILDFLAG(IS_IOS)
|
||||
BASE_FEATURE(kSyncTrustedVaultInfobarImprovements,
|
||||
"SyncTrustedVaultInfobarImprovements",
|
||||
base::FEATURE_DISABLED_BY_DEFAULT);
|
||||
#endif // BUILDFLAG(IS_IOS)
|
||||
|
||||
} // namespace syncer
|
||||
|
@ -160,6 +160,13 @@ inline constexpr base::FeatureParam<int>
|
||||
// to ensure it is populated.
|
||||
BASE_DECLARE_FEATURE(kSyncSimulateBookmarksPingPongForTesting);
|
||||
|
||||
#if BUILDFLAG(IS_IOS)
|
||||
// Enables a set of improvements to the existing trusted vault error infobar on
|
||||
// iOS (displaying it on pages with password forms, adjusting display time,
|
||||
// adding dismiss conditions, adding a notification pause after dismissal).
|
||||
BASE_DECLARE_FEATURE(kSyncTrustedVaultInfobarImprovements);
|
||||
#endif // BUILDFLAG(IS_IOS)
|
||||
|
||||
} // namespace syncer
|
||||
|
||||
#endif // COMPONENTS_SYNC_BASE_FEATURES_H_
|
||||
|
@ -2627,6 +2627,12 @@ const flags_ui::FeatureEntry kFeatureEntries[] = {
|
||||
{"contained-tab-group", flag_descriptions::kContainedTabGroupName,
|
||||
flag_descriptions::kContainedTabGroupDescription, flags_ui::kOsIos,
|
||||
FEATURE_VALUE_TYPE(kContainedTabGroup)},
|
||||
{"sync-trusted-vault-infobar-improvements",
|
||||
flag_descriptions::kSyncTrustedVaultInfobarImprovementsName,
|
||||
flag_descriptions::kSyncTrustedVaultInfobarImprovementsDescription,
|
||||
flags_ui::kOsIos,
|
||||
FEATURE_VALUE_TYPE(syncer::kSyncTrustedVaultInfobarImprovements)},
|
||||
|
||||
};
|
||||
|
||||
bool SkipConditionalFeatureEntry(const flags_ui::FeatureEntry& entry) {
|
||||
|
@ -1314,6 +1314,12 @@ const char kSyncSandboxName[] = "Use Chrome Sync sandbox";
|
||||
const char kSyncSandboxDescription[] =
|
||||
"Connects to the testing server for Chrome Sync.";
|
||||
|
||||
const char kSyncTrustedVaultInfobarImprovementsName[] =
|
||||
"Trusted vault infobar UI improvements";
|
||||
const char kSyncTrustedVaultInfobarImprovementsDescription[] =
|
||||
"Enabled improvements to the UI of the trusted vault error infobar (e.g. "
|
||||
"displaying it on pages with password forms).";
|
||||
|
||||
const char kTabGroupIndicatorName[] = "Tab Group Indicator";
|
||||
const char kTabGroupIndicatorDescription[] =
|
||||
"When enabled, displays a tab group indicator next to the omnibox.";
|
||||
|
@ -780,6 +780,9 @@ extern const char kSupervisedUserLocalWebApprovalsDescription[];
|
||||
extern const char kSyncSandboxName[];
|
||||
extern const char kSyncSandboxDescription[];
|
||||
|
||||
extern const char kSyncTrustedVaultInfobarImprovementsName[];
|
||||
extern const char kSyncTrustedVaultInfobarImprovementsDescription[];
|
||||
|
||||
extern const char kTabGroupIndicatorName[];
|
||||
extern const char kTabGroupIndicatorDescription[];
|
||||
|
||||
|
Reference in New Issue
Block a user