0

BCKSF cleanup part 3.

Add registration for all factories which request service creation at
context creation time.

Bug: none
Change-Id: I865b1090855500877ac21d9fda2e0fb7cff39e4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133655
Commit-Queue: Luke Halliwell (slow) <halliwell@chromium.org>
Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Satoru Takabayashi <satorux@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757882}
This commit is contained in:
Peter Kasting
2020-04-09 16:36:44 +00:00
committed by Commit Bot
parent ace7f82178
commit c7137e24af
5 changed files with 33 additions and 1 deletions

@ -4,6 +4,7 @@
#include "apps/browser_context_keyed_service_factories.h"
#include "apps/app_lifetime_monitor_factory.h"
#include "apps/app_restore_service.h"
#include "apps/app_restore_service_factory.h"
#include "apps/saved_files_service.h"
@ -13,6 +14,7 @@
namespace apps {
void EnsureBrowserContextKeyedServiceFactoriesBuilt() {
AppLifetimeMonitorFactory::GetInstance();
AppRestoreServiceFactory::GetInstance();
}

@ -7,14 +7,18 @@
#include "chrome/browser/chromeos/account_manager/account_manager_migrator.h"
#include "chrome/browser/chromeos/android_sms/android_sms_service_factory.h"
#include "chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.h"
#include "chrome/browser/chromeos/authpolicy/authpolicy_credentials_manager.h"
#include "chrome/browser/chromeos/bluetooth/debug_logs_manager_factory.h"
#include "chrome/browser/chromeos/extensions/file_manager/event_router_factory.h"
#include "chrome/browser/chromeos/extensions/input_method_api.h"
#include "chrome/browser/chromeos/extensions/login_screen/login_state/session_state_changed_event_dispatcher.h"
#include "chrome/browser/chromeos/extensions/media_player_api.h"
#include "chrome/browser/chromeos/extensions/printing_metrics/print_job_finished_event_dispatcher.h"
#include "chrome/browser/chromeos/file_manager/volume_manager_factory.h"
#include "chrome/browser/chromeos/file_system_provider/service_factory.h"
#include "chrome/browser/chromeos/guest_os/guest_os_registry_service_factory.h"
#include "chrome/browser/chromeos/kerberos/kerberos_credentials_manager_factory.h"
#include "chrome/browser/chromeos/launcher_search_provider/launcher_search_provider_service_factory.h"
#include "chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_factory.h"
#include "chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.h"
#include "chrome/browser/chromeos/plugin_vm/plugin_vm_engagement_metrics_service.h"
@ -39,6 +43,7 @@ void EnsureBrowserContextKeyedServiceFactoriesBuilt() {
AccountManagerMigratorFactory::GetInstance();
android_sms::AndroidSmsServiceFactory::GetInstance();
arc::ArcAccessibilityHelperBridge::CreateFactory();
AuthPolicyCredentialsManagerFactory::GetInstance();
bluetooth::DebugLogsManagerFactory::GetInstance();
#if defined(USE_CUPS)
CupsProxyServiceManagerFactory::GetInstance();
@ -54,8 +59,11 @@ void EnsureBrowserContextKeyedServiceFactoriesBuilt() {
extensions::PrintJobFinishedEventDispatcher::GetFactoryInstance();
extensions::SessionStateChangedEventDispatcher::GetFactoryInstance();
file_manager::EventRouterFactory::GetInstance();
file_manager::VolumeManagerFactory::GetInstance();
file_system_provider::ServiceFactory::GetInstance();
guest_os::GuestOsRegistryServiceFactory::GetInstance();
KerberosCredentialsManagerFactory::GetInstance();
launcher_search_provider::ServiceFactory::GetInstance();
OwnerSettingsServiceChromeOSFactory::GetInstance();
plugin_vm::PluginVmEngagementMetricsService::Factory::GetInstance();
policy::PolicyCertServiceFactory::GetInstance();

@ -46,6 +46,7 @@
#include "chrome/browser/media_galleries/media_galleries_preferences_factory.h"
#include "chrome/browser/notifications/notifier_state_tracker_factory.h"
#include "chrome/browser/ntp_snippets/content_suggestions_service_factory.h"
#include "chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_service_factory.h"
#include "chrome/browser/password_manager/password_store_factory.h"
#include "chrome/browser/permissions/adaptive_quiet_notification_permission_ui_enabler.h"
#include "chrome/browser/plugins/plugin_prefs_factory.h"
@ -53,6 +54,7 @@
#include "chrome/browser/predictors/autocomplete_action_predictor_factory.h"
#include "chrome/browser/predictors/loading_predictor_factory.h"
#include "chrome/browser/predictors/predictor_database_factory.h"
#include "chrome/browser/prefs/pref_metrics_service.h"
#include "chrome/browser/prerender/prerender_link_manager_factory.h"
#include "chrome/browser/prerender/prerender_manager_factory.h"
#include "chrome/browser/prerender/prerender_message_filter.h"
@ -265,6 +267,7 @@ void ChromeBrowserMainExtraPartsProfiles::
HistoryServiceFactory::GetInstance();
HistoryUiFaviconRequestHandlerFactory::GetInstance();
HostContentSettingsMapFactory::GetInstance();
HttpsEngagementServiceFactory::GetInstance();
IdentityManagerFactory::EnsureFactoryAndDependeeFactoriesBuilt();
InMemoryURLIndexFactory::GetInstance();
#if !defined(OS_ANDROID)
@ -305,6 +308,7 @@ void ChromeBrowserMainExtraPartsProfiles::
#if BUILDFLAG(ENABLE_PLUGINS)
PluginPrefsFactory::GetInstance();
#endif
PrefMetricsService::Factory::GetInstance();
PrefsTabHelper::GetServiceInstance();
policy::UserCloudPolicyInvalidatorFactory::GetInstance();
#if !defined(OS_CHROMEOS)

@ -121,6 +121,7 @@
#if BUILDFLAG(ENABLE_CHROMECAST_EXTENSIONS)
#include "chromecast/browser/extensions/api/tts/tts_extension_api.h"
#include "chromecast/browser/extensions/cast_extension_system.h"
#include "chromecast/browser/extensions/cast_extension_system_factory.h"
#include "chromecast/browser/extensions/cast_extensions_browser_client.h"
#include "chromecast/browser/extensions/cast_prefs.h"
#include "chromecast/common/cast_extensions_client.h"
@ -378,6 +379,17 @@ void AddDefaultCommandLineSwitches(base::CommandLine* command_line) {
}
}
#if BUILDFLAG(ENABLE_CHROMECAST_EXTENSIONS)
// Instantiates all cast KeyedService factories, which is especially important
// for services that should be created at profile creation time as compared to
// lazily on first access.
void EnsureBrowserContextKeyedServiceFactoriesBuilt() {
extensions::EnsureBrowserContextKeyedServiceFactoriesBuilt();
extensions::CastExtensionSystemFactory::GetInstance();
}
#endif
} // namespace
CastBrowserMainParts::CastBrowserMainParts(
@ -627,7 +639,7 @@ void CastBrowserMainParts::PreMainMessageLoopRun() {
cast_content_browser_client_->cast_network_contexts());
extensions::ExtensionsBrowserClient::Set(extensions_browser_client_.get());
extensions::EnsureBrowserContextKeyedServiceFactoriesBuilt();
EnsureBrowserContextKeyedServiceFactoriesBuilt();
extensions::CastExtensionSystem* extension_system =
static_cast<extensions::CastExtensionSystem*>(

@ -34,6 +34,7 @@
#include "extensions/browser/api/usb/usb_device_resource.h"
#include "extensions/browser/api/web_request/web_request_api.h"
#include "extensions/browser/app_window/app_window_geometry_cache.h"
#include "extensions/browser/app_window/app_window_registry.h"
#include "extensions/browser/declarative_user_script_manager_factory.h"
#include "extensions/browser/event_router_factory.h"
#include "extensions/browser/extension_message_filter.h"
@ -51,6 +52,10 @@
#include "extensions/browser/api/webcam_private/webcam_private_api.h"
#endif
#if defined(OS_CHROMEOS)
#include "extensions/browser/api/system_power_source/system_power_source_api.h"
#endif
namespace extensions {
void EnsureBrowserContextKeyedServiceFactoriesBuilt() {
@ -62,6 +67,7 @@ void EnsureBrowserContextKeyedServiceFactoriesBuilt() {
ApiResourceManager<Socket>::GetFactoryInstance();
ApiResourceManager<UsbDeviceResource>::GetFactoryInstance();
AppWindowGeometryCache::Factory::GetInstance();
AppWindowRegistry::Factory::GetInstance();
AudioAPI::GetFactoryInstance();
BluetoothAPI::GetFactoryInstance();
BluetoothPrivateAPI::GetFactoryInstance();