chromium/src
0
Fork 0
Code Activity

Fixes bug in WidgetGtk. WidgetGtk::GetBounds can end up crashing. I

Browse Source 
believe returning a location of 0x0 is effectively what Windows does
too in this situation.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/525105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35805 0039d316-1c4b-4281-b951-d872f2087c98
This commit is contained in:
sky@chromium.org
2010-01-08 19:12:41 +00:00
parent fb0b70ed56
commit c786d8d4b8
1 changed files with 6 additions and 1 deletions

7
views/widget/widget_gtk.cc

@ -66,7 +66,12 @@ static void GetWidgetPositionOnScreen(GtkWidget* widget, int* x, int *y) {
while (root && !GTK_IS_WINDOW(root)) {
root = gtk_widget_get_parent(root);
}
DCHECK(root);
if (!root) {
// If root is null we're not parented. Return 0x0 and assume the caller will
// query again when we're parented.
*x = *y = 0;
return;
}
// Translate the coordinate from widget to root window.
gtk_widget_translate_coordinates(widget, root, 0, 0, x, y);
// Then adjust the position with the position of the root window.