0

[PA] Move README, OWNERS, DEPS, BUILD.gn to top-level dir.

This is a follow-up to:
https://chromium-review.googlesource.com/c/chromium/src/+/4812338

The previous patch moved the whole PA directory into
"src/partition_alloc" without putting much thinking about individual
files.

This follow-up moves the README, OWNERS, DEPS, BUILD.gn file into the
top-level directory.

Bug: chromium:1467773
Change-Id: Ie9f457fe957bbf27779892eece606eb220d50cb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4934632
Owners-Override: danakj <danakj@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Takashi Sakamoto <tasak@google.com>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1210356}
This commit is contained in:
Arthur Sonzogni
2023-10-16 19:08:55 +00:00
committed by Chromium LUCI CQ
parent 44e4fdb434
commit c8ca465242
32 changed files with 47 additions and 41 deletions
base
build_overrides
components
cronet
gwp_asan
buildflags
client
content/browser
docs/memory-infra
gin
ios/chrome/app
third_party/blink/renderer/platform/wtf
tools/memory/partition_allocator

@ -18,8 +18,7 @@
# huge sequence of random-looking conditionals.
import("//base/allocator/allocator.gni")
import(
"//base/allocator/partition_allocator/src/partition_alloc/partition_alloc.gni")
import("//base/allocator/partition_allocator/partition_alloc.gni")
import("//base/debug/debug.gni")
import("//base/trace_event/tracing.gni")
import("//build/buildflag_header.gni")
@ -1040,7 +1039,7 @@ component("base") {
deps = [
":message_pump_buildflags",
"//base/allocator:buildflags",
"//base/allocator/partition_allocator/src/partition_alloc:raw_ptr",
"//base/allocator/partition_allocator:raw_ptr",
"//base/third_party/double_conversion",
"//base/third_party/dynamic_annotations",
"//build:blink_buildflags",
@ -1079,8 +1078,8 @@ component("base") {
":sanitizer_buildflags",
":synchronization_buildflags",
":tracing_buildflags",
"//base/allocator/partition_allocator/src/partition_alloc:buildflags",
"//base/allocator/partition_allocator/src/partition_alloc:raw_ptr",
"//base/allocator/partition_allocator:buildflags",
"//base/allocator/partition_allocator:raw_ptr",
"//base/numerics:base_numerics",
"//build:chromecast_buildflags",
"//build:chromeos_buildflags",
@ -1707,8 +1706,8 @@ component("base") {
# partition_alloc code if use_partition_alloc = false because no code uses
# partition_alloc.
public_deps += [
"allocator/partition_allocator/src/partition_alloc",
"allocator/partition_allocator/src/partition_alloc:raw_ptr",
"allocator/partition_allocator:partition_alloc",
"allocator/partition_allocator:raw_ptr",
]
}
@ -5073,7 +5072,7 @@ source_set("partition_alloc_test_support") {
sources += [ "allocator/partition_allocator/src/partition_alloc/partition_alloc_base/threading/platform_thread_android_for_testing.cc" ]
}
public_deps = [
"allocator/partition_allocator/src/partition_alloc:buildflags",
"allocator/partition_allocator:buildflags",
"//build:branding_buildflags",
"//build/config/compiler:compiler_buildflags",
]

@ -3,8 +3,7 @@
# found in the LICENSE file.
import("//base/allocator/allocator.gni")
import(
"//base/allocator/partition_allocator/src/partition_alloc/partition_alloc.gni")
import("//base/allocator/partition_allocator/partition_alloc.gni")
import("//build/buildflag_header.gni")
import("//build/config/compiler/compiler.gni")
import("//build/config/dcheck_always_on.gni")
@ -26,7 +25,7 @@ if (is_apple) {
deps = [
":buildflags",
"//base/allocator/partition_allocator/src/partition_alloc:buildflags",
"//base/allocator/partition_allocator:buildflags",
]
}
}

@ -2,6 +2,6 @@ lizeb@chromium.org
primiano@chromium.org
wfh@chromium.org
per-file allocator.gni=file://base/allocator/partition_allocator/src/partition_alloc/OWNERS
per-file partition_alloc*=file://base/allocator/partition_allocator/src/partition_alloc/OWNERS
per-file BUILD.gn=file://base/allocator/partition_allocator/src/partition_alloc/OWNERS
per-file allocator.gni=file://base/allocator/partition_allocator/OWNERS
per-file partition_alloc*=file://base/allocator/partition_allocator/OWNERS
per-file BUILD.gn=file://base/allocator/partition_allocator/OWNERS

@ -2,8 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import(
"//base/allocator/partition_allocator/src/partition_alloc/partition_alloc.gni")
import("//base/allocator/partition_allocator/partition_alloc.gni")
# Chromium-specific asserts. External embedders _may_ elect to use these
# features even without PA-E.

@ -0,0 +1,15 @@
# Copyright 2024 The Chromium Authors
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
group("raw_ptr") {
public_deps = [ "src/partition_alloc:raw_ptr" ]
}
group("partition_alloc") {
public_deps = [ "src/partition_alloc:partition_alloc" ]
}
group("buildflags") {
public_deps = [ "src/partition_alloc:buildflags" ]
}

@ -8,7 +8,7 @@ different settings. Broadly, these are controlled at the top-level by
*** promo
Most of what you'll want to know exists between
* [`//base/allocator/partition_allocator/src/partition_alloc/BUILD.gn`][pa-build-gn],
* [`//base/allocator/partition_allocator/BUILD.gn`][pa-build-gn],
* Everything else ending in `.gn` or `.gni` in
`//base/allocator/partition_allocator/src/partition_alloc/`,
* [`allocator.gni`][allocator-gni],
@ -93,7 +93,7 @@ that influence PartitionAlloc's behavior.
[gn-declare-args]: https://gn.googlesource.com/gn/+/refs/heads/main/docs/reference.md#func_declare_args
[buildflag-header]: https://source.chromium.org/chromium/chromium/src/+/main:build/buildflag_header.gni
[pa-build-gn]: https://source.chromium.org/chromium/chromium/src/+/main:base/allocator/partition_allocator/src/partition_alloc/BUILD.gn
[pa-build-gn]: https://source.chromium.org/chromium/chromium/src/+/main:base/allocator/partition_allocator/BUILD.gn
[allocator-gni]: https://source.chromium.org/chromium/chromium/src/+/main:base/allocator/allocator.gni
[base-allocator-build-gn]: https://source.chromium.org/chromium/chromium/src/+/main:base/allocator/BUILD.gn
[base-build-gn]: https://source.chromium.org/chromium/chromium/src/+/main:base/BUILD.gn

@ -2,8 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import(
"//base/allocator/partition_allocator/src/partition_alloc/partition_alloc.gni")
import("//build/buildflag_header.gni")
import("//build/config/android/config.gni")
import("//build/config/chromecast_build.gni")
@ -11,6 +9,7 @@ import("//build/config/chromeos/ui_mode.gni")
import("//build/config/compiler/compiler.gni")
import("//build/config/dcheck_always_on.gni")
import("//build/config/logging.gni")
import("../../partition_alloc.gni")
# Add partition_alloc.gni and import it for partition_alloc configs.

@ -74,7 +74,7 @@ class EncodedFreelistPtr {
};
// Freelist entries are encoded for security reasons. See
// //base/allocator/partition_allocator/src/partition_alloc/PartitionAlloc.md
// //base/allocator/partition_allocator/PartitionAlloc.md
// and |Transform()| for the rationale and mechanism, respectively.
class EncodedNextFreelistEntry {
private:

@ -3,4 +3,4 @@ file://build/OWNERS
machenbach@chromium.org
mbonadei@chromium.org
per-file partition_alloc.*=file://base/allocator/partition_allocator/src/partition_alloc/OWNERS
per-file partition_alloc.*=file://base/allocator/partition_allocator/OWNERS

@ -5,7 +5,7 @@
# This defines PartitionAlloc's default build configuration for chromium.
# If building PartitionAlloc as a part of chromium,
# //build_overrides/partition_alloc.gni points out this file.
# //base/allocator/partition_allocator/src/partition_alloc/partition_alloc.gni will import
# //base/allocator/partition_allocator/partition_alloc.gni will import
# this file and will use the defined values as default build configuration.
#
# partition_alloc.gni declares the following variables:

@ -2,8 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import(
"//base/allocator/partition_allocator/src/partition_alloc/partition_alloc.gni")
import("//base/allocator/partition_allocator/partition_alloc.gni")
# Enable use of Javascript in PDFs.
pdf_enable_v8_override = true

@ -1,5 +1,6 @@
//base
//base/allocator
//base/allocator/partition_allocator
//base/allocator/partition_allocator/src/partition_alloc
//base/android/jni_generator
//base/numerics

@ -3,8 +3,7 @@
# found in the LICENSE file.
import("//base/allocator/allocator.gni")
import(
"//base/allocator/partition_allocator/src/partition_alloc/partition_alloc.gni")
import("//base/allocator/partition_allocator/partition_alloc.gni")
import("//build/config/compiler/compiler.gni")
# Windows/32-bit is disabled due to https://crbug.com/969146

@ -3,8 +3,7 @@
# found in the LICENSE file.
import("//base/allocator/allocator.gni")
import(
"//base/allocator/partition_allocator/src/partition_alloc/partition_alloc.gni")
import("//base/allocator/partition_allocator/partition_alloc.gni")
config("gwp_asan_implementation") {
defines = [ "GWP_ASAN_IMPLEMENTATION" ]

@ -2,8 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import(
"//base/allocator/partition_allocator/src/partition_alloc/partition_alloc.gni")
import("//base/allocator/partition_allocator/partition_alloc.gni")
import("//build/buildflag_header.gni")
import("//build/config/chromeos/ui_mode.gni")
import("//build/config/chromeos/ui_mode.gni")

@ -95,7 +95,7 @@ and it is discounted from malloc and the blue columns.
[discardable]:base/memory/discardable_memory.h
[cc-memory]: probe-cc.md
[gpu-memory]: probe-gpu.md
[partalloc]: /base/allocator/partition_allocator/src/partition_alloc/PartitionAlloc.md
[partalloc]: /base/allocator/partition_allocator/PartitionAlloc.md
## 'effective\_size' vs. 'size'

@ -5,8 +5,7 @@
if (is_android) {
import("//build/config/android/rules.gni")
}
import(
"//base/allocator/partition_allocator/src/partition_alloc/partition_alloc.gni")
import("//base/allocator/partition_allocator/partition_alloc.gni")
import("//testing/test.gni")
import("//tools/v8_context_snapshot/v8_context_snapshot.gni")
import("//v8/gni/v8.gni")

@ -15,4 +15,4 @@ per-file thread_isolation.*=sroettger@google.com
per-file v8_platform_thread_isolated_allocator.*=sroettger@google.com
# For PartitionAlloc related changes.
per-file array_buffer.cc=file://base/allocator/partition_allocator/src/partition_alloc/OWNERS
per-file array_buffer.cc=file://base/allocator/partition_allocator/OWNERS

@ -128,7 +128,7 @@ template("chrome_app") {
deps = [
"//base/allocator:early_zone_registration_apple",
"//base/allocator/partition_allocator/src/partition_alloc:partition_alloc_buildflags",
"//base/allocator/partition_allocator:buildflags",
"//ios/chrome/app:chrome_main_module_buildflags",
]

@ -31,7 +31,7 @@ When you simply call `new` or `malloc` PartitionAlloc will be used, unless
are specified.
The implementation is in /base/allocator/partition_allocator.
See [PartitionAlloc.md](/base/allocator/partition_allocator/src/partition_alloc/PartitionAlloc.md)
See [PartitionAlloc.md](/base/allocator/partition_allocator/PartitionAlloc.md)
to learn the design.
#### `USING_FAST_MALLOC`

@ -3,4 +3,4 @@ mlippautz@chromium.org
thakis@chromium.org
tkent@chromium.org
per-file allocator/*=file://base/allocator/partition_allocator/src/partition_alloc/OWNERS
per-file allocator/*=file://base/allocator/partition_allocator/OWNERS

@ -2,8 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import(
"//base/allocator/partition_allocator/src/partition_alloc/partition_alloc.gni")
import("//base/allocator/partition_allocator/partition_alloc.gni")
# Only support x86_64 Linux as the system calls used are Linux-specific. No
# point in building this if PartitionAlloc is not the allocator used.

@ -1 +1 @@
file://base/allocator/partition_allocator/src/partition_alloc/OWNERS
file://base/allocator/partition_allocator/OWNERS