chromium/src
0
Fork 0
Code Activity

components: Remove chromeos_buildflags build dependencies

Browse Source 
After [1], the only build target (under components/) that needs chromeos_buildflags is //components/crash/core/app. Remove the
dependency from all others.

[1]https://chromium-review.googlesource.com/c/chromium/src/+/6108703/

Bug: b:354842935
Change-Id: I537ea10ab943374fe9793767a5461b71ecbcf52b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6109205
Reviewed-by: Jun Ishiguro <junis@google.com>
Owners-Override: Georg Neis <neis@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1400012}
This commit is contained in:
Georg Neis
2024-12-24 01:15:11 -08:00
committed by Chromium LUCI CQ
parent 0f98ad7c50
commit c91f08f907
38 changed files with 7 additions and 76 deletions
components
BUILD.gn
about_ui
BUILD.gn
account_manager_core
BUILD.gn
blocked_content
BUILD.gn
cloud_devices
common
BUILD.gn
content_settings
browser
BUILD.gn
core
browser
BUILD.gn
custom_handlers
BUILD.gn
javascript_dialogs
BUILD.gn
memory_pressure
BUILD.gn
memory_system
BUILD.gn
metrics_services_manager
BUILD.gn
mirroring
service
BUILD.gn
net_log
BUILD.gn
optimization_guide
core
BUILD.gn
os_crypt
sync
BUILD.gn
page_load_metrics
browser
BUILD.gn
paint_preview
browser
BUILD.gn
payments
content
BUILD.gn
core
BUILD.gn
policy
core
browser
BUILD.gn
common
BUILD.gn
prefs
BUILD.gn
reporting
storage
BUILD.gn
safe_browsing
content
common
BUILD.gn
core
browser
realtime
BUILD.gn
common
BUILD.gn
services
font
BUILD.gn
signin
core
browser
BUILD.gn
internal
identity_manager
BUILD.gn
public
base
BUILD.gn
identity_manager
BUILD.gn
sync
BUILD.gn
base
BUILD.gn
service
BUILD.gn
sync_device_info
BUILD.gn
variations
BUILD.gn
service
BUILD.gn

1
components/BUILD.gn

@ -1165,7 +1165,6 @@ if (use_blink) {
if (enable_printing) {
sources += [ "printing/test/print_render_frame_helper_browsertest.cc" ]
deps += [
"//build:chromeos_buildflags",
"//components/printing/browser",
"//components/printing/common:mojo_interfaces",
"//components/printing/test:test_support",

1
components/about_ui/BUILD.gn

@ -9,7 +9,6 @@ static_library("about_ui") {
]
deps = [
"//base",
"//build:chromeos_buildflags",
"//components/resources:components_resources",
"//ui/base",
"//ui/resources",

1
components/account_manager_core/BUILD.gn

@ -36,7 +36,6 @@ component("account_manager_core") {
deps = [
"//base",
"//build:chromeos_buildflags",
"//chromeos/crosapi/mojom",
"//components/prefs:prefs",
"//google_apis:google_apis",

1
components/blocked_content/BUILD.gn

@ -24,7 +24,6 @@ source_set("blocked_content") {
]
deps = [
"//base",
"//build:chromeos_buildflags",
"//components/back_forward_cache",
"//components/content_settings/browser",
"//components/content_settings/core/browser",

2
components/cloud_devices/common/BUILD.gn

@ -16,7 +16,6 @@ static_library("common") {
]
deps = [
"//base",
"//build:chromeos_buildflags",
"//ui/gfx/geometry",
]
}
@ -29,7 +28,6 @@ source_set("unit_tests") {
":common",
"//base",
"//base/test:test_support",
"//build:chromeos_buildflags",
"//testing/gmock",
"//testing/gtest",
"//ui/gfx/geometry",

1
components/content_settings/browser/BUILD.gn

@ -11,7 +11,6 @@ source_set("browser") {
]
deps = [
"//base",
"//build:chromeos_buildflags",
"//components/browsing_data/content",
"//components/browsing_data/core:core",
"//components/content_settings/common:mojom",

3
components/content_settings/core/browser/BUILD.gn

@ -52,7 +52,6 @@ static_library("browser") {
public_deps = [ "//base" ]
deps = [
"//build:blink_buildflags",
"//build:chromeos_buildflags",
"//components/content_settings/core/common",
"//components/keyed_service/core",
"//components/pref_registry:pref_registry",
@ -104,7 +103,6 @@ source_set("cookie_settings") {
deps = [
":browser",
"//build:blink_buildflags",
"//build:chromeos_buildflags",
"//components/content_settings/core/common",
"//components/keyed_service/core",
"//components/policy/core/browser",
@ -140,7 +138,6 @@ source_set("unit_tests") {
":browser",
"//base",
"//base/test:test_support",
"//build:chromeos_buildflags",
"//components/content_settings/core/common",
"//components/content_settings/core/test:test_support",
"//components/pref_registry:pref_registry",

1
components/custom_handlers/BUILD.gn

@ -15,7 +15,6 @@ static_library("custom_handlers") {
]
deps = [
"//build:chromeos_buildflags",
"//components/keyed_service/content",
"//components/keyed_service/core",
"//components/pref_registry",

5
components/javascript_dialogs/BUILD.gn

@ -49,10 +49,7 @@ static_library("javascript_dialogs") {
"views/app_modal_dialog_view_views.h",
]
deps += [
"//build:chromeos_buildflags",
"//ui/views",
]
deps += [ "//ui/views" ]
}
if (is_android) {

5
components/memory_pressure/BUILD.gn

@ -19,10 +19,7 @@ source_set("memory_pressure") {
"unnecessary_discard_monitor.h",
]
deps = [
"//base",
"//build:chromeos_buildflags",
]
deps = [ "//base" ]
if (is_win) {
sources += [

4
components/memory_system/BUILD.gn

@ -59,10 +59,6 @@ source_set("memory_system") {
deps += [ "//components/gwp_asan/client:features" ]
}
if (is_chromeos) {
deps += [ "//build:chromeos_buildflags" ]
}
is_heap_profiling_supported = !is_ios || use_allocator_shim
if (is_heap_profiling_supported) {

3
components/metrics_services_manager/BUILD.gn

@ -13,11 +13,10 @@ static_library("metrics_services_manager") {
deps = [
"//base",
"//build:chromeos_buildflags",
"//components/metrics",
"//components/metrics/dwa",
"//components/metrics/structured",
"//components/ukm",
"//components/metrics/dwa",
"//components/variations",
"//components/variations/service",
"//services/network/public/cpp:cpp",

1
components/mirroring/service/BUILD.gn

@ -39,7 +39,6 @@ component("mirroring_service") {
public_deps = [ "//base" ]
deps = [
"//build:chromeos_buildflags",
"//components/mirroring/mojom:service",
"//components/openscreen_platform",
"//crypto",

1
components/net_log/BUILD.gn

@ -32,7 +32,6 @@ source_set("unit_tests") {
":net_log",
"//base",
"//base/test:test_support",
"//build:chromeos_buildflags",
"//net",
"//net:test_support",
"//services/network:network_service",

1
components/optimization_guide/core/BUILD.gn

@ -572,7 +572,6 @@ source_set("unit_tests") {
"//base",
"//base/test:test_proto",
"//base/test:test_support",
"//build:chromeos_buildflags",
"//components/download/public/background_service/test:test_support",
"//components/leveldb_proto:test_support",
"//components/optimization_guide/proto:optimization_guide_proto",

2
components/os_crypt/sync/BUILD.gn

@ -25,7 +25,6 @@ component("os_crypt") {
"//base",
"//build:branding_buildflags",
"//build:chromecast_buildflags",
"//build:chromeos_buildflags",
"//components/prefs",
"//crypto",
]
@ -126,7 +125,6 @@ source_set("unit_tests") {
"//base",
"//base/test:test_support",
"//build:branding_buildflags",
"//build:chromeos_buildflags",
"//components/prefs:test_support",
"//crypto",
"//testing/gmock",

1
components/page_load_metrics/browser/BUILD.gn

@ -89,7 +89,6 @@ source_set("browser") {
]
deps = [
"//base",
"//build:chromeos_buildflags",
"//components/keyed_service/content:content",
"//components/keyed_service/core:core",
"//components/metrics",

1
components/paint_preview/browser/BUILD.gn

@ -97,7 +97,6 @@ source_set("unit_tests") {
":test_support",
"//base",
"//base/test:test_support",
"//build:chromeos_buildflags",
"//components/paint_preview/common:test_utils",
"//components/version_info",
"//content/public/browser",

1
components/payments/content/BUILD.gn

@ -66,7 +66,6 @@ static_library("content") {
":content_common",
":utils",
"//base",
"//build:chromeos_buildflags",
"//components/autofill/core/browser",
"//components/keyed_service/content",
"//components/payments/content/browser_binding",

1
components/payments/core/BUILD.gn

@ -86,7 +86,6 @@ static_library("core") {
":method_strings",
"//base",
"//build:blink_buildflags",
"//build:chromeos_buildflags",
"//components/autofill/core/browser",
"//components/keyed_service/core",
"//components/link_header_util",

1
components/policy/core/browser/BUILD.gn

@ -80,7 +80,6 @@ source_set("internal") {
public_deps = [ "//base" ]
deps = [
"//build:branding_buildflags",
"//build:chromeos_buildflags",
"//components/google/core/common",
"//components/invalidation/impl",
"//components/keyed_service/core",

17
components/policy/core/common/BUILD.gn

@ -44,10 +44,7 @@ source_set("util") {
"//components/version_info",
]
deps = [
"//base",
"//build:chromeos_buildflags",
]
deps = [ "//base" ]
if (is_chromeos) {
deps += [ "//components/user_manager" ]
@ -238,7 +235,6 @@ source_set("internal") {
deps = [
"//base:i18n",
"//build:chromeos_buildflags",
"//components/account_id",
"//components/enterprise/common:strings",
"//components/prefs",
@ -487,18 +483,12 @@ static_library("test_support") {
"//testing/gtest",
]
deps = [
"//build:chromeos_buildflags",
"//services/network:test_support",
]
deps = [ "//services/network:test_support" ]
}
source_set("common_constants") {
configs += [ "//components/policy:component_implementation" ]
deps = [
"//base",
"//build:chromeos_buildflags",
]
deps = [ "//base" ]
sources = [
"../../policy_export.h",
"cloud/cloud_policy_constants.cc",
@ -663,7 +653,6 @@ source_set("unit_tests") {
":test_support",
"//base",
"//base/test:test_support",
"//build:chromeos_buildflags",
"//components/account_id",
"//components/invalidation:test_support",
"//components/invalidation/impl:test_support",

3
components/prefs/BUILD.gn

@ -58,8 +58,7 @@ component("prefs") {
defines = [ "COMPONENTS_PREFS_IMPLEMENTATION" ]
deps = [ "//build:chromeos_buildflags" ]
deps = []
public_deps = [ "//base" ]
if (is_android) {

1
components/reporting/storage/BUILD.gn

@ -162,7 +162,6 @@ source_set("unit_tests") {
":test_support",
"//base",
"//base/test:test_support",
"//build:chromeos_buildflags",
"//components/reporting/compression:compression_module",
"//components/reporting/compression:test_support",
"//components/reporting/encryption:decryption",

1
components/safe_browsing/content/common/BUILD.gn

@ -84,7 +84,6 @@ if (safe_browsing_mode != 0) {
":file_type_policies",
":file_type_policies_test_support",
"//base:base",
"//build:chromeos_buildflags",
"//components/policy/core/browser:test_support",
"//components/prefs:test_support",
"//testing/gmock:gmock",

1
components/safe_browsing/core/browser/realtime/BUILD.gn

@ -65,7 +65,6 @@ static_library("url_lookup_service_base") {
deps = [
"//base:base",
"//build:chromeos_buildflags",
"//components/enterprise/common/proto:connectors_proto",
"//components/keyed_service/core",
"//components/prefs",

2
components/safe_browsing/core/common/BUILD.gn

@ -89,7 +89,6 @@ source_set("common") {
deps = [
"//base",
"//build:chromeos_buildflags",
"//components/policy/core/browser:browser",
"//components/prefs:prefs",
"//components/safe_browsing:buildflags",
@ -120,7 +119,6 @@ source_set("features") {
deps = [
"//base",
"//build:chromeos_buildflags",
"//components/safe_browsing:buildflags",
]
}

1
components/services/font/BUILD.gn

@ -16,7 +16,6 @@ source_set("lib") {
deps = [
"//base",
"//build:chromeos_buildflags",
"//components/services/font/public/mojom",
"//mojo/public/cpp/bindings",
"//mojo/public/cpp/system",

2
components/signin/core/browser/BUILD.gn

@ -64,7 +64,6 @@ static_library("browser") {
]
deps = [
"//base:i18n",
"//build:chromeos_buildflags",
"//components/google/core/common",
"//components/metrics",
"//components/os_crypt/sync",
@ -127,7 +126,6 @@ source_set("unit_tests") {
":browser",
"//base",
"//base/test:test_support",
"//build:chromeos_buildflags",
"//components/content_settings/core/browser",
"//components/prefs",
"//components/prefs:test_support",

2
components/signin/internal/identity_manager/BUILD.gn

@ -62,7 +62,6 @@ source_set("identity_manager") {
]
deps = [
"//build:chromeos_buildflags",
"//components/image_fetcher/core",
"//components/prefs",
"//components/signin/public/identity_manager:tribool",
@ -175,7 +174,6 @@ source_set("unit_tests") {
":test_support",
"//base",
"//base/test:test_support",
"//build:chromeos_buildflags",
"//components/image_fetcher/core",
"//components/image_fetcher/core:test_support",
"//components/os_crypt/async/browser:test_support",

4
components/signin/public/base/BUILD.gn

@ -53,7 +53,6 @@ static_library("base") {
"wait_for_network_callback_helper.h",
]
deps = [
"//build:chromeos_buildflags",
"//components/prefs",
"//third_party/boringssl",
"//third_party/icu:icui18n",
@ -123,7 +122,6 @@ static_library("test_support") {
deps = [
"//base/test:test_support",
"//build:chromeos_buildflags",
"//components/prefs",
# TODO(b/309104936): Remove this unwanted dependency.
@ -163,7 +161,6 @@ source_set("unit_tests") {
":test_support",
"//base",
"//base/test:test_support",
"//build:chromeos_buildflags",
"//components/prefs:test_support",
"//components/sync_preferences:test_support",
"//testing/gtest",
@ -186,7 +183,6 @@ component("signin_switches") {
deps = [
":signin_buildflags",
"//base",
"//build:chromeos_buildflags",
"//components/prefs",
]
}

3
components/signin/public/identity_manager/BUILD.gn

@ -59,7 +59,6 @@ source_set("identity_manager") {
]
deps = [
"//build:chromeos_buildflags",
"//components/image_fetcher/core",
"//components/plus_addresses:features",
"//components/prefs",
@ -130,7 +129,6 @@ source_set("unit_tests") {
":test_support",
"//base",
"//base/test:test_support",
"//build:chromeos_buildflags",
"//components/image_fetcher/core:test_support",
"//components/prefs",
"//components/prefs:test_support",
@ -186,7 +184,6 @@ source_set("test_support") {
]
deps = [
"//build:chromeos_buildflags",
"//components/image_fetcher/core:test_support",
"//components/signin/internal/identity_manager",
"//components/signin/internal/identity_manager:test_support",

2
components/sync/BUILD.gn

@ -144,7 +144,6 @@ static_library("test_support") {
deps = [
"//base",
"//base/test:test_support",
"//build:chromeos_buildflags",
"//components/bookmarks/browser",
"//components/pref_registry",
"//components/prefs:test_support",
@ -274,7 +273,6 @@ source_set("unit_tests") {
":test_support",
"//base",
"//base/test:test_support",
"//build:chromeos_buildflags",
"//components/gcm_driver:test_support",
"//components/os_crypt/sync",
"//components/os_crypt/sync:test_support",

1
components/sync/base/BUILD.gn

@ -92,7 +92,6 @@ static_library("base") {
deps = [
"//base",
"//base:i18n",
"//build:chromeos_buildflags",
"//components/pref_registry",
"//components/prefs",
"//components/signin/public/base",

1
components/sync/service/BUILD.gn

@ -102,7 +102,6 @@ static_library("service") {
deps = [
"//base",
"//base:i18n",
"//build:chromeos_buildflags",
"//components/keyed_service/core",
"//components/metrics",
"//components/os_crypt/sync",

2
components/sync_device_info/BUILD.gn

@ -46,7 +46,6 @@ static_library("sync_device_info") {
"//components/sync/protocol",
]
deps = [
"//build:chromeos_buildflags",
"//components/keyed_service/core",
"//components/metrics",
"//components/prefs",
@ -128,7 +127,6 @@ source_set("unit_tests") {
":test_support",
"//base",
"//base/test:test_support",
"//build:chromeos_buildflags",
"//components/prefs:test_support",
"//components/sync:test_support",
"//components/version_info:version_string",

1
components/variations/BUILD.gn

@ -140,7 +140,6 @@ component("variations") {
":buildflags",
":variations_mojom",
"proto",
"//build:chromeos_buildflags",
"//components/crash/core/common:crash_key",
"//components/prefs",
"//components/version_info",

1
components/variations/service/BUILD.gn

@ -64,7 +64,6 @@ static_library("service") {
":buildflags",
"//base/version_info:channel",
"//build:branding_buildflags",
"//build:chromeos_buildflags",
"//build/config/chromebox_for_meetings:buildflags",
"//components/country_codes",
"//components/encrypted_messages",