chromium/src
0
Fork 0
Code Activity

Cleanup DynamicAudioTimeout study

Browse Source 
This CL removes the DynamicAudioTimeout study, which launched in 2022.

Fixed: 374073842
Change-Id: I4804ca3ff945bbea0f2fb39fabf54fd66a3e2467
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5953270
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1372796}
This commit is contained in:
Thomas Guilbert
2024-10-23 17:07:40 +00:00
committed by Chromium LUCI CQ
parent 7bb08efb30
commit c96a967e76
1 changed files with 4 additions and 18 deletions

22
services/audio/sync_reader.cc

@ -31,12 +31,9 @@ namespace audio {
#if !BUILDFLAG(IS_MAC) && !BUILDFLAG(IS_CHROMEOS_ASH) && \
!BUILDFLAG(IS_CHROMEOS_LACROS)
BASE_FEATURE(kDynamicAudioTimeout,
"DynamicAudioTimeout",
base::FEATURE_ENABLED_BY_DEFAULT);
const base::FeatureParam<double> kBufferDurationPercent{
&kDynamicAudioTimeout, "buffer_duration_percent", 0.95};
constexpr double kBufferDurationPercent = 0.95;
#else
constexpr double kBufferDurationPercent = 0.5;
#endif
SyncReader::SyncReader(
@ -60,20 +57,9 @@ SyncReader::SyncReader(
output_bus_buffer_size_(
media::AudioBus::CalculateMemorySize(params.channels(),
params.frames_per_buffer())),
maximum_wait_time_(params.GetBufferDuration() * kBufferDurationPercent),
read_timeout_glitch_{.duration = params.GetBufferDuration(), .count = 1},
glitch_counter_(std::move(glitch_counter)) {
#if BUILDFLAG(IS_MAC) || BUILDFLAG(IS_CHROMEOS_ASH) || \
BUILDFLAG(IS_CHROMEOS_LACROS)
maximum_wait_time_ = params.GetBufferDuration() / 2;
#else
if (base::FeatureList::IsEnabled(kDynamicAudioTimeout)) {
maximum_wait_time_ =
params.GetBufferDuration() * kBufferDurationPercent.Get();
} else {
maximum_wait_time_ = base::Milliseconds(20);
}
#endif
base::CheckedNumeric<size_t> memory_size =
media::ComputeAudioOutputBufferSizeChecked(params);
if (!memory_size.IsValid())