0

Updated the bucket to UmaHistogramLongTimes100.

In the previous CL, I thought the value is usually less than 3 minutes.
However, upon some data, we actually need much larger buckets than this.

OBSOLETE_HISTOGRAMS=NQE.RTT.ObservationBufferLifeTime.{Category} is replaced by NQE.RTT.ObservationBufferLifeTime2.{Category}

Bug: 351092743
Change-Id: Ida1e074b179a0f2e2cced4308bea046c4dcadea4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5717095
Reviewed-by: Keita Suzuki <suzukikeita@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Minoru Chikamune <chikamune@chromium.org>
Reviewed-by: Shunya Shishido <sisidovski@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1330055}
This commit is contained in:
Yoshisato Yanagisawa
2024-07-19 05:57:49 +00:00
committed by Chromium LUCI CQ
parent 8b3a500e97
commit c9b8916bd4
2 changed files with 6 additions and 5 deletions
net/nqe
tools/metrics/histograms/metadata/others

@ -1167,12 +1167,12 @@ void NetworkQualityEstimator::AddAndNotifyObserversOfRTT(
rtt_ms_observations_[observation_category].AddObservation(observation);
if (evicted) {
auto delta = base::TimeTicks::Now() - evicted->timestamp();
base::UmaHistogramMediumTimes(
base::StrCat({"NQE.RTT.ObservationBufferLifeTime.",
base::UmaHistogramLongTimes100(
base::StrCat({"NQE.RTT.ObservationBufferLifeTime2.",
CategoryToString(observation_category)}),
delta);
base::UmaHistogramMediumTimes("NQE.RTT.ObservationBufferLifeTime.All",
delta);
base::UmaHistogramLongTimes100("NQE.RTT.ObservationBufferLifeTime2.All",
delta);
}
}

@ -6177,7 +6177,7 @@ chromium-metrics-reviews@google.com.
</token>
</histogram>
<histogram name="NQE.RTT.ObservationBufferLifeTime.{Category}" units="ms"
<histogram name="NQE.RTT.ObservationBufferLifeTime2.{Category}" units="ms"
expires_after="2025-02-01">
<owner>yyanagisawa@chromium.org</owner>
<owner>chrome-loading@google.com</owner>
@ -6187,6 +6187,7 @@ chromium-metrics-reviews@google.com.
duration on how long an observation is kept in the ObservationBuffer so that
we can understand how fast the new status will be reflected. Recorded when
an observation is added to the buffer and an old observation gets evicted.
(Max 1 hour, 100 buckets)
</summary>
<token key="Category">
<variant name="All"