0

Do IWYU for base/metrics/field_trial_params.h.

Include it directly, rather than relying on other headers to include it.
Fix minor style guide violations along the way.

Change-Id: I7d89b4708fbd34bddb25be9157c663104bb74d8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2850480
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Owners-Override: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#876304}
This commit is contained in:
Lei Zhang
2021-04-26 21:25:42 +00:00
committed by Chromium LUCI CQ
parent 3ceaf14c69
commit ca268b39b5
31 changed files with 41 additions and 5 deletions
chrome/browser
components
content/browser/renderer_host/input
device/fido
extensions/browser
gin
media/base
mojo/core/embedder
services/image_annotation

@ -11,6 +11,7 @@
#include "base/macros.h"
#include "base/memory/scoped_refptr.h"
#include "base/memory/singleton.h"
#include "base/metrics/field_trial_params.h"
#include "base/task/post_task.h"
#include "base/time/default_clock.h"
#include "base/trace_event/trace_event.h"

@ -6,6 +6,7 @@
#define CHROME_BROWSER_PREDICTORS_PREDICTORS_FEATURES_H_
#include "base/feature_list.h"
#include "base/metrics/field_trial_params.h"
namespace features {

@ -7,6 +7,7 @@
#include <string>
#include <utility>
#include "base/metrics/field_trial_params.h"
#include "base/metrics/histogram_functions.h"
#include "base/metrics/histogram_macros.h"
#include "base/optional.h"

@ -5,6 +5,7 @@
#include "chrome/browser/reputation/url_elision_policy.h"
#include "base/feature_list.h"
#include "base/metrics/field_trial_params.h"
#include "chrome/browser/reputation/local_heuristics.h"
#include "components/lookalikes/core/lookalike_url_util.h"
#include "components/omnibox/common/omnibox_features.h"

@ -8,6 +8,7 @@
#include <string>
#include <tuple>
#include "base/metrics/field_trial_params.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_split.h"
#include "services/device/public/mojom/serial.mojom.h"

@ -4,6 +4,8 @@
#include "chrome/browser/sharing/shared_clipboard/feature_flags.h"
#include "base/metrics/field_trial_params.h"
const base::Feature kSharedClipboardUI{"SharedClipboardUI",
base::FEATURE_DISABLED_BY_DEFAULT};

@ -5,6 +5,7 @@
#include "chrome/browser/ui/app_list/search/files/item_suggest_cache.h"
#include "base/bind.h"
#include "base/metrics/field_trial_params.h"
#include "base/metrics/histogram_macros.h"
#include "base/strings/strcat.h"
#include "chrome/browser/profiles/profile.h"

@ -5,6 +5,7 @@
#include "chrome/browser/ui/hats/hats_helper.h"
#include "base/callback_helpers.h"
#include "base/metrics/field_trial_params.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/hats/hats_service.h"
#include "chrome/browser/ui/hats/hats_service_factory.h"

@ -8,6 +8,7 @@
#include "base/bind.h"
#include "base/callback_helpers.h"
#include "base/metrics/field_trial_params.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/task_environment.h"
#include "components/assist_ranker/fake_ranker_model_loader.h"

@ -9,6 +9,7 @@
#include "base/bind.h"
#include "base/callback_helpers.h"
#include "base/feature_list.h"
#include "base/metrics/field_trial_params.h"
#include "base/test/scoped_feature_list.h"
#include "components/assist_ranker/fake_ranker_model_loader.h"
#include "components/assist_ranker/proto/ranker_model.pb.h"

@ -12,6 +12,7 @@
#include "base/bind.h"
#include "base/callback_helpers.h"
#include "base/feature_list.h"
#include "base/metrics/field_trial_params.h"
#include "base/test/scoped_feature_list.h"
#include "components/assist_ranker/example_preprocessing.h"
#include "components/assist_ranker/fake_ranker_model_loader.h"

@ -3,6 +3,8 @@
// found in the LICENSE file.
#include "components/assist_ranker/predictor_config_definitions.h"
#include "base/metrics/field_trial_params.h"
#include "components/assist_ranker/base_predictor.h"
namespace assist_ranker {

@ -6,6 +6,7 @@
#define COMPONENTS_BROWSER_SYNC_BROWSER_SYNC_SWITCHES_H_
#include "base/feature_list.h"
#include "base/metrics/field_trial_params.h"
#include "build/build_config.h"
namespace switches {

@ -8,6 +8,7 @@
#include <string>
#include "base/feature_list.h"
#include "base/metrics/field_trial_params.h"
namespace error_page {

@ -6,6 +6,7 @@
#define COMPONENTS_FEDERATED_LEARNING_FEATURES_FEATURES_H_
#include "base/feature_list.h"
#include "base/metrics/field_trial_params.h"
namespace federated_learning {
@ -18,4 +19,4 @@ extern const base::FeatureParam<int> kFlocIdFinchConfigVersion;
} // namespace federated_learning
#endif // COMPONENTS_FEDERATED_LEARNING_FEATURES_FEATURES_H_
#endif // COMPONENTS_FEDERATED_LEARNING_FEATURES_FEATURES_H_

@ -4,6 +4,7 @@
#include "components/invalidation/impl/invalidation_switches.h"
#include "base/metrics/field_trial_params.h"
#include "build/build_config.h"
namespace invalidation {

@ -3,7 +3,9 @@
// found in the LICENSE file.
#include "components/lens/lens_features.h"
#include "base/feature_list.h"
#include "base/metrics/field_trial_params.h"
namespace lens {
namespace features {

@ -5,13 +5,14 @@
// This header contains field trial and variations definitions for policies,
// mechanisms and features in the performance_manager component.
#include "base/feature_list.h"
#include "base/time/time.h"
#include "build/build_config.h"
#ifndef COMPONENTS_PERFORMANCE_MANAGER_PUBLIC_FEATURES_H_
#define COMPONENTS_PERFORMANCE_MANAGER_PUBLIC_FEATURES_H_
#include "base/feature_list.h"
#include "base/metrics/field_trial_params.h"
#include "base/time/time.h"
#include "build/build_config.h"
namespace performance_manager {
namespace features {

@ -6,6 +6,7 @@
#define COMPONENTS_PERMISSIONS_FEATURES_H_
#include "base/feature_list.h"
#include "base/metrics/field_trial_params.h"
namespace permissions {
namespace features {

@ -6,6 +6,7 @@
#define COMPONENTS_POLICY_CORE_COMMON_FEATURES_H_
#include "base/feature_list.h"
#include "base/metrics/field_trial_params.h"
#include "build/build_config.h"
#include "components/policy/policy_export.h"

@ -12,7 +12,9 @@
#include "base/feature_list.h"
#include "base/macros.h"
#include "base/metrics/field_trial_params.h"
#include "base/values.h"
namespace base {
class ListValue;
} // namespace base

@ -12,6 +12,7 @@
#include "base/feature_list.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/metrics/field_trial_params.h"
#include "base/strings/string_piece.h"
#include "components/subresource_filter/core/common/activation_list.h"
#include "components/subresource_filter/core/common/activation_scope.h"

@ -4,6 +4,8 @@
#include "components/sync/base/sync_base_switches.h"
#include "base/metrics/field_trial_params.h"
namespace switches {
// Overrides the default server used for profile sync.

@ -6,6 +6,7 @@
#define COMPONENTS_SYNC_DRIVER_SYNC_DRIVER_SWITCHES_H_
#include "base/feature_list.h"
#include "base/metrics/field_trial_params.h"
namespace switches {

@ -10,6 +10,7 @@
#include "base/auto_reset.h"
#include "base/macros.h"
#include "base/metrics/field_trial_params.h"
#include "base/metrics/histogram_macros.h"
#include "base/trace_event/trace_event.h"
#include "content/browser/renderer_host/input/touch_timeout_handler.h"

@ -6,6 +6,7 @@
#include "base/feature_list.h"
#include "base/json/json_reader.h"
#include "base/metrics/field_trial_params.h"
#include "base/no_destructor.h"
#include "base/optional.h"
#include "base/strings/pattern.h"

@ -14,6 +14,7 @@
#include "base/location.h"
#include "base/logging.h"
#include "base/macros.h"
#include "base/metrics/field_trial_params.h"
#include "base/metrics/histogram_macros.h"
#include "base/one_shot_event.h"
#include "base/single_thread_task_runner.h"

@ -6,6 +6,7 @@
#define GIN_GIN_FEATURES_H_
#include "base/feature_list.h"
#include "base/metrics/field_trial_params.h"
#include "gin/gin_export.h"
namespace features {

@ -10,6 +10,7 @@
#include <string>
#include "base/feature_list.h"
#include "base/metrics/field_trial_params.h"
#include "build/build_config.h"
#include "build/chromeos_buildflags.h"
#include "media/base/media_export.h"

@ -7,6 +7,7 @@
#include "base/component_export.h"
#include "base/feature_list.h"
#include "base/metrics/field_trial_params.h"
#include "build/build_config.h"
namespace mojo {

@ -7,6 +7,7 @@
#include <utility>
#include "base/bind.h"
#include "base/metrics/field_trial_params.h"
#include "base/time/time.h"
#include "url/gurl.h"