arc: Remove obsolete histograms related to notifications
This CL removes Arc.Notifications.ActionEnabled and Arc.Notifications.Style histograms. They are not used anymore. Bug: 392615939 Test: presubmit Change-Id: Ibbed9c367ce4bbf2102e41b45b3caa0e147f8c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6298070 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by: Lingyu Feng <lingyufeng@chromium.org> Cr-Commit-Position: refs/heads/main@{#1425666}
This commit is contained in:

committed by
Chromium LUCI CQ

parent
f0b8b5d3b1
commit
ca3980512c
chromeos/ash/experiences/arc/message_center
tools/metrics/histograms/metadata/arc
@ -238,8 +238,6 @@ void ArcNotificationManager::OnNotificationPosted(ArcNotificationDataPtr data) {
|
||||
DCHECK(result.second);
|
||||
it = result.first;
|
||||
|
||||
metrics_utils::LogArcNotificationStyle(data->style);
|
||||
metrics_utils::LogArcNotificationActionEnabled(data->is_action_enabled);
|
||||
metrics_utils::LogArcNotificationInlineReplyEnabled(
|
||||
data->is_inline_reply_enabled);
|
||||
metrics_utils::LogArcNotificationIsCustomNotification(
|
||||
|
@ -31,9 +31,6 @@ namespace ash {
|
||||
namespace {
|
||||
|
||||
constexpr char kDummyNotificationKey[] = "DUMMY_NOTIFICATION_KEY";
|
||||
constexpr char kHistogramNameActionEnabled[] =
|
||||
"Arc.Notifications.ActionEnabled";
|
||||
constexpr char kHistogramNameStyle[] = "Arc.Notifications.Style";
|
||||
constexpr char kHistogramNameInlineReplyEnabled[] =
|
||||
"Arc.Notifications.InlineReplyEnabled";
|
||||
constexpr char kHistogramNameIsCustomNotification[] =
|
||||
@ -364,22 +361,16 @@ TEST_F(ArcNotificationManagerTest, DoNotDisturbSyncInitialEnabledState) {
|
||||
TEST_F(ArcNotificationManagerTest,
|
||||
UmaMeticsPublishedOnlyWhenNotificationCreated) {
|
||||
base::HistogramTester histogram_tester;
|
||||
histogram_tester.ExpectTotalCount(kHistogramNameActionEnabled, 0);
|
||||
histogram_tester.ExpectTotalCount(kHistogramNameStyle, 0);
|
||||
histogram_tester.ExpectTotalCount(kHistogramNameInlineReplyEnabled, 0);
|
||||
histogram_tester.ExpectTotalCount(kHistogramNameIsCustomNotification, 0);
|
||||
|
||||
// Create notification
|
||||
std::string key = CreateNotification();
|
||||
histogram_tester.ExpectTotalCount(kHistogramNameActionEnabled, 1);
|
||||
histogram_tester.ExpectTotalCount(kHistogramNameStyle, 1);
|
||||
histogram_tester.ExpectTotalCount(kHistogramNameInlineReplyEnabled, 1);
|
||||
histogram_tester.ExpectTotalCount(kHistogramNameIsCustomNotification, 1);
|
||||
|
||||
// Update notification
|
||||
CreateNotificationWithKey(key);
|
||||
histogram_tester.ExpectTotalCount(kHistogramNameActionEnabled, 1);
|
||||
histogram_tester.ExpectTotalCount(kHistogramNameStyle, 1);
|
||||
histogram_tester.ExpectTotalCount(kHistogramNameInlineReplyEnabled, 1);
|
||||
histogram_tester.ExpectTotalCount(kHistogramNameIsCustomNotification, 1);
|
||||
}
|
||||
|
@ -8,19 +8,11 @@
|
||||
|
||||
namespace ash::metrics_utils {
|
||||
|
||||
void LogArcNotificationActionEnabled(bool action_enabled) {
|
||||
base::UmaHistogramBoolean("Arc.Notifications.ActionEnabled", action_enabled);
|
||||
}
|
||||
|
||||
void LogArcNotificationInlineReplyEnabled(bool inline_reply_enabled) {
|
||||
base::UmaHistogramBoolean("Arc.Notifications.InlineReplyEnabled",
|
||||
inline_reply_enabled);
|
||||
}
|
||||
|
||||
void LogArcNotificationStyle(arc::mojom::ArcNotificationStyle style) {
|
||||
base::UmaHistogramEnumeration("Arc.Notifications.Style", style);
|
||||
}
|
||||
|
||||
void LogArcNotificationIsCustomNotification(bool is_custom_notification) {
|
||||
base::UmaHistogramBoolean("Arc.Notifications.IsCustomNotification",
|
||||
is_custom_notification);
|
||||
|
@ -9,15 +9,9 @@
|
||||
|
||||
namespace ash::metrics_utils {
|
||||
|
||||
// Logs if action button is enabled for Arc notification.
|
||||
void LogArcNotificationActionEnabled(bool action_enabled);
|
||||
|
||||
// Logs if inline reply is enabled for Arc notification.
|
||||
void LogArcNotificationInlineReplyEnabled(bool inline_reply_enabled);
|
||||
|
||||
// Logs the style of Arc rich notification.
|
||||
void LogArcNotificationStyle(arc::mojom::ArcNotificationStyle style);
|
||||
|
||||
// Logs if the notification is custom notification.
|
||||
void LogArcNotificationIsCustomNotification(bool is_custom_notification);
|
||||
|
||||
|
@ -345,18 +345,6 @@ chromium-metrics-reviews@google.com.
|
||||
<int value="42" label="Disconnect service (ArcHostVpnService)"/>
|
||||
</enum>
|
||||
|
||||
<enum name="ArcNotificationStyle">
|
||||
<int value="0" label="No Style"/>
|
||||
<int value="1" label="Big Picture Style"/>
|
||||
<int value="2" label="Big Text Style"/>
|
||||
<int value="3" label="Messaging Style"/>
|
||||
<int value="4" label="Inbox Style"/>
|
||||
<int value="5" label="Media Style"/>
|
||||
<int value="6" label="Decorated Custom View Style"/>
|
||||
<int value="7" label="Decorated Media Custom View Style"/>
|
||||
<int value="8" label="Call Style"/>
|
||||
</enum>
|
||||
|
||||
<enum name="ArcOptInAction">
|
||||
<summary>Defines Arc OptIn actions</summary>
|
||||
<int value="0" label="DEPRECATED: Opted Out"/>
|
||||
|
@ -1608,16 +1608,6 @@ chromium-metrics-reviews@google.com.
|
||||
</summary>
|
||||
</histogram>
|
||||
|
||||
<histogram name="Arc.Notifications.ActionEnabled" enum="BooleanEnabled"
|
||||
expires_after="2025-03-09">
|
||||
<owner>yaoqq@google.com</owner>
|
||||
<owner>arc-framework@google.com</owner>
|
||||
<summary>
|
||||
Records whether at least one action button is enabled or not for an Arc
|
||||
notification when the notification is created.
|
||||
</summary>
|
||||
</histogram>
|
||||
|
||||
<histogram name="Arc.Notifications.InlineReplyEnabled" enum="BooleanEnabled"
|
||||
expires_after="2025-02-28">
|
||||
<owner>yaoqq@google.com</owner>
|
||||
@ -1637,13 +1627,6 @@ chromium-metrics-reviews@google.com.
|
||||
</summary>
|
||||
</histogram>
|
||||
|
||||
<histogram name="Arc.Notifications.Style" enum="ArcNotificationStyle"
|
||||
expires_after="2025-03-09">
|
||||
<owner>yaoqq@google.com</owner>
|
||||
<owner>arc-framework@google.com</owner>
|
||||
<summary>Records the style of an Arc notification when it's created.</summary>
|
||||
</histogram>
|
||||
|
||||
<histogram
|
||||
name="Arc.NotificationView.{ChildView}.{FadeType}.AnimationSmoothness"
|
||||
units="%" expires_after="2025-07-03">
|
||||
|
Reference in New Issue
Block a user