0

[Docs] Add guidance to not pass bugs back to sheriffs

As part of their role, sheriffs triage bugs for test failures and
flakes. They likely have no context into the code for that test, and
the bug shouldn't be assigned back to them after their shift. Add
guidance on this to sheriff.md.

Bug: None
Change-Id: I8100547d054bf382782cfb7538b8e91568425b0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3163063
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#921705}
This commit is contained in:
Devlin Cronin
2021-09-15 17:01:38 +00:00
committed by Chromium LUCI CQ
parent 5edbacb690
commit caddfe0f85

@ -41,3 +41,32 @@ The currently oncall sheriffs can be viewed in the top-left corner of the
[Chromium Main Console](https://ci.chromium.org/p/chromium/g/main/console). You
can also get in touch with sheriffs using the
[#sheriffing Slack channel](https://chromium.slack.com/messages/CGJ5WKRUH/).
## Please don't pass bugs back to the sheriff that assigned them to you
As part of their role, sheriffs will triage open test failures and flakes. If
possible, they will identify a culprit CL and revert it; however, sometimes this
is not feasible. In that case, sheriffs will assign these bugs to appropriate
owners. They typically do this by looking for:
1. The test author, or last person to make significant changes, or
2. A proximal OWNER of the test
_Pro-tip: Sheriffs, identify yourself in your comments, e.g., "[Sheriff]
assigning to the test author for further triage."_
If you are assigned a bug by a sheriff, please don't pass the bug back to that
person. Sheriffs have likely never seen the code before (or since), and are
unlikely to be much help. Additionally, if >8 hours have passed, that person is
no longer sheriff, and thus no longer responsible for triaging these bugs.
Instead, if you aren't the best owner for the bug, please help to triage it
more appropriately, since you're probably the test author, familiar with the
test, or an OWNER. If have no idea who a good owner for the test is (or were
assigned the bug in error\*), you can reapply the `Sheriff-Chromium` label and
flip the status to `Untriaged`; this will put it back in the sheriff queue for
the next sheriff to take a look at. Please only do this as a last resort, since
the next sheriff is unlikely to have any more information about the issue.
\*If you believe you were assigned the bug in error, it might be worth finding
out why the sheriff passed it to you, and remedying it if possible - e.g. by
updating OWNERS files.