chromium/src
0
Fork 0
Code Activity

Move PDF thumbnails files to //pdf/ui/

Browse Source 
These files mostly contain utilities for supporting the PDF Viewer's
thumbnail bar, thus qualifying them for inclusion in the new directory.

Bug: 1184342
Change-Id: Ifcb36dc9e27c0fc24c0abdac4e2d19d780e0d7fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2753341
Auto-Submit: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: K. Moon <kmoon@chromium.org>
Reviewed-by: K. Moon <kmoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#862222}
This commit is contained in:
Daniel Hosseinian
2021-03-12 00:44:51 +00:00
committed by Chromium LUCI CQ
parent b7b3b0d061
commit ccff9420ad
9 changed files with 14 additions and 14 deletions

6
pdf/BUILD.gn

@ -138,12 +138,12 @@ if (enable_pdf) {
"preview_mode_client.h",
"range_set.cc",
"range_set.h",
"thumbnail.cc",
"thumbnail.h",
"ui/file_name.cc",
"ui/file_name.h",
"ui/format_page_size.cc",
"ui/format_page_size.h",
"ui/thumbnail.cc",
"ui/thumbnail.h",
"url_loader_wrapper.h",
"url_loader_wrapper_impl.cc",
"url_loader_wrapper_impl.h",
@ -364,9 +364,9 @@ if (enable_pdf) {
"ppapi_migration/url_loader_unittest.cc",
"range_set_unittest.cc",
"test/run_all_unittests.cc",
"thumbnail_unittest.cc",
"ui/file_name_unittest.cc",
"ui/format_page_size_unittest.cc",
"ui/thumbnail_unittest.cc",
]
configs += [

2
pdf/out_of_process_instance.cc

@ -43,8 +43,8 @@
#include "pdf/ppapi_migration/input_event_conversions.h"
#include "pdf/ppapi_migration/url_loader.h"
#include "pdf/ppapi_migration/value_conversions.h"
#include "pdf/thumbnail.h"
#include "pdf/ui/format_page_size.h"
#include "pdf/ui/thumbnail.h"
#include "ppapi/c/dev/ppb_cursor_control_dev.h"
#include "ppapi/c/pp_errors.h"
#include "ppapi/c/private/ppb_pdf.h"

2
pdf/pdfium/pdfium_engine_unittest.cc

@ -22,7 +22,7 @@
#include "pdf/ppapi_migration/input_event_conversions.h"
#include "pdf/test/test_client.h"
#include "pdf/test/test_document_loader.h"
#include "pdf/thumbnail.h"
#include "pdf/ui/thumbnail.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/gfx/geometry/point.h"

2
pdf/pdfium/pdfium_page.cc

@ -27,7 +27,7 @@
#include "pdf/pdfium/pdfium_engine.h"
#include "pdf/pdfium/pdfium_unsupported_features.h"
#include "pdf/ppapi_migration/geometry_conversions.h"
#include "pdf/thumbnail.h"
#include "pdf/ui/thumbnail.h"
#include "ppapi/c/private/ppb_pdf.h"
#include "printing/units.h"
#include "third_party/pdfium/public/cpp/fpdf_scopers.h"

2
pdf/pdfium/pdfium_page_unittest.cc

@ -21,7 +21,7 @@
#include "pdf/pdfium/pdfium_test_base.h"
#include "pdf/ppapi_migration/geometry_conversions.h"
#include "pdf/test/test_client.h"
#include "pdf/thumbnail.h"
#include "pdf/ui/thumbnail.h"
#include "ppapi/c/private/ppb_pdf.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/pdfium/public/fpdf_formfill.h"

4
pdf/ui/README.md

@ -4,5 +4,5 @@ This directory contains utilities for supporting PDF Viewer features other than
the main content area.
TODO(crbug.com/1184342): Accordingly move more code into this directory. For
instance, code that supports the document properties dialog and thumbnails
belong in this directory.
instance, code that supports the document properties dialog belong in this
directory.

2
pdf/thumbnail.cc → pdf/ui/thumbnail.cc

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "pdf/thumbnail.h"
#include "pdf/ui/thumbnail.h"
#include <algorithm>
#include <cmath>

6
pdf/thumbnail.h → pdf/ui/thumbnail.h

@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef PDF_THUMBNAIL_H_
#define PDF_THUMBNAIL_H_
#ifndef PDF_UI_THUMBNAIL_H_
#define PDF_UI_THUMBNAIL_H_
#include "third_party/skia/include/core/SkBitmap.h"
@ -38,4 +38,4 @@ class Thumbnail final {
} // namespace chrome_pdf
#endif // PDF_THUMBNAIL_H_
#endif // PDF_UI_THUMBNAIL_H_

2
pdf/thumbnail_unittest.cc → pdf/ui/thumbnail_unittest.cc

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "pdf/thumbnail.h"
#include "pdf/ui/thumbnail.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/gfx/geometry/size.h"