chromium/src
0
Fork 0
Code Activity

watchlists: Remove ortuno from bluetooth owners, watchlists, and histograms

Browse Source 
Change-Id: I51042eaf42b6dc073ce589e156790d83b0912725
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2909942
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#885875}
This commit is contained in:
Giovanni Ortuño Urquidi
2021-05-24 05:09:20 +00:00
committed by Chromium LUCI CQ
parent 2500060766
commit cd407aca38
3 changed files with 19 additions and 24 deletions
WATCHLISTS
device/bluetooth
OWNERS
tools/metrics/histograms/histograms_xml/bluetooth
histograms.xml

10
WATCHLISTS

@ -2072,8 +2072,7 @@
'android_flags': ['hnakashima+watch@chromium.org'],
'android_infobars': ['dfalcantara+watch@chromium.org'],
'android_infra': ['agrieve+watch@chromium.org'],
'android_item_chooser_dialogs': ['juncai+watch@chromium.org',
'ortuno+watch@chromium.org'],
'android_item_chooser_dialogs': ['juncai+watch@chromium.org'],
'android_omnibox': ['ender+watch@chromium.org',
'jinsukkim+watch@chromium.org'],
'android_search_widget': ['tedchoc+watch@chromium.org',
@ -2172,7 +2171,6 @@
'blink_bindings': ['blink-reviews-bindings@chromium.org', 'haraken@chromium.org'],
'blink_bindings_serialization': ['jbroman+watch@chromium.org'],
'blink_bluetooth': ['mattreynolds+watch@chromium.org',
'ortuno+watch@chromium.org',
'odejesush+watch@chromium.org'],
'blink_client_hints': ['yoavweiss@chromium.org'],
'blink_clipboard': ['dcheng@chromium.org'],
@ -2379,8 +2377,7 @@
'clipboard': ['dcheng@chromium.org'],
'components_deps': ['droger+watchlist@chromium.org'],
'compositor_animator': ['mdjones+watch@chromium.org'],
'content_bluetooth': ['mattreynolds+watch@chromium.org',
'ortuno+watch@chromium.org'],
'content_bluetooth': ['mattreynolds+watch@chromium.org'],
'content_index': ['rayankans+watch@chromium.org'],
'content_loader': ['loading-reviews@chromium.org'],
'content_security_policy':['antoniosartori+watch-csp@chromium.org',
@ -2422,8 +2419,7 @@
'dbus': ['hashimoto+watch@chromium.org'],
'demo_mode': ['cros-essential-apps-dev+watch@chromium.org'],
'desktop_in_product_help': ['collinbaker+watch@chromium.org'],
'device_bluetooth': ['mattreynolds+watch@chromium.org',
'ortuno+watch@chromium.org'],
'device_bluetooth': ['mattreynolds+watch@chromium.org'],
'device_chooser': ['juncai+watch@chromium.org',
'mattreynolds+watch@chromium.org',
'odejesush+watch@chromium.org'],

1
device/bluetooth/OWNERS

@ -1,4 +1,3 @@
ortuno@chromium.org
reillyg@chromium.org
per-file BUILD.gn=*

32
tools/metrics/histograms/histograms_xml/bluetooth/histograms.xml

@ -216,8 +216,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram name="Bluetooth.DiscoverySession.Stop.Outcome"
enum="BluetoothDiscoveryOutcomes" expires_after="2021-03-01">
<owner>ortuno@chromium.org</owner>
<owner>reillyg@chromium.org</owner>
<owner>deviceapi-team@google.com</owner>
<summary>
Records the outcome of calls to BluetoothDiscoverySession::Stop. Used to
prioritize efforts to fix failures of this function.
@ -239,8 +239,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
enum="MacOSBluetoothOperationsResult" expires_after="2021-01-31">
<!-- Name completed by histogram_suffixes name="WebBluetoothMacOSAPIs" -->
<owner>ortuno@chromium.org</owner>
<owner>reillyg@chromium.org</owner>
<owner>deviceapi-team@google.com</owner>
<summary>
Records how many times each macOS GATT error has occured. The results will
be used to determine how commun this errors are and if we need to provide
@ -371,8 +371,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram name="Bluetooth.Web.ChooserInteraction" enum="BooleanInvalid"
expires_after="2021-09-19">
<owner>ortuno@chromium.org</owner>
<owner>reillyg@chromium.org</owner>
<owner>deviceapi-team@google.com</owner>
<summary>
Counts how many times users interact with a regular chooser vs. an invalid
chooser. (A chooser is invalid when it's event handler becomes null.)
@ -381,8 +381,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram name="Bluetooth.Web.ConnectGATT.Outcome"
enum="WebBluetoothConnectGATTOutcome" expires_after="2021-09-19">
<owner>ortuno@chromium.org</owner>
<owner>reillyg@chromium.org</owner>
<owner>deviceapi-team@google.com</owner>
<summary>
Records the result of a device.gatt.connect() call. Used to understand what
errors developers are getting so we can target efforts toward the most
@ -392,8 +392,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram name="Bluetooth.Web.ConnectGATT.TimeFailed" units="ms"
expires_after="2021-01-31">
<owner>ortuno@chromium.org</owner>
<owner>reillyg@chromium.org</owner>
<owner>deviceapi-team@google.com</owner>
<summary>
Records how long it takes for a connection attempt to fail. Use to let
developers know how to better wait for and handle connection errors.
@ -402,8 +402,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram name="Bluetooth.Web.ConnectGATT.TimeSuccess" units="ms"
expires_after="2021-01-31">
<owner>ortuno@chromium.org</owner>
<owner>reillyg@chromium.org</owner>
<owner>deviceapi-team@google.com</owner>
<summary>
Records how long it takes for a device to successfully connect. Use to let
developers know how long it should take to connect to a BLE device.
@ -442,8 +442,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram name="Bluetooth.Web.GetCharacteristic.Characteristic"
enum="GATTCharacteristicHash" expires_after="2021-01-31">
<owner>ortuno@chromium.org</owner>
<owner>reillyg@chromium.org</owner>
<owner>deviceapi-team@google.com</owner>
<summary>
Records the UUIDs used when getting a characteristic. The recorded value is
a 31-bit hash of the UUID. Used to know what types of characteristics to
@ -467,8 +467,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram name="Bluetooth.Web.GetCharacteristics.Characteristic"
enum="GATTCharacteristicHash" expires_after="2021-01-31">
<owner>ortuno@chromium.org</owner>
<owner>reillyg@chromium.org</owner>
<owner>deviceapi-team@google.com</owner>
<summary>
Records the UUIDs used when getting characteristics. The recorded value is a
31-bit hash of the UUID. Used to know what types of characteristics to
@ -548,8 +548,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram name="Bluetooth.Web.GetPrimaryService.Outcome"
enum="WebBluetoothGetPrimaryServiceOutcome" expires_after="2021-01-31">
<owner>ortuno@chromium.org</owner>
<owner>reillyg@chromium.org</owner>
<owner>deviceapi-team@google.com</owner>
<summary>
Records the result of a GATTServer.getPrimaryService() call. Used to
understand what errors developers are getting so we can target efforts
@ -559,8 +559,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram name="Bluetooth.Web.GetPrimaryService.Services"
enum="GATTServiceHash" expires_after="2021-01-31">
<owner>ortuno@chromium.org</owner>
<owner>reillyg@chromium.org</owner>
<owner>deviceapi-team@google.com</owner>
<summary>
Records what GATT Services are used when connected. The record value is a
31-bit hash of the Service UUID. This will help us know if we should build
@ -570,8 +570,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram name="Bluetooth.Web.GetPrimaryServices.Outcome"
enum="WebBluetoothGetPrimaryServiceOutcome" expires_after="2021-01-31">
<owner>ortuno@chromium.org</owner>
<owner>reillyg@chromium.org</owner>
<owner>deviceapi-team@google.com</owner>
<summary>
Records the result of a GATTServer.getPrimaryServices() call. Used to
understand what errors developers are getting so we can target efforts
@ -581,8 +581,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram name="Bluetooth.Web.GetPrimaryServices.Services"
enum="GATTServiceHash" expires_after="2021-01-31">
<owner>ortuno@chromium.org</owner>
<owner>reillyg@chromium.org</owner>
<owner>deviceapi-team@google.com</owner>
<summary>
Records what GATT Services are used when connected. The record value is a
31-bit hash of the Service UUID. This will help us know if we should build
@ -692,8 +692,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram name="Bluetooth.Web.RequestDevice.Outcome"
enum="WebBluetoothRequestDeviceOutcome" expires_after="2021-09-19">
<owner>ortuno@chromium.org</owner>
<owner>reillyg@chromium.org</owner>
<owner>deviceapi-team@google.com</owner>
<summary>
Records the result of a navigator.bluetooth.requestDevice() call. Used to
understand what errors developers are getting so we can target efforts
@ -703,8 +703,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram name="Bluetooth.Web.RequestDevice.RSSISignalStrength" units="dBm"
expires_after="2022-04-09">
<owner>ortuno@chromium.org</owner>
<owner>reillyg@chromium.org</owner>
<owner>deviceapi-team@google.com</owner>
<summary>
Raw RSSI values provided to chooser, before processing them for display in
the Web Bluetooth chooser. This histogram is used to choose the 4 threshold
@ -716,8 +716,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram name="Bluetooth.Web.RequestDevice.RSSISignalStrengthLevel"
enum="WebBluetoothRSSISignalStrengthLevel" expires_after="2022-04-09">
<owner>ortuno@chromium.org</owner>
<owner>reillyg@chromium.org</owner>
<owner>deviceapi-team@google.com</owner>
<summary>
Displayed RSSI levels, after processing and as displayed to users in the Web
Bluetooth chooser.
@ -754,8 +754,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram name="Bluetooth.Web.RequestDevice.UnionOfServices.Services"
enum="GATTServiceHash" expires_after="2021-10-17">
<owner>ortuno@chromium.org</owner>
<owner>reillyg@chromium.org</owner>
<owner>deviceapi-team@google.com</owner>
<summary>
Records what services are used from either required or optional sets. The
recorded value is a 31-bit hash of the Service UUID. These results will help