chromium/src
0
Fork 0
Code Activity

Remove some superfluous //ui/gfx includes from //components headers

Browse Source 
With the exception of ui/gfx/color_utils.h, code in //ui/gfx use
namespace gfx, so if "gfx::" does not appear in a header, then it does
not need the //ui/gfx includes. The command below generated the list of
edited files:

git grep -l '^#include "ui/gfx' components|grep '\.h$'|xargs grep -L gfx::

Clean up those headers and then do IWYU to fix the build.

Bug: 40318405
Change-Id: I89122602c3aa7d09ac1490b48297bf09366f01e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6558849
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1462366}
This commit is contained in:
Lei Zhang
2025-05-19 11:59:38 -07:00
committed by Chromium LUCI CQ
parent e39e298e6e
commit cd98c2e633
23 changed files with 1 additions and 27 deletions

1
components/autofill/content/renderer/form_autofill_util.h

@ -26,7 +26,6 @@
#include "third_party/blink/public/web/web_autofill_state.h"
#include "third_party/blink/public/web/web_element_collection.h"
#include "third_party/blink/public/web/web_form_control_element.h"
#include "ui/gfx/geometry/rect_f.h"
class GURL;

1
components/background_fetch/background_fetch_delegate_base.h

@ -15,7 +15,6 @@
#include "base/memory/weak_ptr.h"
#include "components/download/public/background_service/download_params.h"
#include "content/public/browser/background_fetch_delegate.h"
#include "ui/gfx/image/image.h"
#include "url/origin.h"
namespace content {

1
components/exo/touch.h

@ -10,7 +10,6 @@
#include "base/memory/raw_ptr.h"
#include "components/exo/surface_observer.h"
#include "ui/events/event_handler.h"
#include "ui/gfx/geometry/point_f.h"
namespace ui {
class LocatedEvent;

1
components/lens/lens_url_utils.h

@ -10,7 +10,6 @@
#include "components/lens/lens_entrypoints.h"
#include "components/lens/lens_metadata.mojom.h"
#include "ui/gfx/geometry/size_f.h"
class GURL;

1
components/live_caption/caption_bubble_context_remote.h

@ -12,7 +12,6 @@
#include "components/live_caption/caption_bubble_context.h"
#include "media/mojo/mojom/speech_recognition.mojom.h"
#include "mojo/public/cpp/bindings/remote.h"
#include "ui/gfx/geometry/rect.h"
namespace captions {

1
components/omnibox/browser/inline_autocompletion_util.h

@ -10,7 +10,6 @@
#include <string>
#include <vector>
#include "components/omnibox/browser/in_memory_url_index_types.h"
#include "ui/gfx/range/range.h"
// Finds the first occurrence of |search| at a wordbreak within |text| starting
// at |search_start|.

1
components/open_from_clipboard/clipboard_recent_content_generic.h

@ -7,7 +7,6 @@
#include "base/time/time.h"
#include "components/open_from_clipboard/clipboard_recent_content.h"
#include "ui/gfx/image/image.h"
#include "url/gurl.h"
// An implementation of ClipboardRecentContent that uses

1
components/page_info/page_info_ui.h

@ -20,7 +20,6 @@
#include "components/privacy_sandbox/canonical_topic.h"
#include "components/safe_browsing/buildflags.h"
#include "ui/base/models/image_model.h"
#include "ui/gfx/native_widget_types.h"
#if !BUILDFLAG(IS_ANDROID)
#include "ui/gfx/image/image_skia.h"

1
components/password_manager/core/browser/leak_detection_dialog_utils.h

@ -13,7 +13,6 @@
#include "components/password_manager/core/browser/password_manager_metrics_util.h"
#include "components/strings/grit/components_strings.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/gfx/range/range.h"
#include "url/gurl.h"
namespace password_manager {

1
components/password_manager/core/browser/password_cross_domain_confirmation_popup_controller.h

@ -8,7 +8,6 @@
#include "base/functional/callback_forward.h"
#include "base/i18n/rtl.h"
#include "components/autofill/core/browser/suggestions/suggestion_hiding_reason.h"
#include "ui/gfx/geometry/rect_f.h"
#include "url/gurl.h"
namespace password_manager {

1
components/password_manager/core/browser/password_manager_util.h

@ -17,7 +17,6 @@
#include "components/device_reauth/device_authenticator.h"
#include "components/password_manager/core/browser/password_form.h"
#include "components/password_manager/core/browser/password_manager_client.h"
#include "ui/gfx/native_widget_types.h"
namespace password_manager {
class PasswordManagerDriver;

2
components/printing/test/mock_printer.h

@ -17,8 +17,6 @@
#include "printing/image.h"
#include "printing/mojom/print.mojom.h"
#include "printing/units.h"
#include "ui/gfx/geometry/rect_f.h"
#include "ui/gfx/geometry/size_f.h"
#if BUILDFLAG(ENABLE_PDF)
#define MOCK_PRINTER_SUPPORTS_PAGE_IMAGES

1
components/remote_cocoa/app_shim/alert.h

@ -11,7 +11,6 @@
#include "components/remote_cocoa/common/alert.mojom.h"
#include "mojo/public/cpp/bindings/pending_receiver.h"
#include "mojo/public/cpp/bindings/receiver.h"
#include "ui/gfx/text_elider.h"
@class AlertBridgeHelper;

1
components/remote_cocoa/app_shim/alert.mm

@ -11,6 +11,7 @@
#include "base/strings/sys_string_conversions.h"
#include "ui/accelerated_widget_mac/window_resize_helper_mac.h"
#include "ui/base/l10n/l10n_util_mac.h"
#include "ui/gfx/text_elider.h"
using remote_cocoa::mojom::AlertBridgeInitParams;
using remote_cocoa::mojom::AlertDisposition;

1
components/remote_cocoa/app_shim/menu_controller_cocoa_delegate_impl.h

@ -8,7 +8,6 @@
#include "components/remote_cocoa/app_shim/remote_cocoa_app_shim_export.h"
#include "components/remote_cocoa/common/menu.mojom.h"
#include "third_party/skia/include/core/SkColor.h"
#include "ui/gfx/font.h"
#import "ui/menus/cocoa/menu_controller.h"
REMOTE_COCOA_APP_SHIM_EXPORT

1
components/saved_tab_groups/public/saved_tab_group.h

@ -18,7 +18,6 @@
#include "components/tab_groups/tab_group_color.h"
#include "components/tab_groups/tab_group_id.h"
#include "google_apis/gaia/gaia_id.h"
#include "ui/gfx/image/image.h"
#include "url/gurl.h"
namespace tab_groups {

1
components/saved_tab_groups/public/tab_group_sync_service.h

@ -24,7 +24,6 @@
#include "components/sync/model/data_type_controller_delegate.h"
#include "components/tab_groups/tab_group_id.h"
#include "components/tab_groups/tab_group_visual_data.h"
#include "ui/gfx/range/range.h"
#include "url/gurl.h"
#if BUILDFLAG(IS_ANDROID)

1
components/sessions/core/tab_restore_service.h

@ -27,7 +27,6 @@
#include "components/tab_groups/tab_group_visual_data.h"
#include "ui/base/ui_base_types.h"
#include "ui/base/window_open_disposition.h"
#include "ui/gfx/geometry/rect.h"
namespace sessions {

1
components/ui_devtools/views/ui_element_with_metadata.h

@ -13,7 +13,6 @@
#include "components/ui_devtools/ui_element.h"
#include "ui/base/metadata/metadata_types.h"
#include "ui/compositor/layer.h"
#include "ui/gfx/geometry/rect.h"
namespace ui_devtools {

3
components/viz/common/skia_helper.h

@ -9,9 +9,6 @@
#include "third_party/skia/include/core/SkImage.h"
#include "third_party/skia/include/core/SkImageFilter.h"
#include "third_party/skia/include/core/SkPoint.h"
#include "ui/gfx/geometry/rect_f.h"
#include "ui/gfx/geometry/size.h"
#include "ui/gfx/geometry/vector2d_f.h"
namespace viz {
class VIZ_COMMON_EXPORT SkiaHelper {

3
components/viz/service/transitions/surface_animation_manager.h

@ -20,9 +20,6 @@
#include "components/viz/service/surfaces/surface_saved_frame.h"
#include "components/viz/service/transitions/transferable_resource_tracker.h"
#include "components/viz/service/viz_service_export.h"
#include "ui/gfx/animation/keyframe/animation_curve.h"
#include "ui/gfx/animation/keyframe/keyframe_effect.h"
#include "ui/gfx/animation/keyframe/keyframe_model.h"
namespace gpu {
class SharedImageInterface;

1
components/viz/service/transitions/transferable_resource_tracker.h

@ -19,7 +19,6 @@
#include "components/viz/service/viz_service_export.h"
#include "gpu/command_buffer/common/mailbox.h"
#include "gpu/command_buffer/common/sync_token.h"
#include "ui/gfx/geometry/size.h"
namespace viz {

1
components/webapps/browser/android/webapk/webapk_icons_hasher.h

@ -13,7 +13,6 @@
#include "base/memory/weak_ptr.h"
#include "base/types/pass_key.h"
#include "components/webapps/browser/android/webapk/webapk_single_icon_hasher.h"
#include "ui/gfx/geometry/size.h"
#include "url/gurl.h"
#include "url/origin.h"